Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.debian.kernel > #52256 > unrolled thread

Bug#801925: NULL pointer dereference: IP: [<f828a00c>] sr_runtime_suspend+0xc/0x20 [sr_mod]

Started byAlan Stern <stern@rowland.harvard.edu>
First post2016-01-19 17:50 +0100
Last post2016-02-09 22:00 +0100
Articles 7 — 4 participants

Back to article view | Back to linux.debian.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Bug#801925: NULL pointer dereference: IP: [<f828a00c>] sr_runtime_suspend+0xc/0x20 [sr_mod] Alan Stern <stern@rowland.harvard.edu> - 2016-01-19 17:50 +0100
    Bug#801925: NULL pointer dereference: IP: [<f828a00c>] sr_runtime_suspend+0xc/0x20 [sr_mod] Paul Menzel <paul.menzel@giantmonkey.de> - 2016-01-19 18:00 +0100
      Bug#801925: NULL pointer dereference: IP: [<f828a00c>] sr_runtime_suspend+0xc/0x20 [sr_mod] Alan Stern <stern@rowland.harvard.edu> - 2016-01-19 22:10 +0100
        Bug#801925: NULL pointer dereference: IP: [<f828a00c>] sr_runtime_suspend+0xc/0x20 [sr_mod] Paul Menzel <paul.menzel@giantmonkey.de> - 2016-01-20 00:30 +0100
        Bug#801925: NULL pointer dereference: IP: [<f828a00c>] sr_runtime_suspend+0xc/0x20 [sr_mod] Alexandre Rossi <alexandre.rossi@gmail.com> - 2016-01-20 23:10 +0100
          Bug#801925: NULL pointer dereference: IP: [<f828a00c>] sr_runtime_suspend+0xc/0x20 [sr_mod] Paul Menzel <paul.menzel@giantmonkey.de> - 2016-02-09 18:00 +0100
            Bug#801925: NULL pointer dereference: IP: [<f828a00c>] sr_runtime_suspend+0xc/0x20 [sr_mod] Ben Hutchings <ben@decadent.org.uk> - 2016-02-09 22:00 +0100

#52256 — Bug#801925: NULL pointer dereference: IP: [<f828a00c>] sr_runtime_suspend+0xc/0x20 [sr_mod]

FromAlan Stern <stern@rowland.harvard.edu>
Date2016-01-19 17:50 +0100
SubjectBug#801925: NULL pointer dereference: IP: [<f828a00c>] sr_runtime_suspend+0xc/0x20 [sr_mod]
Message-ID<qSHDH-23d-9@gated-at.bofh.it>
On Tue, 19 Jan 2016, Erich Schubert wrote:

> Hi,
> Attached are photos of the Kernel null pointer BUG that I'm observing.
> 
> These shots are with 4.4.0-rc8.
> As you can see, I have a similar trace to Paul, but the error occurs
> one stack frame earlier?

Yours is only slighly similar to Paul's.  He got an error in 
sr_runtime_suspend, but your error occurs in sd_resume -- a completely 
different function in a different source file.

> Maybe Alex issue is the same bug, but triggered slightly different or
> just the kernel compiled differently.
> __rpm_callback, scsi_autopm_put_device, __pm_runtime_resume, sd_probe
> is present in all of these traces.
> 
> Sorry, I do not have a lot of time right now to help testing or debugging.

I can't tell what's going wrong without some real debugging.  This
means somebody has to build and test a patched kernel.  There are no
problems on my computer, so it will have to be one or more of you guys.

Alan Stern

[toc] | [next] | [standalone]


#52258

FromPaul Menzel <paul.menzel@giantmonkey.de>
Date2016-01-19 18:00 +0100
Message-ID<qSHNp-26P-25@gated-at.bofh.it>
In reply to#52256

[Multipart message — attachments visible in raw view] — view raw

Dear Alan, dear Erich,


Am Dienstag, den 19.01.2016, 11:38 -0500 schrieb Alan Stern:
> On Tue, 19 Jan 2016, Erich Schubert wrote:

> > Attached are photos of the Kernel null pointer BUG that I'm observing.
> > 
> > These shots are with 4.4.0-rc8.
> > As you can see, I have a similar trace to Paul, but the error occurs
> > one stack frame earlier?
>
> Yours is only slighly similar to Paul's.  He got an error in 
> sr_runtime_suspend, but your error occurs in sd_resume -- a completely
> different function in a different source file.

if I remember correctly, it happened it different places for me too. In
the backlog you should see, that Ben gave me a patch to try and then it
wasn’t triggered as it failed somewhere else.

> > Maybe Alex issue is the same bug, but triggered slightly different or
> > just the kernel compiled differently.
> > __rpm_callback, scsi_autopm_put_device, __pm_runtime_resume, sd_probe
> > is present in all of these traces.
> > 
> > Sorry, I do not have a lot of time right now to help testing or debugging.
>
> I can't tell what's going wrong without some real debugging.  This
> means somebody has to build and test a patched kernel.  There are no
> problems on my computer, so it will have to be one or more of you
> guys.

Could you please attach the debugging patch. Hopefully Alexandre, Erich,
or I will have some spare time to build an image from it.

Alan, thank you a lot for being so responsive and helpful!


Thanks,

Paul
-- 
GPG-Schlüssel: 33623E9B
Fingerabdruck = 0EB1 649D 4361 D04F 3C70  6F71 4DD7 BF75 3362 3E9B

Giant Monkey Software Engineering GmbH

Brunnenstr. 7D
10119 Berlin Mitte

Geschäftsführer Adrian Fuhrmann, Lion Vollnhals und Paul Menzel

USt-IdNr.: DE281524720
HRB 139495 B Amtsgericht Charlottenburg

[toc] | [prev] | [next] | [standalone]


#52268

FromAlan Stern <stern@rowland.harvard.edu>
Date2016-01-19 22:10 +0100
Message-ID<qSLHk-4Uh-7@gated-at.bofh.it>
In reply to#52258

[Multipart message — attachments visible in raw view] — view raw

On Tue, 19 Jan 2016, Paul Menzel wrote:

> Could you please attach the debugging patch. Hopefully Alexandre, Erich,
> or I will have some spare time to build an image from it.

Actually, this patch is an attempt at a fix.  After looking more 
carefully at your log pictures, I realized what the problem must be.  

It's too bad nobody was able to capture a log where the error 
occurred in sr_runtime_suspend, though -- all the logs in the bug 
report show sd_runtime_resume.

> Alan, thank you a lot for being so responsive and helpful!

You're welcome.

Alan Stern

[toc] | [prev] | [next] | [standalone]


#52278

FromPaul Menzel <paul.menzel@giantmonkey.de>
Date2016-01-20 00:30 +0100
Message-ID<qSNSN-6gl-3@gated-at.bofh.it>
In reply to#52268

[Multipart message — attachments visible in raw view] — view raw

Dear Alan,


Am Dienstag, den 19.01.2016, 16:08 -0500 schrieb Alan Stern:
> On Tue, 19 Jan 2016, Paul Menzel wrote:
>
> > Could you please attach the debugging patch. Hopefully Alexandre, Erich,
> > or I will have some spare time to build an image from it.
> 
> Actually, this patch is an attempt at a fix.  After looking more 
> carefully at your log pictures, I realized what the problem must be.  

that indeed fixed it for me. I applied your patch on
linux-image-4.4.0-rc8-686 [1] and was able to get to the LUKS passphrase
dialog. Awesome! Thank you very, very much!

[…]


Thanks,

Paul


[1] https://packages.debian.org/experimental/linux-image-4.4.0-rc8-686
-- 
GPG-Schlüssel: 33623E9B
Fingerabdruck = 0EB1 649D 4361 D04F 3C70  6F71 4DD7 BF75 3362 3E9B

Giant Monkey Software Engineering GmbH

Brunnenstr. 7D
10119 Berlin Mitte

Geschäftsführer Adrian Fuhrmann, Lion Vollnhals und Paul Menzel

USt-IdNr.: DE281524720
HRB 139495 B Amtsgericht Charlottenburg

[toc] | [prev] | [next] | [standalone]


#52304

FromAlexandre Rossi <alexandre.rossi@gmail.com>
Date2016-01-20 23:10 +0100
Message-ID<qT96Y-4g8-41@gated-at.bofh.it>
In reply to#52268
Hi,

>> Could you please attach the debugging patch. Hopefully Alexandre, Erich,
>> or I will have some spare time to build an image from it.
>
> Actually, this patch is an attempt at a fix.  After looking more
> carefully at your log pictures, I realized what the problem must be.
>
> It's too bad nobody was able to capture a log where the error
> occurred in sr_runtime_suspend, though -- all the logs in the bug
> report show sd_runtime_resume.

I just tested the patch applied on top of 4.3.3 (4.3.3-6 in Debian).

It still crashes at boot, but the stacktrace is different : it happens
in blk_post_runtime_resume . Maybe I'm bit by a different bug or maybe
the I need to try with 4.4.

I'll post the captured log when I have access to a wired network. I'd
be happy to provide the logs of a debugging patch.

Alex

[toc] | [prev] | [next] | [standalone]


#52757

FromPaul Menzel <paul.menzel@giantmonkey.de>
Date2016-02-09 18:00 +0100
Message-ID<r0jNU-6Mt-21@gated-at.bofh.it>
In reply to#52304

[Multipart message — attachments visible in raw view] — view raw

Dear Debian and Linux folks,


Am Mittwoch, den 20.01.2016, 23:07 +0100 schrieb Alexandre Rossi:

> >> Could you please attach the debugging patch. Hopefully Alexandre, Erich,
> >> or I will have some spare time to build an image from it.
> >
> > Actually, this patch is an attempt at a fix.  After looking more
> > carefully at your log pictures, I realized what the problem must be.
> >
> > It's too bad nobody was able to capture a log where the error
> > occurred in sr_runtime_suspend, though -- all the logs in the bug
> > report show sd_runtime_resume.
> 
> I just tested the patch applied on top of 4.3.3 (4.3.3-6 in Debian).
> 
> It still crashes at boot, but the stacktrace is different : it happens
> in blk_post_runtime_resume . Maybe I'm bit by a different bug or maybe
> the I need to try with 4.4.
> 
> I'll post the captured log when I have access to a wired network. I'd
> be happy to provide the logs of a debugging patch.

I tried Linux 4.3.5-1 [1], which entered Debian Sid/unstable yesterday,
and I get the same null pointer dereference as Alexandre.

As this is Linux 4.3 and not 4.4, I guess this is a different problem
though. Alexandre, where you able to capture the stack trace? I’d submit
a new bug report with this.


Thanks,

Paul


[1] http://metadata.ftp-master.debian.org/changelogs/main/l/linux/linux_4.3.5-1_changelog
-- 
GPG-Schlüssel: 33623E9B
Fingerabdruck = 0EB1 649D 4361 D04F 3C70  6F71 4DD7 BF75 3362 3E9B

Giant Monkey Software Engineering GmbH

Brunnenstr. 7D
10119 Berlin Mitte

Geschäftsführer Adrian Fuhrmann, Lion Vollnhals und Paul Menzel

USt-IdNr.: DE281524720
HRB 139495 B Amtsgericht Charlottenburg

[toc] | [prev] | [next] | [standalone]


#52760

FromBen Hutchings <ben@decadent.org.uk>
Date2016-02-09 22:00 +0100
Message-ID<r0nyb-U6-9@gated-at.bofh.it>
In reply to#52757

[Multipart message — attachments visible in raw view] — view raw

On Tue, 2016-02-09 at 20:56 +0100, Alexandre Rossi wrote:
> Hi,
> 
> netconsole does not seem to work so early in the boot process this time.
> 
> > As this is Linux 4.3 and not 4.4, I guess this is a different problem
> > though. Alexandre, where you able to capture the stack trace? I’d submit
> > a new bug report with this.
> 
> Here is a photo. Please ping me if you need to test some debugging patches.

I'm pretty sure this crash is fixed by commit 4fd41a8552af ("SCSI: Fix NULL
pointer dereference in runtime PM"), which I've now queued up for 4.3
(though it's already in 4.4 which I'll probably upload to unstable soon).

Ben.

-- 
Ben Hutchings
Design a system any fool can use, and only a fool will want to use it.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.debian.kernel


csiph-web