Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.kernel > #51858 > unrolled thread

/usr/share/initramfs-tools/bin directory in cryptsetup package? (was: [pkg-cryptsetup-devel] Bug#782024: cryptsetup: [patch] fix remote unlock of encrypted root when plymouth is installed)

Back to article view | Back to linux.debian.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  /usr/share/initramfs-tools/bin directory in cryptsetup package? (was:  [pkg-cryptsetup-devel] Bug#782024: cryptsetup: [patch] fix remote unlock of  encrypted root when plymouth is installed) Jonas Meurer <jonas@freesources.org> - 2015-12-23 23:20 +0100
    Re: /usr/share/initramfs-tools/bin directory in cryptsetup package?  (was: [pkg-cryptsetup-devel] Bug#782024: cryptsetup: [patch] fix remote  unlock of encrypted root when plymouth is installed) Ben Hutchings <ben@decadent.org.uk> - 2015-12-24 00:20 +0100
      Re: /usr/share/initramfs-tools/bin directory in cryptsetup package? Jonas Meurer <jonas@freesources.org> - 2015-12-24 08:20 +0100

#51858 — /usr/share/initramfs-tools/bin directory in cryptsetup package? (was: [pkg-cryptsetup-devel] Bug#782024: cryptsetup: [patch] fix remote unlock of encrypted root when plymouth is installed)

[Multipart message — attachments visible in raw view] — view raw

Hi Ben,

a quick question to you as initramfs-tools maintainer: are you ok with
us adding a directory '/usr/share/initramfs-tools/bin' to the cryptsetup
package? We would like to place a script 'cryptroot-unlock' there which
is installed into /bin/ in initramfs. Thus the directory
'/usr/share/initramfs-tools/bin' seems most appropriate for us.

See the buglog[1] and below for further details.

Cheers
 jonas

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=782024

Am 23.12.2015 um 23:11 schrieb Jonas Meurer:
> Am 19.12.2015 um 18:50 schrieb Guilhem Moulin:
>> On Fri, 18 Dec 2015 at 19:16:56 -0500, Richard Hansen wrote:
>>>  * why SIGKILL instead of SIGTERM?  seems too aggressive
>>>  * perhaps add a waitpid() after the kill() to ensure that a second
>>>    plymouth won't be run before the first one exits
>>
>> Agreed, but unfortunately plymouth doesn't terminate on SIGTERM.
>>
>>>  * why does cryptroot-unlock use /bin/ash instead of /bin/sh?
>>>  * there are lots of BusyBox ashisms in the cryptroot-unlock script,
>>>    many of which can be easily replaced with POSIX conformant code
>>
>> POSIX's read builtin doesn't support the -s flag.  Sure we can replace
>> with stty with a trap to restore echo, but since busybox is a dependency
>> anyway I don't think it's worth it :-P
>>
>> I've addressed the rest in the updated patch.  Thanks for your input!
> 
> I've incorporated the patch into SVN now, with some minor tweaks:
> 
> * bin/unlock in the initramfs is renamed to bin/cryptroot-unlock.
> * some minor coding style changes.
> 
> Also I don't really like that we create the directory
> '/usr/share/initramfs-tools/bin'. This place belongs to initramfs-tools
> package in my eyes and we should at least ask the maintainers before
> introducing it. I'll ask Ben in another ping mail to bug #807527 about
> his option.
> 
> Guilhem, can you test the latest SVN version and verify that it works fo
> you?
> 
> Cheers
>  jonas
> 
> 
> 

[toc] | [next] | [standalone]

#51860 — Re: /usr/share/initramfs-tools/bin directory in cryptsetup package? (was: [pkg-cryptsetup-devel] Bug#782024: cryptsetup: [patch] fix remote unlock of encrypted root when plymouth is installed)

[Multipart message — attachments visible in raw view] — view raw

On Wed, 2015-12-23 at 23:19 +0100, Jonas Meurer wrote:
> Hi Ben,
> 
> a quick question to you as initramfs-tools maintainer: are you ok with
> us adding a directory '/usr/share/initramfs-tools/bin' to the cryptsetup
> package? We would like to place a script 'cryptroot-unlock' there which
> is installed into /bin/ in initramfs. Thus the directory
> '/usr/share/initramfs-tools/bin' seems most appropriate for us.
> 
> See the buglog[1] and below for further details.
[...]

Please don't create anything outside of the documented hook/script
directories under /usr/share/initramfs-tools.  Make your own directory
e.g. /usr/share/cryptsetup instead.

Ben.

-- 
Ben Hutchings
For every action, there is an equal and opposite criticism. - Harrison

[toc] | [prev] | [next] | [standalone]

#51863 — Re: /usr/share/initramfs-tools/bin directory in cryptsetup package?

[Multipart message — attachments visible in raw view] — view raw

Hi Ben,

Am 24.12.2015 um 00:18 schrieb Ben Hutchings:
> On Wed, 2015-12-23 at 23:19 +0100, Jonas Meurer wrote:
>> Hi Ben,
>>
>> a quick question to you as initramfs-tools maintainer: are you ok with
>> us adding a directory '/usr/share/initramfs-tools/bin' to the cryptsetup
>> package? We would like to place a script 'cryptroot-unlock' there which
>> is installed into /bin/ in initramfs. Thus the directory
>> '/usr/share/initramfs-tools/bin' seems most appropriate for us.
>>
>> See the buglog[1] and below for further details.
> [...]
> 
> Please don't create anything outside of the documented hook/script
> directories under /usr/share/initramfs-tools.  Make your own directory
> e.g. /usr/share/cryptsetup instead.

Acknowledged and changed. Thanks for your reply.

Cheers
 jonas

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.kernel

csiph-web