Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.kernel > #92486 > unrolled thread

Bug#1136535: nfs-utils uses pidof but does not depend on procps

Back to article view | Back to linux.debian.kernel

Contents

  Bug#1136535: nfs-utils uses pidof but does not depend on procps Gioele Barabucci <gioele@debian.org> - 2026-05-14 01:40 +0200
    Processed: Re: Bug#1136535: nfs-utils uses pidof but does not  depend on procps "Debian Bug Tracking System" <owner@bugs.debian.org> - 2026-05-20 22:10 +0200
    Bug#1136535: nfs-utils uses pidof but does not depend on procps Salvatore Bonaccorso <carnil@debian.org> - 2026-05-20 22:10 +0200
      Bug#1136535: nfs-utils uses pidof but does not depend on procps Gioele Barabucci <gioele@debian.org> - 2026-05-20 22:20 +0200
    Bug#1136535: marked as done (nfs-utils uses pidof but does not  depend on procps) "Debian Bug Tracking System" <owner@bugs.debian.org> - 2026-07-31 22:40 +0200

#92486 — Bug#1136535: nfs-utils uses pidof but does not depend on procps

Source: nfs-utils
Version: 1:2.9.1-1
Usertags: pidof-without-procps

Dear maintainer(s) of nfs-utils,

it appears that nfs-utils uses `pidof` in its testsuite, or that
at least one of its binary packages uses `pidof` at runtime.
Historically, `pidof` was provided by the Essential package
`sysvinit-tools`, making an explicit dependency unnecessary. However
`pidof` will soon be moved to `procps` and will no longer be part of
the Essential set.

Please add an explicit dependency on `procps`:

* via the `Depends:` field of all binary packages of nfs-utils
  that use `pidof` at runtime;
* via the `Build-Depends:` field of nfs-utils, if `pidof` is
  used in tests run at build-time;
* via the `Depends:` field of `debian/control/tests`, if `pidof` is
  used in autopkgtests.

To prevent any disruption for users of nfs-utils, please add
this dependency now, before `pidof` is moved from `sysvinit-utils` to
`procps`. Alternatively, you could remove all uses of `pidof`.

It is believed that nfs-utils uses `pidof` due to the following
code snippets:

```
path: nfs-utils_1:2.8.6-1/debian/tests/v3-mount
grep "${hello}" /mnt/hello.txt
pidof rpc.statd > /dev/null 2>&1 || {
    echo "rpc.statd isn't running after the NVSv3 mount, and it should..."
    exit 1


path: nfs-utils_1:2.8.6-1/debian/tests/v3-mount
# stop statd if it's running, because we will check later if it
# was started automatically for the NFSv3 mount as it should
if pidof rpc.statd > /dev/null 2>&1; then
    systemctl stop rpc-statd.service > /dev/null 2>&1 || :
    pidof rpc.statd > /dev/null 2>&1 && {
```

Feel free to close this issue if this is a false positive (for example
if this code is in an unreachable code path).

Regards,

-- 
Gioele Barabucci

[toc] | [next] | [standalone]

#92636 — Processed: Re: Bug#1136535: nfs-utils uses pidof but does not depend on procps

Processing control commands:

> tags -1 + pending
Bug #1136535 [src:nfs-utils] nfs-utils uses pidof but does not depend on procps
Added tag(s) pending.

-- 
1136535: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1136535
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems

[toc] | [prev] | [next] | [standalone]

#92637

Control: tags -1 + pending 

Hi,

On Thu, May 14, 2026 at 01:29:37AM +0200, Gioele Barabucci wrote:
> Source: nfs-utils
> Version: 1:2.9.1-1
> Usertags: pidof-without-procps
> 
> Dear maintainer(s) of nfs-utils,
> 
> it appears that nfs-utils uses `pidof` in its testsuite, or that
> at least one of its binary packages uses `pidof` at runtime.
> Historically, `pidof` was provided by the Essential package
> `sysvinit-tools`, making an explicit dependency unnecessary. However
> `pidof` will soon be moved to `procps` and will no longer be part of
> the Essential set.
> 
> Please add an explicit dependency on `procps`:
> 
> * via the `Depends:` field of all binary packages of nfs-utils
>   that use `pidof` at runtime;
> * via the `Build-Depends:` field of nfs-utils, if `pidof` is
>   used in tests run at build-time;
> * via the `Depends:` field of `debian/control/tests`, if `pidof` is
>   used in autopkgtests.
> 
> To prevent any disruption for users of nfs-utils, please add
> this dependency now, before `pidof` is moved from `sysvinit-utils` to
> `procps`. Alternatively, you could remove all uses of `pidof`.
> 
> It is believed that nfs-utils uses `pidof` due to the following
> code snippets:
> 
> ```
> path: nfs-utils_1:2.8.6-1/debian/tests/v3-mount
> grep "${hello}" /mnt/hello.txt
> pidof rpc.statd > /dev/null 2>&1 || {
>     echo "rpc.statd isn't running after the NVSv3 mount, and it should..."
>     exit 1
> 
> 
> path: nfs-utils_1:2.8.6-1/debian/tests/v3-mount
> # stop statd if it's running, because we will check later if it
> # was started automatically for the NFSv3 mount as it should
> if pidof rpc.statd > /dev/null 2>&1; then
>     systemctl stop rpc-statd.service > /dev/null 2>&1 || :
>     pidof rpc.statd > /dev/null 2>&1 && {
> ```
> 
> Feel free to close this issue if this is a false positive (for example
> if this code is in an unreachable code path).

I addressed the case for the autopkgtest adding a Depends there.

But I won't add a Depends for nfs-common binary package providing
still the init script as well. The idea is to either drop the status
there or ask people who will still use the init scripts instead of the
systemd units to please provide a patch moving away of the pidof
usage there.

Regards,
Salvatore

[toc] | [prev] | [next] | [standalone]

#92638

Hi Salvatore,

On 20/05/26 22:07, Salvatore Bonaccorso wrote:
> On Thu, May 14, 2026 at 01:29:37AM +0200, Gioele Barabucci wrote:
>> It is believed that nfs-utils uses `pidof` due to the following
>> code snippets:
>>
>> ```
>> path: nfs-utils_1:2.8.6-1/debian/tests/v3-mount
>> grep "${hello}" /mnt/hello.txt
>> pidof rpc.statd > /dev/null 2>&1 || {
>>      echo "rpc.statd isn't running after the NVSv3 mount, and it should..."
>>      exit 1
>>
>>
>> path: nfs-utils_1:2.8.6-1/debian/tests/v3-mount
>> # stop statd if it's running, because we will check later if it
>> # was started automatically for the NFSv3 mount as it should
>> if pidof rpc.statd > /dev/null 2>&1; then
>>      systemctl stop rpc-statd.service > /dev/null 2>&1 || :
>>      pidof rpc.statd > /dev/null 2>&1 && {
>> ```
>>
>> Feel free to close this issue if this is a false positive (for example
>> if this code is in an unreachable code path).
> 
> I addressed the case for the autopkgtest adding a Depends there.

Thanks!

> But I won't add a Depends for nfs-common binary package providing
> still the init script as well. The idea is to either drop the status
> there or ask people who will still use the init scripts instead of the
> systemd units to please provide a patch moving away of the pidof
> usage there.

That's correct. The use of pidof in initscripts has been explicitly left 
out of this MBF because it will be addressed separately (see for 
instance https://bugs.debian.org/810018#327>).

Regards,

-- 
Gioele Barabucci

[toc] | [prev] | [next] | [standalone]

#93538 — Bug#1136535: marked as done (nfs-utils uses pidof but does not depend on procps)

[Multipart message — attachments visible in raw view] — view raw

Your message dated Fri, 31 Jul 2026 20:34:15 +0000
with message-id <E1wptvr-0000000C7kU-0GQu@fasolo.debian.org>
and subject line Bug#1136535: fixed in nfs-utils 1:2.9.2-1
has caused the Debian Bug report #1136535,
regarding nfs-utils uses pidof but does not depend on procps
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1136535: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1136535
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.kernel

csiph-web