Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.kernel > #83134 > unrolled thread

Bug#1076629: ethtool: Add Appstream metainfo announcing HW support

Back to article view | Back to linux.debian.kernel

Contents

  Bug#1076629: ethtool: Add Appstream metainfo announcing HW support Petter Reinholdtsen <pere@hungry.com> - 2024-07-20 11:10 +0200
    Bug#1076629: ethtool: Add Appstream metainfo announcing HW support Petter Reinholdtsen <pere@hungry.com> - 2025-01-25 06:30 +0100
      Bug#1076629: ethtool: Add Appstream metainfo announcing HW support Petter Reinholdtsen <pere@hungry.com> - 2025-02-21 12:30 +0100
        Bug#1076629: ethtool: Add Appstream metainfo announcing HW support Salvatore Bonaccorso <carnil@debian.org> - 2025-02-21 13:00 +0100
          Bug#1076629: ethtool: Add Appstream metainfo announcing HW support Petter Reinholdtsen <pere@hungry.com> - 2025-03-06 09:10 +0100
    Bug#1076629: marked as done (ethtool: Add Appstream metainfo  announcing HW support) "Debian Bug Tracking System" <owner@bugs.debian.org> - 2025-04-08 08:30 +0200
    Bug#1076629: fixed in ethtool 1:6.14-1 <asciiwolf@seznam.cz> - 2025-04-11 15:20 +0200

#83134 — Bug#1076629: ethtool: Add Appstream metainfo announcing HW support

Package: ethtool
Version: 1:6.1-1
Tags: patch
User: pere@hungry.com
Usertags: appstream-modalias

Here is a patch to add Appstream metainfo XML announcing the hardware
handled by this package.

Including this information in the package will ensure programs mapping
hardware to packages using Appstream information, like the isenkram
package, will know that this package is useful on machines where the
hardware ID is discovered.

diff --git a/debian/patches/1000-appstream-metainfo.patch b/debian/patches/1000-appstream-metainfo.patch
new file mode 100644
index 0000000..62cbaad
--- /dev/null
+++ b/debian/patches/1000-appstream-metainfo.patch
@@ -0,0 +1,45 @@
+Description: Added AppStream metainfo XML with hardware provide info.
+ This allow isenkram to propose this package when a ethernet card is
+ present.
+Author: Petter Reinholdtsen
+Forwarded: no
+Last-Update: 2024-07-20
+---
+Index: ethtool-salsa/Makefile.am
+===================================================================
+--- ethtool-salsa.orig/Makefile.am     2024-07-20 10:50:34.903244828 +0200
++++ ethtool-salsa/Makefile.am  2024-07-20 10:50:34.895244733 +0200
+@@ -3,7 +3,11 @@
+ LDADD = -lm
+ 
+ man_MANS = ethtool.8
+-EXTRA_DIST = LICENSE ethtool.8 ethtool.spec.in aclocal.m4 ChangeLog autogen.sh
++EXTRA_DIST = LICENSE ethtool.8 ethtool.spec.in aclocal.m4 ChangeLog autogen.sh \
++             org.kernel.software.network.ethtool.metainfo.xml
++
++dist_metainfo_DATA = org.kernel.software.network.ethtool.metainfo.xml
++metainfodir = $(datarootdir)/metainfo
+ 
+ sbin_PROGRAMS = ethtool
+ ethtool_SOURCES = ethtool.c uapi/linux/const.h uapi/linux/ethtool.h internal.h \
+Index: ethtool-salsa/org.kernel.software.network.ethtool.metainfo.xml
+===================================================================
+--- /dev/null  1970-01-01 00:00:00.000000000 +0000
++++ ethtool-salsa/org.kernel.software.network.ethtool.metainfo.xml     2024-07-20 10:51:29.651893714 +0200
+@@ -0,0 +1,16 @@
++<?xml version="1.0" encoding="UTF-8"?>
++<component type="desktop">
++  <id>org.kernel.software.network.ethtool</id>
++  <metadata_license>MIT</metadata_license>
++  <name>ethtool</name>
++  <summary>display or change Ethernet device settings</summary>
++  <description>
++    <p>ethtool can be used to query and change settings such as speed,
++    auto- negotiation and checksum offload on many network devices,
++    especially Ethernet devices.</p>
++  </description>
++  <url type="homepage">https://www.kernel.org/pub/software/network/ethtool/</url>
++  <provides>
++    <modalias>pci:v*d*sv*sd*bc02sc80i*</modalias>
++  </provides>
++</component>
diff --git a/debian/patches/series b/debian/patches/series
index e69de29..42e8b1a 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -0,0 +1 @@
+1000-appstream-metainfo.patch

-- 
Happy hacking
Petter Reinholdtsen

[toc] | [next] | [standalone]

#85273

Dear Debian Kernel Team, Salvatore and Ben,

Is there anything I can do to help get this AppStream fix into unstable?

-- 
Happy hacking
Petter Reinholdtsen

[toc] | [prev] | [next] | [standalone]

#86018

Dear Debian Kernel Team, Salvatore and Ben,

Is there some upstream you would rather I sent the Appstream hardware
mapping patch to instead?

-- 
Happy hacking
Petter Reinholdtsen

[toc] | [prev] | [next] | [standalone]

#86023

Hi Petter,

On Fri, Feb 21, 2025 at 12:26:04PM +0100, Petter Reinholdtsen wrote:
> Dear Debian Kernel Team, Salvatore and Ben,
> 
> Is there some upstream you would rather I sent the Appstream hardware
> mapping patch to instead?

I remember we discussed that some weeks ago with Ben. The first
premise is that we want to ship as less patches as needed and only if
there is a chance that it is upstream. This brings us to the second
point, that support should probably land upstream then we could pick
it in advance if it is queued for a next version.

So that would be to write to Michal Kubecek an the netdev mailinglist.

Details: https://www.kernel.org/pub/software/network/ethtool/devel.html

Keep us please in loop on upstream submission.

Regards,
Salvatore

[toc] | [prev] | [next] | [standalone]

#86355

My patch was posted to the list 2025-02-26 as 
<URL: https://lore.kernel.org/netdev/sa67c5cl62a.fsf@hjemme.reinholdtsen.name/T/#u >
with no response so far.  Am I supposed to nag regularly to get any
tracktion, if so, what is a good frequency to ensure it is not
forgotten?  Or should I leave it at this and just leave it in the hands
of others?

-- 
Happy hacking
Petter Reinholdtsen

[toc] | [prev] | [next] | [standalone]

#86779 — Bug#1076629: marked as done (ethtool: Add Appstream metainfo announcing HW support)

[Multipart message — attachments visible in raw view] — view raw

Your message dated Tue, 08 Apr 2025 06:20:31 +0000
with message-id <E1u22Jz-004SlK-64@fasolo.debian.org>
and subject line Bug#1076629: fixed in ethtool 1:6.14-1
has caused the Debian Bug report #1076629,
regarding ethtool: Add Appstream metainfo announcing HW support
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1076629: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1076629
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems

[toc] | [prev] | [next] | [standalone]

#86835 — Bug#1076629: fixed in ethtool 1:6.14-1

The AppStream metainfo file shipped with ethtool causes problems and potential system breakages for end-users because it contains incorrect (desktop) component type. See BTS#1102647 for more details.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.kernel

csiph-web