Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.kernel > #86833 > unrolled thread

Bug#1102647: ethtool should not be user uninstallable via GUI

Back to article view | Back to linux.debian.kernel

Contents

  Bug#1102647: ethtool should not be user uninstallable via GUI <asciiwolf@seznam.cz> - 2025-04-11 14:40 +0200
    Bug#1102647: ethtool should not be user uninstallable via GUI <asciiwolf@seznam.cz> - 2025-04-11 15:10 +0200
      Bug#1102647: ethtool should not be user uninstallable via GUI Petter Reinholdtsen <pere@hungry.com> - 2025-04-23 08:30 +0200
        Bug#1102647: ethtool should not be user uninstallable via GUI Salvatore Bonaccorso <carnil@debian.org> - 2025-04-23 10:40 +0200
          Bug#1102647: ethtool should not be user uninstallable via GUI Petter Reinholdtsen <pere@hungry.com> - 2025-04-23 10:50 +0200
    Processed: Re: ethtool should not be user uninstallable via GUI "Debian Bug Tracking System" <owner@bugs.debian.org> - 2025-04-23 08:30 +0200
    Bug#1102647: marked as done (ethtool should not be user  uninstallable via GUI) "Debian Bug Tracking System" <owner@bugs.debian.org> - 2025-04-30 07:10 +0200

#86833 — Bug#1102647: ethtool should not be user uninstallable via GUI

Package: ethtool
Version: 1:6.14-1

ethtool is user uninstallable via GUI (such as GNOME Software or KDE Discover). This is not correct since it is a (in many configurations pre-installed) system tool, not user app, and uninstalling it can also uninstall other critical system packages.

The main problem is the "desktop" component type in AppStream metadata:

$ head org.kernel.software.network.ethtool.metainfo.xml 
<?xml version="1.0" encoding="UTF-8"?>
<component type="desktop">
  <id>org.kernel.software.network.ethtool</id>
  <metadata_license>MIT</metadata_license>
  <name>ethtool</name>
  <summary>display or change Ethernet device settings</summary>
  <description>
    <p>ethtool can be used to query and change settings such as speed,
    auto- negotiation and checksum offload on many network devices,
    especially Ethernet devices.</p>

The correct component type should be "console-application".

(This should ideally be fixed in upstream as well.)

Alternative solution would be removing the whole metainfo file.

[toc] | [next] | [standalone]

#86834

https://freedesktop.org/software/appstream/docs/sect-Metadata-ConsoleApplication.html
https://freedesktop.org/software/appstream/docs/chap-Metadata.html#sect-Metadata-GenericComponent

[toc] | [prev] | [next] | [standalone]

#86957

Control: tags -1 + patch

A good patch fixing this is available from
<URL: https://lore.kernel.org/netdev/CAB-mu-TgZ5ewRzn45Q5LrGtEKWGhrafP39enmV0DAYvTkU5mwQ@mail.gmail.com/ >:

--- org.kernel.software.network.ethtool.metainfo.xml_orig
2025-03-31 00:46:03.000000000 +0200
+++ org.kernel.software.network.ethtool.metainfo.xml    2025-04-11
22:14:11.634355310 +0200
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<component type="desktop">
+<component type="console-application">
   <id>org.kernel.software.network.ethtool</id>
   <metadata_license>MIT</metadata_license>
   <name>ethtool</name>
@@ -11,6 +11,7 @@
   </description>
   <url type="homepage">https://www.kernel.org/pub/software/network/ethtool/</url>
   <provides>
+    <binary>ethtool</binary>
     <modalias>pci:v*d*sv*sd*bc02sc80i*</modalias>
   </provides>
 </component>

It should fix the issues reported on
<URL: https://appstream.debian.org/sid/main/issues/ethtool.html >.

-- 
Happy hacking
Petter Reinholdtsen

[toc] | [prev] | [next] | [standalone]

#86962

Hi,

On Wed, Apr 23, 2025 at 08:23:56AM +0200, Petter Reinholdtsen wrote:
> Control: tags -1 + patch
> 
> A good patch fixing this is available from
> <URL: https://lore.kernel.org/netdev/CAB-mu-TgZ5ewRzn45Q5LrGtEKWGhrafP39enmV0DAYvTkU5mwQ@mail.gmail.com/ >:

Yes, aware of this, but waiting until it get accepted upstream and
then cherry-pick it from there.

Regards,
Salvatore

[toc] | [prev] | [next] | [standalone]

#86963

[Salvatore Bonaccorso]
> Yes, aware of this, but waiting until it get accepted upstream and
> then cherry-pick it from there.

Very good.  Then I will assume you take action in time of the
freeze if the upstream acceptance do not make it early enough. :)

-- 
Happy hacking
Petter Reinholdtsen

[toc] | [prev] | [next] | [standalone]

#86956 — Processed: Re: ethtool should not be user uninstallable via GUI

Processing control commands:

> tags -1 + patch
Bug #1102647 [ethtool] ethtool should not be user uninstallable via GUI
Added tag(s) patch.

-- 
1102647: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1102647
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems

[toc] | [prev] | [next] | [standalone]

#87142 — Bug#1102647: marked as done (ethtool should not be user uninstallable via GUI)

[Multipart message — attachments visible in raw view] — view raw

Your message dated Wed, 30 Apr 2025 05:04:28 +0000
with message-id <E1u9zcS-00B2HF-9J@fasolo.debian.org>
and subject line Bug#1102647: fixed in ethtool 1:6.14-2
has caused the Debian Bug report #1102647,
regarding ethtool should not be user uninstallable via GUI
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1102647: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1102647
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.kernel

csiph-web