Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.kernel > #79606 > unrolled thread

Re: CONFIG_KEYBOARD_GPIO for debian linux-image-rpi

Back to article view | Back to linux.debian.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: CONFIG_KEYBOARD_GPIO for debian linux-image-rpi Salvatore Bonaccorso <carnil@debian.org> - 2023-07-15 10:40 +0200
    Re: CONFIG_KEYBOARD_GPIO for debian linux-image-rpi Pali Rohár <pali@kernel.org> - 2023-07-15 11:10 +0200
      Re: CONFIG_KEYBOARD_GPIO for debian linux-image-rpi Pali Rohár <pali@kernel.org> - 2023-08-07 01:30 +0200
        Re: CONFIG_KEYBOARD_GPIO for debian linux-image-rpi Salvatore Bonaccorso <carnil@debian.org> - 2023-08-13 14:30 +0200
          Re: CONFIG_KEYBOARD_GPIO for debian linux-image-rpi Uwe Kleine-König <ukleinek@debian.org> - 2023-08-14 11:50 +0200

#79606 — Re: CONFIG_KEYBOARD_GPIO for debian linux-image-rpi

Hi,

Let's loop in the Debian kernel team.

On Fri, Jul 14, 2023 at 10:51:19PM +0200, Pali Rohár wrote:
> Hello! I'm not sure who to ask about this issue but you are the last
> person who modified linux-image-rpi debian package for bookworm.
> 
> I have done clean install of bookworm for raspberrypi (armel, rev1b) and
> I figured out that kernel does not contain CONFIG_KEYBOARD_GPIO anymore.
> 
>   $ uname -a
>   Linux raspberrypi 6.1.0-10-rpi #1 Debian 6.1.37-1 (2023-07-03) armv6l GNU/Linux
> 
>   $ grep CONFIG_KEYBOARD_GPIO /boot/config-6.1.0-10-rpi
>   # CONFIG_KEYBOARD_GPIO is not set
>   # CONFIG_KEYBOARD_GPIO_POLLED is not set
> 
> So any gpio based keyboard on raspberry pi does not work. Personally I'm
> using shutdown gpio button and I read more forums that lot of other
> people are using gpio button for shutdown action too. So I think that in
> raspberrypi kernel specific package, this driver can be useful to have.
> 
> It there any reason why CONFIG_KEYBOARD_GPIO is disabled in bookworm
> kernel from linux-image-rpi package? And if not, would it be possible to
> enable this driver?

I do not think there is any special reason for that, and just might be
enabled for the rpi specific config, let's see what our arm* porters
say. And if nothing speaks about it we might top-down (in the upper
suites first, then maybe down to bookworm) enable it.

> CONFIG_KEYBOARD_GPIO is tristate symbol, so if there is space problem,
> it can be enabled as loadable module and it would be loaded ondemand
> only when needed.

In case of yes to above question, it should be enabled as loadable
module.

Thanks for raising it.

Regards,
Salvatore

[toc] | [next] | [standalone]

#79607

On Saturday 15 July 2023 10:31:53 Salvatore Bonaccorso wrote:
> Hi,
> 
> Let's loop in the Debian kernel team.
> 
> On Fri, Jul 14, 2023 at 10:51:19PM +0200, Pali Rohár wrote:
> > Hello! I'm not sure who to ask about this issue but you are the last
> > person who modified linux-image-rpi debian package for bookworm.
> > 
> > I have done clean install of bookworm for raspberrypi (armel, rev1b) and
> > I figured out that kernel does not contain CONFIG_KEYBOARD_GPIO anymore.
> > 
> >   $ uname -a
> >   Linux raspberrypi 6.1.0-10-rpi #1 Debian 6.1.37-1 (2023-07-03) armv6l GNU/Linux
> > 
> >   $ grep CONFIG_KEYBOARD_GPIO /boot/config-6.1.0-10-rpi
> >   # CONFIG_KEYBOARD_GPIO is not set
> >   # CONFIG_KEYBOARD_GPIO_POLLED is not set
> > 
> > So any gpio based keyboard on raspberry pi does not work. Personally I'm
> > using shutdown gpio button and I read more forums that lot of other
> > people are using gpio button for shutdown action too. So I think that in
> > raspberrypi kernel specific package, this driver can be useful to have.
> > 
> > It there any reason why CONFIG_KEYBOARD_GPIO is disabled in bookworm
> > kernel from linux-image-rpi package? And if not, would it be possible to
> > enable this driver?
> 
> I do not think there is any special reason for that, and just might be
> enabled for the rpi specific config, let's see what our arm* porters
> say. And if nothing speaks about it we might top-down (in the upper
> suites first, then maybe down to bookworm) enable it.

Ok, thank you for information. Just to note that lot of 32-bit and
64-bit ARM boards also use CONFIG_KEYBOARD_GPIO (for example run
git grep gpio-keys arch/arm{,64}/boot/dts), so maybe also other
configurations than rpi can benefit from having this driver enabled.

I have looked at my another debian system running on 64-bit ARM and in
older bullseye's kernel linux-image-5.10.0-23-arm64 package there is
CONFIG_KEYBOARD_GPIO driver, see:

  $ grep CONFIG_KEYBOARD_GPIO /boot/config-5.10.0-23-arm64
  CONFIG_KEYBOARD_GPIO=m
  # CONFIG_KEYBOARD_GPIO_POLLED is not set

> > CONFIG_KEYBOARD_GPIO is tristate symbol, so if there is space problem,
> > it can be enabled as loadable module and it would be loaded ondemand
> > only when needed.
> 
> In case of yes to above question, it should be enabled as loadable
> module.
> 
> Thanks for raising it.
> 
> Regards,
> Salvatore

[toc] | [prev] | [next] | [standalone]

#79948

On Saturday 15 July 2023 10:50:42 Pali Rohár wrote:
> On Saturday 15 July 2023 10:31:53 Salvatore Bonaccorso wrote:
> > Hi,
> > 
> > Let's loop in the Debian kernel team.

Hi, any opinion there?

> > On Fri, Jul 14, 2023 at 10:51:19PM +0200, Pali Rohár wrote:
> > > Hello! I'm not sure who to ask about this issue but you are the last
> > > person who modified linux-image-rpi debian package for bookworm.
> > > 
> > > I have done clean install of bookworm for raspberrypi (armel, rev1b) and
> > > I figured out that kernel does not contain CONFIG_KEYBOARD_GPIO anymore.
> > > 
> > >   $ uname -a
> > >   Linux raspberrypi 6.1.0-10-rpi #1 Debian 6.1.37-1 (2023-07-03) armv6l GNU/Linux
> > > 
> > >   $ grep CONFIG_KEYBOARD_GPIO /boot/config-6.1.0-10-rpi
> > >   # CONFIG_KEYBOARD_GPIO is not set
> > >   # CONFIG_KEYBOARD_GPIO_POLLED is not set
> > > 
> > > So any gpio based keyboard on raspberry pi does not work. Personally I'm
> > > using shutdown gpio button and I read more forums that lot of other
> > > people are using gpio button for shutdown action too. So I think that in
> > > raspberrypi kernel specific package, this driver can be useful to have.
> > > 
> > > It there any reason why CONFIG_KEYBOARD_GPIO is disabled in bookworm
> > > kernel from linux-image-rpi package? And if not, would it be possible to
> > > enable this driver?
> > 
> > I do not think there is any special reason for that, and just might be
> > enabled for the rpi specific config, let's see what our arm* porters
> > say. And if nothing speaks about it we might top-down (in the upper
> > suites first, then maybe down to bookworm) enable it.
> 
> Ok, thank you for information. Just to note that lot of 32-bit and
> 64-bit ARM boards also use CONFIG_KEYBOARD_GPIO (for example run
> git grep gpio-keys arch/arm{,64}/boot/dts), so maybe also other
> configurations than rpi can benefit from having this driver enabled.
> 
> I have looked at my another debian system running on 64-bit ARM and in
> older bullseye's kernel linux-image-5.10.0-23-arm64 package there is
> CONFIG_KEYBOARD_GPIO driver, see:
> 
>   $ grep CONFIG_KEYBOARD_GPIO /boot/config-5.10.0-23-arm64
>   CONFIG_KEYBOARD_GPIO=m
>   # CONFIG_KEYBOARD_GPIO_POLLED is not set
> 
> > > CONFIG_KEYBOARD_GPIO is tristate symbol, so if there is space problem,
> > > it can be enabled as loadable module and it would be loaded ondemand
> > > only when needed.
> > 
> > In case of yes to above question, it should be enabled as loadable
> > module.
> > 
> > Thanks for raising it.
> > 
> > Regards,
> > Salvatore

[toc] | [prev] | [next] | [standalone]

#80038

On Mon, Aug 07, 2023 at 01:05:06AM +0200, Pali Rohár wrote:
> On Saturday 15 July 2023 10:50:42 Pali Rohár wrote:
> > On Saturday 15 July 2023 10:31:53 Salvatore Bonaccorso wrote:
> > > Hi,
> > > 
> > > Let's loop in the Debian kernel team.
> 
> Hi, any opinion there?
> 
> > > On Fri, Jul 14, 2023 at 10:51:19PM +0200, Pali Rohár wrote:
> > > > Hello! I'm not sure who to ask about this issue but you are the last
> > > > person who modified linux-image-rpi debian package for bookworm.
> > > > 
> > > > I have done clean install of bookworm for raspberrypi (armel, rev1b) and
> > > > I figured out that kernel does not contain CONFIG_KEYBOARD_GPIO anymore.
> > > > 
> > > >   $ uname -a
> > > >   Linux raspberrypi 6.1.0-10-rpi #1 Debian 6.1.37-1 (2023-07-03) armv6l GNU/Linux
> > > > 
> > > >   $ grep CONFIG_KEYBOARD_GPIO /boot/config-6.1.0-10-rpi
> > > >   # CONFIG_KEYBOARD_GPIO is not set
> > > >   # CONFIG_KEYBOARD_GPIO_POLLED is not set
> > > > 
> > > > So any gpio based keyboard on raspberry pi does not work. Personally I'm
> > > > using shutdown gpio button and I read more forums that lot of other
> > > > people are using gpio button for shutdown action too. So I think that in
> > > > raspberrypi kernel specific package, this driver can be useful to have.
> > > > 
> > > > It there any reason why CONFIG_KEYBOARD_GPIO is disabled in bookworm
> > > > kernel from linux-image-rpi package? And if not, would it be possible to
> > > > enable this driver?
> > > 
> > > I do not think there is any special reason for that, and just might be
> > > enabled for the rpi specific config, let's see what our arm* porters
> > > say. And if nothing speaks about it we might top-down (in the upper
> > > suites first, then maybe down to bookworm) enable it.
> > 
> > Ok, thank you for information. Just to note that lot of 32-bit and
> > 64-bit ARM boards also use CONFIG_KEYBOARD_GPIO (for example run
> > git grep gpio-keys arch/arm{,64}/boot/dts), so maybe also other
> > configurations than rpi can benefit from having this driver enabled.
> > 
> > I have looked at my another debian system running on 64-bit ARM and in
> > older bullseye's kernel linux-image-5.10.0-23-arm64 package there is
> > CONFIG_KEYBOARD_GPIO driver, see:
> > 
> >   $ grep CONFIG_KEYBOARD_GPIO /boot/config-5.10.0-23-arm64
> >   CONFIG_KEYBOARD_GPIO=m
> >   # CONFIG_KEYBOARD_GPIO_POLLED is not set
> > 
> > > > CONFIG_KEYBOARD_GPIO is tristate symbol, so if there is space problem,
> > > > it can be enabled as loadable module and it would be loaded ondemand
> > > > only when needed.
> > > 
> > > In case of yes to above question, it should be enabled as loadable
> > > module.
> > > 
> > > Thanks for raising it.

Uwe, Vagrant, comments from you arm* porters? :) .

Regards,
Salvatore

[toc] | [prev] | [next] | [standalone]

#80054

Hello,

On 8/13/23 14:24, Salvatore Bonaccorso wrote:
> On Mon, Aug 07, 2023 at 01:05:06AM +0200, Pali Rohár wrote:
>> On Saturday 15 July 2023 10:50:42 Pali Rohár wrote:
>>> On Saturday 15 July 2023 10:31:53 Salvatore Bonaccorso wrote:
>>>> Hi,
>>>>
>>>> Let's loop in the Debian kernel team.
>>
>> Hi, any opinion there?
>>
>>>> On Fri, Jul 14, 2023 at 10:51:19PM +0200, Pali Rohár wrote:
>>>>> Hello! I'm not sure who to ask about this issue but you are the last
>>>>> person who modified linux-image-rpi debian package for bookworm.
>>>>>
>>>>> I have done clean install of bookworm for raspberrypi (armel, rev1b) and
>>>>> I figured out that kernel does not contain CONFIG_KEYBOARD_GPIO anymore.
>>>>>
>>>>>    $ uname -a
>>>>>    Linux raspberrypi 6.1.0-10-rpi #1 Debian 6.1.37-1 (2023-07-03) armv6l GNU/Linux
>>>>>
>>>>>    $ grep CONFIG_KEYBOARD_GPIO /boot/config-6.1.0-10-rpi
>>>>>    # CONFIG_KEYBOARD_GPIO is not set
>>>>>    # CONFIG_KEYBOARD_GPIO_POLLED is not set
>>>>>
>>>>> So any gpio based keyboard on raspberry pi does not work. Personally I'm
>>>>> using shutdown gpio button and I read more forums that lot of other
>>>>> people are using gpio button for shutdown action too. So I think that in
>>>>> raspberrypi kernel specific package, this driver can be useful to have.
>>>>>
>>>>> It there any reason why CONFIG_KEYBOARD_GPIO is disabled in bookworm
>>>>> kernel from linux-image-rpi package? And if not, would it be possible to
>>>>> enable this driver?

Hmm, the status quo is strange here:

  - enabled including the polled variant on arm64 and i686
  - enabled without the polled variant on armhf and amd64 (and I think
    x32)
  - only the polled driver on armel-marvell

I'm in favor of enabling them both as modules for arm*. I didn't find 
when it was disabled for armel-rpi, looking at the output of

	git grep KEYBOARD_GPIO debian/5.10.179-5
	git grep KEYBOARD_GPIO debian/4.19.160-2

I would have said that it was off on bullseye and buster, but maybe I'm 
missing something. (In that case my summary about master above is likely 
wrong, too.)

Best regards
Uwe

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.kernel

csiph-web