Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.kernel > #76618 > unrolled thread

Re: Bug#1022172: /lib/modprobe.d/50-nfs.conf causes initramfs-tools to stop including sunrpc module for nfs

Back to article view | Back to linux.debian.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: Bug#1022172: /lib/modprobe.d/50-nfs.conf causes initramfs-tools  to stop including sunrpc module for nfs Marco d'Itri <md@Linux.IT> - 2022-10-21 15:20 +0200
    Re: Bug#1022172: /lib/modprobe.d/50-nfs.conf causes initramfs-tools  to stop including sunrpc module for nfs Michael Prokop <mika@debian.org> - 2022-11-14 15:40 +0100
      Re: Bug#1022172: /lib/modprobe.d/50-nfs.conf causes initramfs-tools  to stop including sunrpc module for nfs Marco d'Itri <md@linux.it> - 2022-11-14 15:50 +0100
        Re: Bug#1024082: Bug#1022172: /lib/modprobe.d/50-nfs.conf causes  initramfs-tools to stop including sunrpc module for nfs Salvatore Bonaccorso <carnil@debian.org> - 2022-11-14 17:50 +0100
          Re: Bug#1022172: Bug#1024082: Bug#1022172:  /lib/modprobe.d/50-nfs.conf causes initramfs-tools to stop including sunrpc  module for nfs Marco d'Itri <md@linux.it> - 2022-11-14 19:10 +0100

#76618 — Re: Bug#1022172: /lib/modprobe.d/50-nfs.conf causes initramfs-tools to stop including sunrpc module for nfs

[Multipart message — attachments visible in raw view] — view raw

On Oct 21, Andras Korn <korn-debbugs@elan.rulez.org> wrote:

> I thought --ignore-install was completely broken, but no, because without it, the output contains *more* "install" lines:
What you are actually seeing is that --ignore-install is applied only to 
the nfs module (the one which you have requested to load) but not to its 
own dependencies:

diff -U 0 <(modprobe --all --set-version="6.0.0-1-amd64" --ignore-install --quiet --show-depends nfs) <(modprobe --all --set-version="6.0.0-1-amd64" --quiet --show-depends nfs)

I am not sure if this is a bug or a feature, so this should be discussed 
with the upstream maintainer.

So the possible solutions are:
- the semantics of --ignore-install are changed upstream (this may take 
  some time)
- initramfs-tools learns to parse the install directives
- nfs-kernel-server uses a different design

No matter what happens to --ignore-install I suggest that 
nfs-kernel-server will replace the modprobe configuration with some udev 
rules like this one (untested):

ACTION=="add", SUBSYSTEM=="module", KERNEL=="sunrpc", \
  RUN+="/sbin/sysctl -q --pattern sunrpc --system"

-- 
ciao,
Marco

[toc] | [next] | [standalone]

#77078

[Multipart message — attachments visible in raw view] — view raw

* Marco d'Itri [Sun Oct 23, 2022 at 12:05:18AM +0200]:
> On Oct 22, Andras Korn <korn-debbugs@elan.rulez.org> wrote:

> > nfs-kernel-server, for example, the 'install' command wants to invoke 
> > sysctl --pattern, but the busybox sysctl installed in the initramfs by 
> > default doesn't support --pattern. So the package would need to force 
> > initramfs to include the /sbin/sysctl from procps, and maybe also any 
> > pertinent files from /etc/sysctl.d.

> Looks like this is a different problem.

FYI: I reported this one as #1024082, looks like the new
/lib/modprobe.d/50-nfs.conf file is causing quite some problems.

(FTR, this showed up at the Grml live system, see e.g.
https://github.com/grml/grml/issues/193 )

regards
-mika-

[toc] | [prev] | [next] | [standalone]

#77079

[Multipart message — attachments visible in raw view] — view raw

On Nov 14, Michael Prokop <mika@debian.org> wrote:

> FYI: I reported this one as #1024082, looks like the new
> /lib/modprobe.d/50-nfs.conf file is causing quite some problems.
At this point we have established that for good or for worse kmod is 
behaving as documented, so we are down to one of:

- initramfs-tools learns to parse the install directives
- nfs-kernel-server uses udev rules instead

I recommend the second option, which is much more general and robust.

-- 
ciao,
Marco

[toc] | [prev] | [next] | [standalone]

#77082 — Re: Bug#1024082: Bug#1022172: /lib/modprobe.d/50-nfs.conf causes initramfs-tools to stop including sunrpc module for nfs

Control: tags 1024082  + upstream
Control: forwarded 1024082 https://lore.kernel.org/linux-nfs/Y1KoKwu88PulcokW@eldamar.lan/

On Mon, Nov 14, 2022 at 03:45:42PM +0100, Marco d'Itri wrote:
> On Nov 14, Michael Prokop <mika@debian.org> wrote:
> 
> > FYI: I reported this one as #1024082, looks like the new
> > /lib/modprobe.d/50-nfs.conf file is causing quite some problems.
> At this point we have established that for good or for worse kmod is 
> behaving as documented, so we are down to one of:
> 
> - initramfs-tools learns to parse the install directives
> - nfs-kernel-server uses udev rules instead
> 
> I recommend the second option, which is much more general and robust.

FWIW, I asked a while back upstream about it, and they would be open
to change this.

https://lore.kernel.org/linux-nfs/Y1KoKwu88PulcokW@eldamar.lan/
and
https://lore.kernel.org/linux-nfs/166656275785.12462.14027406790454668194@noble.neil.brown.name/

But it needs someone who is implementing the change and submits it
upstream. Michael, would you be able to work on this and submit the
change upstream? Once accepted there we can happily cherry pick it for
us.

We should not diverge to much from upstream at this point, this was
exactly one of the problems that nfs-utils remained for ages at an
ancient 1.3.4 based version. Now we have reduced the delta massively,
which helps keeping on track with upstream versions.

Regards,
Salvatore

[toc] | [prev] | [next] | [standalone]

#77084 — Re: Bug#1022172: Bug#1024082: Bug#1022172: /lib/modprobe.d/50-nfs.conf causes initramfs-tools to stop including sunrpc module for nfs

[Multipart message — attachments visible in raw view] — view raw

Try something like this in /lib/udev/rules.d/60-nfs.rules:

ACTION=="add", SUBSYSTEM=="module", KERNEL=="sunrpc", \
  RUN+="/sbin/sysctl -q --pattern ^sunrpc --system"
ACTION=="add", SUBSYSTEM=="module", KERNEL=="rpcrdma", \
  RUN+="/sbin/sysctl -q --pattern ^sunrpc.svc_rdma --system"
ACTION=="add", SUBSYSTEM=="module", KERNEL=="lockd", \
  RUN+="/sbin/sysctl -q --pattern ^fs.nfs.n[sl]m --system"
ACTION=="add", SUBSYSTEM=="module", KERNEL=="nfsv4", \
  RUN+="/sbin/sysctl -q --pattern ^fs.nfs.(nfs_callback_tcpport|idmap_cache_timeout) --system"
ACTION=="add", SUBSYSTEM=="module", KERNEL=="nfs", \
  RUN+="/sbin/sysctl -q --pattern ^fs.nfs --system"

Differently from the original file I tired anchoring the patterns, which 
looks more correct to me.

-- 
ciao,
Marco

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.kernel

csiph-web