Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.kernel > #74986 > unrolled thread

Patch for initramfs-tools-core (/usr/share/initramfs-tools/hooks/resume)

Back to article view | Back to linux.debian.kernel

Contents

  Patch for initramfs-tools-core (/usr/share/initramfs-tools/hooks/resume) Damian Szuberski <szuberskidamian@gmail.com> - 2022-04-05 22:20 +0200
    Re: Patch for initramfs-tools-core  (/usr/share/initramfs-tools/hooks/resume) Ben Hutchings <ben@decadent.org.uk> - 2022-04-11 17:00 +0200
      Re: Patch for initramfs-tools-core (/usr/share/initramfs-tools/hooks/resume) Damian Szuberski <szuberskidamian@gmail.com> - 2022-04-14 08:40 +0200
        Re: Patch for initramfs-tools-core  (/usr/share/initramfs-tools/hooks/resume) Ben Hutchings <ben@decadent.org.uk> - 2022-04-18 21:50 +0200
          Re: Patch for initramfs-tools-core (/usr/share/initramfs-tools/hooks/resume) Damian Szuberski <szuberskidamian@gmail.com> - 2022-04-22 12:50 +0200

#74986 — Patch for initramfs-tools-core (/usr/share/initramfs-tools/hooks/resume)

[Multipart message — attachments visible in raw view] — view raw

Dear Debian Kernel team!

What is the process of submitting patches to the initramfs package? I think
I have found an improvement area and I'm not sure how to proceed.

--- /usr/share/initramfs-tools/hooks/resume.orig        2022-04-05
21:59:52.595716073 +0200
+++ /usr/share/initramfs-tools/hooks/resume     2021-09-20
08:59:41.894951253 +0200
@@ -76,6 +76,11 @@
                        report_verbose "Rejecting $resume_auto since it is
zram"
                        ephemeral=true
                        ;;
+
+               /dev/zd[0-9]*)
+                       report_verbose "Rejecting $resume_auto since it is
zvol"
+                       ephemeral=true
+                       ;;
                esac

                $ephemeral || break

-- 
Damian Szuberski

[toc] | [next] | [standalone]

#75022 — Re: Patch for initramfs-tools-core (/usr/share/initramfs-tools/hooks/resume)

[Multipart message — attachments visible in raw view] — view raw

On Tue, 2022-04-05 at 22:00 +0200, Damian Szuberski wrote:
> Dear Debian Kernel team!
> 
> What is the process of submitting patches to the initramfs package? I think
> I have found an improvement area and I'm not sure how to proceed.

Either open a merge request (the repository is hosted at
<https://salsa.debian.org/kernel-team/initramfs-tools>) or open a bug
report with a patch attached.

In any case, you should start with the initramfs-tools source and not
the installed package.

Ben.

> --- /usr/share/initramfs-tools/hooks/resume.orig        2022-04-05
> 21:59:52.595716073 +0200
> +++ /usr/share/initramfs-tools/hooks/resume     2021-09-20
> 08:59:41.894951253 +0200
> @@ -76,6 +76,11 @@
>                         report_verbose "Rejecting $resume_auto since it is
> zram"
>                         ephemeral=true
>                         ;;
> +
> +               /dev/zd[0-9]*)
> +                       report_verbose "Rejecting $resume_auto since it is
> zvol"
> +                       ephemeral=true
> +                       ;;
>                 esac
> 
>                 $ephemeral || break
> 

-- 
Ben Hutchings
Knowledge is power.  France is bacon.

[toc] | [prev] | [next] | [standalone]

#75044

[Multipart message — attachments visible in raw view] — view raw

Hello Ben!

Thanks for the reply!
I cannot create a MR in web interface not submit it via email

```

Unfortunately, your email message to GitLab could not be processed.

You are not allowed to perform this action. If you believe this is in
error, contact a staff member.

```

Where could I request for access?

On Mon, Apr 11, 2022, 16:53 Ben Hutchings <ben@decadent.org.uk> wrote:

> On Tue, 2022-04-05 at 22:00 +0200, Damian Szuberski wrote:
> > Dear Debian Kernel team!
> >
> > What is the process of submitting patches to the initramfs package? I
> think
> > I have found an improvement area and I'm not sure how to proceed.
>
> Either open a merge request (the repository is hosted at
> <https://salsa.debian.org/kernel-team/initramfs-tools>) or open a bug
> report with a patch attached.
>
> In any case, you should start with the initramfs-tools source and not
> the installed package.
>
> Ben.
>
> > --- /usr/share/initramfs-tools/hooks/resume.orig        2022-04-05
> > 21:59:52.595716073 +0200
> > +++ /usr/share/initramfs-tools/hooks/resume     2021-09-20
> > 08:59:41.894951253 +0200
> > @@ -76,6 +76,11 @@
> >                         report_verbose "Rejecting $resume_auto since it
> is
> > zram"
> >                         ephemeral=true
> >                         ;;
> > +
> > +               /dev/zd[0-9]*)
> > +                       report_verbose "Rejecting $resume_auto since it
> is
> > zvol"
> > +                       ephemeral=true
> > +                       ;;
> >                 esac
> >
> >                 $ephemeral || break
> >
>
> --
> Ben Hutchings
> Knowledge is power.  France is bacon.
>

[toc] | [prev] | [next] | [standalone]

#75073 — Re: Patch for initramfs-tools-core (/usr/share/initramfs-tools/hooks/resume)

[Multipart message — attachments visible in raw view] — view raw

On Thu, 2022-04-14 at 08:19 +0200, Damian Szuberski wrote:
> Hello Ben!
> 
> Thanks for the reply!
> I cannot create a MR in web interface not submit it via email
>
> ```
> 
> Unfortunately, your email message to GitLab could not be processed.
> 
> You are not allowed to perform this action. If you believe this is in
> error, contact a staff member.
> 
> ```
> 
> Where could I request for access?
> 

I'm not familiar with the email interface.

The important thing is you need to have your own repository on Salsa
that is forked from the main one - see
<https://salsa.debian.org/help/user/project/repository/forking_workflow.md>.

Once you've done that, you should be able to push a branch to your
repository and open an MR - see
<https://salsa.debian.org/help/user/project/merge_requests/creating_merge_requests.md>.

Ben.

-- 
Ben Hutchings
To err is human; to really foul things up requires a computer.

[toc] | [prev] | [next] | [standalone]

#75113

[Multipart message — attachments visible in raw view] — view raw

Hello Ben!

I am much obliged for the explanation. I'm sorry I didn't realize Salsa
follows the casual "GitHub workflow".
I issued a MR
https://salsa.debian.org/kernel-team/initramfs-tools/-/merge_requests/60, I
think we can close this thread and continue the discussion there.

Have a great weekend!

On Mon, Apr 18, 2022 at 9:41 PM Ben Hutchings <ben@decadent.org.uk> wrote:

> On Thu, 2022-04-14 at 08:19 +0200, Damian Szuberski wrote:
> > Hello Ben!
> >
> > Thanks for the reply!
> > I cannot create a MR in web interface not submit it via email
> >
> > ```
> >
> > Unfortunately, your email message to GitLab could not be processed.
> >
> > You are not allowed to perform this action. If you believe this is in
> > error, contact a staff member.
> >
> > ```
> >
> > Where could I request for access?
> >
>
> I'm not familiar with the email interface.
>
> The important thing is you need to have your own repository on Salsa
> that is forked from the main one - see
> <https://salsa.debian.org/help/user/project/repository/forking_workflow.md
> >.
>
> Once you've done that, you should be able to push a branch to your
> repository and open an MR - see
> <
> https://salsa.debian.org/help/user/project/merge_requests/creating_merge_requests.md
> >.
>
> Ben.
>
> --
> Ben Hutchings
> To err is human; to really foul things up requires a computer.
>


-- 
Damian Szuberski

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.kernel

csiph-web