Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.kernel > #72626 > unrolled thread

Bug#992184: linux: Should CONFIG_LEDS_TRIGGER_HEARTBEAT be builtin?

Back to article view | Back to linux.debian.kernel

Contents

  Bug#992184: linux: Should CONFIG_LEDS_TRIGGER_HEARTBEAT be builtin? Diederik de Haas <didi.debian@cknow.org> - 2021-08-15 13:10 +0200
    Bug#992184: #992184 linux: Should CONFIG_LEDS_TRIGGER_HEARTBEAT be builtin? Diederik de Haas <didi.debian@cknow.org> - 2021-09-14 08:30 +0200
      Bug#992184: #992184 linux: Should CONFIG_LEDS_TRIGGER_HEARTBEAT be builtin? Diederik de Haas <didi.debian@cknow.org> - 2021-09-24 01:40 +0200
    Processed: Re: #992184 linux: Should CONFIG_LEDS_TRIGGER_HEARTBEAT  be builtin? "Debian Bug Tracking System" <owner@bugs.debian.org> - 2021-09-14 08:30 +0200
    Processed: Re: #992184 linux: Should CONFIG_LEDS_TRIGGER_HEARTBEAT  be builtin? "Debian Bug Tracking System" <owner@bugs.debian.org> - 2021-09-24 01:40 +0200
    Bug#992184: marked as done (linux: Should CONFIG_LEDS_TRIGGER_HEARTBEAT  be builtin?) "Debian Bug Tracking System" <owner@bugs.debian.org> - 2021-11-04 10:10 +0100

#72626 — Bug#992184: linux: Should CONFIG_LEDS_TRIGGER_HEARTBEAT be builtin?

[Multipart message — attachments visible in raw view] — view raw

Source: linux
Version: 5.13.9-1~exp2
Severity: wishlist

Currently there are some LED triggers builtin and some as modules:

$ grep 'CONFIG_LEDS_TRIGGER' /boot/config-5.13.0-trunk-arm64 
CONFIG_LEDS_TRIGGERS=y
CONFIG_LEDS_TRIGGER_TIMER=m
CONFIG_LEDS_TRIGGER_ONESHOT=m
CONFIG_LEDS_TRIGGER_DISK=y
CONFIG_LEDS_TRIGGER_MTD=y
CONFIG_LEDS_TRIGGER_HEARTBEAT=m
CONFIG_LEDS_TRIGGER_BACKLIGHT=m
CONFIG_LEDS_TRIGGER_CPU=y
CONFIG_LEDS_TRIGGER_ACTIVITY=m
CONFIG_LEDS_TRIGGER_GPIO=m
CONFIG_LEDS_TRIGGER_DEFAULT_ON=m
CONFIG_LEDS_TRIGGER_TRANSIENT=m
CONFIG_LEDS_TRIGGER_CAMERA=m
CONFIG_LEDS_TRIGGER_PANIC=y
CONFIG_LEDS_TRIGGER_NETDEV=m
CONFIG_LEDS_TRIGGER_PATTERN=m
CONFIG_LEDS_TRIGGER_AUDIO=m
# CONFIG_LEDS_TRIGGER_TTY is not set

While working on
https://salsa.debian.org/kernel-team/linux/-/merge_requests/384
I noticed that after enabling the modules, the heartbeat LED on my
Rock64 didn't turn 'on', while it is defined as the default trigger in
the DeviceTree. I noticed that `/sys/devices/platform/leds/leds/led-1/trigger`
didn't even contain 'heartbeat' as trigger.
After doing `modprobe ledtrig-heartbeat`, 'heartbeat' was available and
automatically selected as the current trigger.
Doing 'modprobe' is inconvenient, but that can be worked around by
creating a file in `/etc/modprobe.d/`.

But I use it in a similar way as 'panic', which is builtin. The Rock64
has a bit of a thermal problem and f.e. compiling a kernel is out of the
question without cooling (which I do not yet have). The CPU/device gets
so hot, it freezes and the only way out is pulling the plug. So when the
'heartbeat' LED stops blinking, I know it crashed.
Like 'panic', but with a slightly different cause.

As mentioned earlier, 'heartbeat' was defined as the default trigger in
the DeviceTree of the Rock64. It turns out, there are a lot more:
diederik@bagend:~/dev/debian/salsa/kernel-team/linux$ 
grep -r 'linux,default-trigger = "heartbeat";' arch/ | wc -l
281

Most are in arch arm*, but also in arc/powerpc/microblaze/mips.

Which raises the question (of this bug): 
Should `CONFIG_LEDS_TRIGGER_HEARTBEAT=m` be changed to `=y`?

Cheers,
  Diederik

PS: kernel is tainted as I'm running 5.13.9-1~exp3 which contain
modifications from MR 384, based off of current 'master'.
PS2: I sent this bug report earlier (against src:linux-config-5.13), but there 
was a problem with bugs.d.o, so I assume it went to /dev/null

-- System Information:
Debian Release: 11.0
  APT prefers stable
  APT policy: (990, 'stable'), (500, 'stable-security'), (500, 'unstable'), 
(101, 'experimental')
Architecture: arm64 (aarch64)

Kernel: Linux 5.13.0-trunk-arm64 (SMP w/4 CPU threads)
Kernel taint flags: TAINT_UNSIGNED_MODULE
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

[toc] | [next] | [standalone]

#72918 — Bug#992184: #992184 linux: Should CONFIG_LEDS_TRIGGER_HEARTBEAT be builtin?

[Multipart message — attachments visible in raw view] — view raw

Control: found -1 5.14.3-1~exp1
Control: tag -1 patch

On 15 Aug 2021 13:06:48 +0200 Diederik de Haas <didi.debian@cknow.org> wrote:
> Most are in arch arm*, but also in arc/powerpc/microblaze/mips.

At https://salsa.debian.org/kernel-team/linux/-/merge_requests/390 I submitted 
a MR which makes this trigger builtin on arm* platforms.

Cheers,
  Diederik

[toc] | [prev] | [next] | [standalone]

#73042 — Bug#992184: #992184 linux: Should CONFIG_LEDS_TRIGGER_HEARTBEAT be builtin?

[Multipart message — attachments visible in raw view] — view raw

Control: tag -1 pending

On 14 Sep 2021 02:16:18 +0200 Diederik de Haas <didi.debian@cknow.org> wrote:
> At https://salsa.debian.org/kernel-team/linux/-/merge_requests/390 
> I submitted  a MR which makes this trigger builtin on arm* platforms.

That MR got merged into the 'master' branch with:
https://salsa.debian.org/kernel-team/linux/-/commit/c74c840c943967163240901e057fe6f9ed280497

So adding the pending tag.

[toc] | [prev] | [next] | [standalone]

#72919 — Processed: Re: #992184 linux: Should CONFIG_LEDS_TRIGGER_HEARTBEAT be builtin?

Processing control commands:

> found -1 5.14.3-1~exp1
Bug #992184 [src:linux] linux: Should CONFIG_LEDS_TRIGGER_HEARTBEAT be builtin?
Marked as found in versions linux/5.14.3-1~exp1.
> tag -1 patch
Bug #992184 [src:linux] linux: Should CONFIG_LEDS_TRIGGER_HEARTBEAT be builtin?
Added tag(s) patch.

-- 
992184: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=992184
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems

[toc] | [prev] | [next] | [standalone]

#73043 — Processed: Re: #992184 linux: Should CONFIG_LEDS_TRIGGER_HEARTBEAT be builtin?

Processing control commands:

> tag -1 pending
Bug #992184 [src:linux] linux: Should CONFIG_LEDS_TRIGGER_HEARTBEAT be builtin?
Added tag(s) pending.

-- 
992184: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=992184
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems

[toc] | [prev] | [next] | [standalone]

#73596 — Bug#992184: marked as done (linux: Should CONFIG_LEDS_TRIGGER_HEARTBEAT be builtin?)

[Multipart message — attachments visible in raw view] — view raw

Your message dated Thu, 04 Nov 2021 09:00:08 +0000
with message-id <E1miYbQ-000Hhx-IG@fasolo.debian.org>
and subject line Bug#992184: fixed in linux 5.15-1~exp1
has caused the Debian Bug report #992184,
regarding linux: Should CONFIG_LEDS_TRIGGER_HEARTBEAT be builtin?
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
992184: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=992184
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.kernel

csiph-web