Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.kernel > #71885 > unrolled thread

Bug#757356: Scan codes still not generated for F1 to F12, Enter and Backspace

Started byVincent Lefevre <vincent@vinc17.net>
First post2021-05-26 10:00 +0200
Last post2021-07-26 16:20 +0200
Articles 8 — 3 participants

Back to article view | Back to linux.debian.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Bug#757356: Scan codes still not generated for F1 to F12, Enter and Backspace Vincent Lefevre <vincent@vinc17.net> - 2021-05-26 10:00 +0200
    Bug#757356: Scan code event not generated for some keys of the Apple keyboard: those in applespi_fn_codes Vincent Lefevre <vincent@vinc17.net> - 2021-05-26 10:50 +0200
      Bug#757356: Apple keyboard: Scan code event (EV_MSC) not generated when the EV_KEY event is generated by hid-apple.c Vincent Lefevre <vincent@vinc17.net> - 2021-05-26 12:10 +0200
        Bug#757356: Apple keyboard: Scan code event (EV_MSC) not generated when the EV_KEY event is generated by hid-apple.c Salvatore Bonaccorso <carnil@debian.org> - 2021-06-02 17:30 +0200
          Bug#757356: Apple keyboard: Scan code event (EV_MSC) not generated when the EV_KEY event is generated by hid-apple.c Vincent Lefevre <vincent@vinc17.net> - 2021-07-19 17:00 +0200
          Bug#757356: Apple keyboard: Scan code event (EV_MSC) not generated when the EV_KEY event is generated by hid-apple.c Vincent Lefevre <vincent@vinc17.net> - 2021-07-21 16:30 +0200
            Bug#757356: Apple keyboard: Scan code event (EV_MSC) not generated when the EV_KEY event is generated by hid-apple.c Daniel Lin <ephemient@gmail.com> - 2021-07-22 00:40 +0200
              Bug#757356: Apple keyboard: Scan code event (EV_MSC) not generated when the EV_KEY event is generated by hid-apple.c Vincent Lefevre <vincent@vinc17.net> - 2021-07-26 16:20 +0200

#71885 — Bug#757356: Scan codes still not generated for F1 to F12, Enter and Backspace

FromVincent Lefevre <vincent@vinc17.net>
Date2021-05-26 10:00 +0200
SubjectBug#757356: Scan codes still not generated for F1 to F12, Enter and Backspace
Message-ID<CiWCl-8px-1@gated-at.bofh.it>
Control: reopen -1
Control: found -1 5.10.38-1

On 2021-04-28 18:39:44 +0200, jmm@debian.org wrote:
> This bug was filed for a very old kernel. If you can reproduce it with
> - the current version in unstable/testing
> - the latest kernel from buster.backports
> please reopen the bug, see https://www.debian.org/Bugs/server-control

Bug still reproducible with linux-image-5.10.0-7-amd64 5.10.38-1.

# evtest
No device specified, trying to scan all of /dev/input/event*
Available devices:
/dev/input/event0:      AT Translated Set 2 keyboard
/dev/input/event1:      Video Bus
/dev/input/event2:      PS/2 Generic Mouse
/dev/input/event3:      Apple, Inc Apple Keyboard
/dev/input/event4:      Apple, Inc Apple Keyboard
/dev/input/event5:      PixArt USB Optical Mouse
[...]
Select the device event number [0-24]: 3
Input driver version is 1.0.1
Input device ID: bus 0x3 vendor 0x5ac product 0x221 version 0x111
Input device name: "Apple, Inc Apple Keyboard"
[...]
Testing ... (interrupt to exit)
Event: time 1622014586.354418, type 1 (EV_KEY), code 28 (KEY_ENTER), value 0
Event: time 1622014586.354418, -------------- SYN_REPORT ------------
Event: time 1622014588.314431, type 1 (EV_KEY), code 59 (KEY_F1), value 1
Event: time 1622014588.314431, -------------- SYN_REPORT ------------
éEvent: time 1622014588.402405, type 1 (EV_KEY), code 59 (KEY_F1), value 0
Event: time 1622014588.402405, -------------- SYN_REPORT ------------
Event: time 1622014591.010396, type 1 (EV_KEY), code 60 (KEY_F2), value 1
Event: time 1622014591.010396, -------------- SYN_REPORT ------------
èEvent: time 1622014591.130400, type 1 (EV_KEY), code 60 (KEY_F2), value 0
Event: time 1622014591.130400, -------------- SYN_REPORT ------------
Event: time 1622014593.266402, type 1 (EV_KEY), code 61 (KEY_F3), value 1
Event: time 1622014593.266402, -------------- SYN_REPORT ------------
êEvent: time 1622014593.418425, type 1 (EV_KEY), code 61 (KEY_F3), value 0
Event: time 1622014593.418425, -------------- SYN_REPORT ------------
Event: time 1622014594.258377, type 1 (EV_KEY), code 62 (KEY_F4), value 1
Event: time 1622014594.258377, -------------- SYN_REPORT ------------
ëEvent: time 1622014594.410386, type 1 (EV_KEY), code 62 (KEY_F4), value 0
Event: time 1622014594.410386, -------------- SYN_REPORT ------------
Event: time 1622014595.186424, type 1 (EV_KEY), code 63 (KEY_F5), value 1
Event: time 1622014595.186424, -------------- SYN_REPORT ------------
âEvent: time 1622014595.306297, type 1 (EV_KEY), code 63 (KEY_F5), value 0
Event: time 1622014595.306297, -------------- SYN_REPORT ------------
Event: time 1622014595.898361, type 1 (EV_KEY), code 64 (KEY_F6), value 1
Event: time 1622014595.898361, -------------- SYN_REPORT ------------
îEvent: time 1622014596.018362, type 1 (EV_KEY), code 64 (KEY_F6), value 0
Event: time 1622014596.018362, -------------- SYN_REPORT ------------
Event: time 1622014596.546417, type 1 (EV_KEY), code 65 (KEY_F7), value 1
Event: time 1622014596.546417, -------------- SYN_REPORT ------------
ôEvent: time 1622014596.666411, type 1 (EV_KEY), code 65 (KEY_F7), value 0
Event: time 1622014596.666411, -------------- SYN_REPORT ------------
Event: time 1622014597.130399, type 1 (EV_KEY), code 66 (KEY_F8), value 1
Event: time 1622014597.130399, -------------- SYN_REPORT ------------
ûEvent: time 1622014597.234394, type 1 (EV_KEY), code 66 (KEY_F8), value 0
Event: time 1622014597.234394, -------------- SYN_REPORT ------------
Event: time 1622014597.714254, type 1 (EV_KEY), code 67 (KEY_F9), value 1
Event: time 1622014597.714254, -------------- SYN_REPORT ------------
àEvent: time 1622014597.842254, type 1 (EV_KEY), code 67 (KEY_F9), value 0
Event: time 1622014597.842254, -------------- SYN_REPORT ------------
Event: time 1622014598.354389, type 1 (EV_KEY), code 68 (KEY_F10), value 1
Event: time 1622014598.354389, -------------- SYN_REPORT ------------
ùEvent: time 1622014598.458419, type 1 (EV_KEY), code 68 (KEY_F10), value 0
Event: time 1622014598.458419, -------------- SYN_REPORT ------------
Event: time 1622014598.962403, type 1 (EV_KEY), code 87 (KEY_F11), value 1
Event: time 1622014598.962403, -------------- SYN_REPORT ------------
ïEvent: time 1622014599.058405, type 1 (EV_KEY), code 87 (KEY_F11), value 0
Event: time 1622014599.058405, -------------- SYN_REPORT ------------
Event: time 1622014599.826412, type 1 (EV_KEY), code 88 (KEY_F12), value 1
Event: time 1622014599.826412, -------------- SYN_REPORT ------------
çEvent: time 1622014599.938401, type 1 (EV_KEY), code 88 (KEY_F12), value 0
Event: time 1622014599.938401, -------------- SYN_REPORT ------------
Event: time 1622014601.242407, type 4 (EV_MSC), code 4 (MSC_SCAN), value 70068
Event: time 1622014601.242407, type 1 (EV_KEY), code 110 (KEY_INSERT), value 1
Event: time 1622014601.242407, -------------- SYN_REPORT ------------
^[[2~Event: time 1622014601.378309, type 4 (EV_MSC), code 4 (MSC_SCAN), value 70068
Event: time 1622014601.378309, type 1 (EV_KEY), code 110 (KEY_INSERT), value 0
Event: time 1622014601.378309, -------------- SYN_REPORT ------------
Event: time 1622014602.914266, type 4 (EV_MSC), code 4 (MSC_SCAN), value 70069
Event: time 1622014602.914266, type 1 (EV_KEY), code 184 (KEY_F14), value 1
Event: time 1622014602.914266, -------------- SYN_REPORT ------------
Event: time 1622014603.066378, type 4 (EV_MSC), code 4 (MSC_SCAN), value 70069
Event: time 1622014603.066378, type 1 (EV_KEY), code 184 (KEY_F14), value 0
Event: time 1622014603.066378, -------------- SYN_REPORT ------------
Event: time 1622014603.706383, type 4 (EV_MSC), code 4 (MSC_SCAN), value 7006a
Event: time 1622014603.706383, type 1 (EV_KEY), code 185 (KEY_F15), value 1
Event: time 1622014603.706383, -------------- SYN_REPORT ------------
Event: time 1622014603.818374, type 4 (EV_MSC), code 4 (MSC_SCAN), value 7006a
Event: time 1622014603.818374, type 1 (EV_KEY), code 185 (KEY_F15), value 0

No MSC_SCAN line for F1 to F12.

There is no issue with F13 to F19 (note for 70068: I get KEY_INSERT
instead of KEY_F13 because I've rebound the key to insert via hwdb,
since the keyboard doesn't have an Insert key, replaced by fn; this
is expected).

Same issue for the Enter and Backspace keys:

Event: time 1622015066.745475, type 1 (EV_KEY), code 28 (KEY_ENTER), value 1
Event: time 1622015066.745475, -------------- SYN_REPORT ------------

Event: time 1622015066.857485, type 1 (EV_KEY), code 28 (KEY_ENTER), value 0
Event: time 1622015066.857485, -------------- SYN_REPORT ------------
Event: time 1622015072.137444, type 1 (EV_KEY), code 14 (KEY_BACKSPACE), value 1
Event: time 1622015072.137444, -------------- SYN_REPORT ------------
Event: time 1622015072.241435, type 1 (EV_KEY), code 14 (KEY_BACKSPACE), value 0
Event: time 1622015072.241435, -------------- SYN_REPORT ------------

Note that device 4 is used only for KEY_EJECTCD (this key doesn't
generate any even for device 3). I don't know whether this is a bug.

-- 
Vincent Lefèvre <vincent@vinc17.net> - Web: <https://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

[toc] | [next] | [standalone]

#71887 — Bug#757356: Scan code event not generated for some keys of the Apple keyboard: those in applespi_fn_codes

FromVincent Lefevre <vincent@vinc17.net>
Date2021-05-26 10:50 +0200
SubjectBug#757356: Scan code event not generated for some keys of the Apple keyboard: those in applespi_fn_codes
Message-ID<CiXoJ-tr-5@gated-at.bofh.it>
In reply to#71885
Control: retitle -1 Scan code event not generated for some keys of the Apple keyboard: those in applespi_fn_codes

On 2021-05-26 09:52:16 +0200, Vincent Lefevre wrote:
> No MSC_SCAN line for F1 to F12.
[...]
> Same issue for the Enter and Backspace keys:
[...]

And the cursor keys. Actually, all the keys corresponding to

static const struct applespi_key_translation applespi_fn_codes[] = {
        { KEY_BACKSPACE, KEY_DELETE },
        { KEY_ENTER,    KEY_INSERT },
        { KEY_F1,       KEY_BRIGHTNESSDOWN,     APPLE_FLAG_FKEY },
        { KEY_F2,       KEY_BRIGHTNESSUP,       APPLE_FLAG_FKEY },
        { KEY_F3,       KEY_SCALE,              APPLE_FLAG_FKEY },
        { KEY_F4,       KEY_DASHBOARD,          APPLE_FLAG_FKEY },
        { KEY_F5,       KEY_KBDILLUMDOWN,       APPLE_FLAG_FKEY },
        { KEY_F6,       KEY_KBDILLUMUP,         APPLE_FLAG_FKEY },
        { KEY_F7,       KEY_PREVIOUSSONG,       APPLE_FLAG_FKEY },
        { KEY_F8,       KEY_PLAYPAUSE,          APPLE_FLAG_FKEY },
        { KEY_F9,       KEY_NEXTSONG,           APPLE_FLAG_FKEY },
        { KEY_F10,      KEY_MUTE,               APPLE_FLAG_FKEY },
        { KEY_F11,      KEY_VOLUMEDOWN,         APPLE_FLAG_FKEY },
        { KEY_F12,      KEY_VOLUMEUP,           APPLE_FLAG_FKEY },
        { KEY_RIGHT,    KEY_END },
        { KEY_LEFT,     KEY_HOME },
        { KEY_DOWN,     KEY_PAGEDOWN },
        { KEY_UP,       KEY_PAGEUP },
        { }
};

in drivers/input/keyboard/applespi.c.

Just in case, in /etc/modprobe.d/hid_apple.conf, I have

options hid_apple fnmode=2
options hid_apple iso_layout=0

-- 
Vincent Lefèvre <vincent@vinc17.net> - Web: <https://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

[toc] | [prev] | [next] | [standalone]

#71889 — Bug#757356: Apple keyboard: Scan code event (EV_MSC) not generated when the EV_KEY event is generated by hid-apple.c

FromVincent Lefevre <vincent@vinc17.net>
Date2021-05-26 12:10 +0200
SubjectBug#757356: Apple keyboard: Scan code event (EV_MSC) not generated when the EV_KEY event is generated by hid-apple.c
Message-ID<CiYE9-1mW-3@gated-at.bofh.it>
In reply to#71887
Control: retitle -1 Apple keyboard: Scan code event (EV_MSC) not generated when the EV_KEY event is generated by hid-apple.c
Control: tags -1 patch

On 2021-05-26 10:39:11 +0200, Vincent Lefevre wrote:
> And the cursor keys. Actually, all the keys corresponding to
> 
> static const struct applespi_key_translation applespi_fn_codes[] = {
>         { KEY_BACKSPACE, KEY_DELETE },
>         { KEY_ENTER,    KEY_INSERT },
>         { KEY_F1,       KEY_BRIGHTNESSDOWN,     APPLE_FLAG_FKEY },
>         { KEY_F2,       KEY_BRIGHTNESSUP,       APPLE_FLAG_FKEY },
>         { KEY_F3,       KEY_SCALE,              APPLE_FLAG_FKEY },
>         { KEY_F4,       KEY_DASHBOARD,          APPLE_FLAG_FKEY },
>         { KEY_F5,       KEY_KBDILLUMDOWN,       APPLE_FLAG_FKEY },
>         { KEY_F6,       KEY_KBDILLUMUP,         APPLE_FLAG_FKEY },
>         { KEY_F7,       KEY_PREVIOUSSONG,       APPLE_FLAG_FKEY },
>         { KEY_F8,       KEY_PLAYPAUSE,          APPLE_FLAG_FKEY },
>         { KEY_F9,       KEY_NEXTSONG,           APPLE_FLAG_FKEY },
>         { KEY_F10,      KEY_MUTE,               APPLE_FLAG_FKEY },
>         { KEY_F11,      KEY_VOLUMEDOWN,         APPLE_FLAG_FKEY },
>         { KEY_F12,      KEY_VOLUMEUP,           APPLE_FLAG_FKEY },
>         { KEY_RIGHT,    KEY_END },
>         { KEY_LEFT,     KEY_HOME },
>         { KEY_DOWN,     KEY_PAGEDOWN },
>         { KEY_UP,       KEY_PAGEUP },
>         { }
> };
> 
> in drivers/input/keyboard/applespi.c.
> 
> Just in case, in /etc/modprobe.d/hid_apple.conf, I have
> 
> options hid_apple fnmode=2
> options hid_apple iso_layout=0

But since I'm using hid_apple, I should have taken
drivers/hid/hid-apple.c, which has the same kind of code:

static const struct apple_key_translation apple_fn_keys[] = {
        { KEY_BACKSPACE, KEY_DELETE },
        { KEY_ENTER,    KEY_INSERT },
        { KEY_F1,       KEY_BRIGHTNESSDOWN, APPLE_FLAG_FKEY },
        { KEY_F2,       KEY_BRIGHTNESSUP,   APPLE_FLAG_FKEY },
        { KEY_F3,       KEY_SCALE,          APPLE_FLAG_FKEY },
        { KEY_F4,       KEY_DASHBOARD,      APPLE_FLAG_FKEY },
        { KEY_F5,       KEY_KBDILLUMDOWN,   APPLE_FLAG_FKEY },
        { KEY_F6,       KEY_KBDILLUMUP,     APPLE_FLAG_FKEY },
        { KEY_F7,       KEY_PREVIOUSSONG,   APPLE_FLAG_FKEY },
        { KEY_F8,       KEY_PLAYPAUSE,      APPLE_FLAG_FKEY },
        { KEY_F9,       KEY_NEXTSONG,       APPLE_FLAG_FKEY },
        { KEY_F10,      KEY_MUTE,           APPLE_FLAG_FKEY },
        { KEY_F11,      KEY_VOLUMEDOWN,     APPLE_FLAG_FKEY },
        { KEY_F12,      KEY_VOLUMEUP,       APPLE_FLAG_FKEY },
        { KEY_UP,       KEY_PAGEUP },
        { KEY_DOWN,     KEY_PAGEDOWN },
        { KEY_LEFT,     KEY_HOME },
        { KEY_RIGHT,    KEY_END },
        { }
};

In the conditions from hidinput_apple_event(), the only ones that
should match according to my settings are

        if (usage->code == fn_keycode) {

and

        if (fnmode) {

and these are the keys (when trans is true, for fnmode) for which I do
not get a scan code event. Said otherwise, if hidinput_apple_event()
returns 1, I do not get a scan code event. There are input_event()
calls, but I suppose that they will just generate an EV_KEY event,
and EV_MSC is the one that is missing.

Note: in hid-apple.c, apple_event() calls hidinput_apple_event(), and
one has

static struct hid_driver apple_driver = {
[...]
        .event = apple_event,
[...]
};
module_hid_driver(apple_driver);

I forgot that there was

  https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=757356#35

from Daniel Lin, with a patch, in 2017. I've looked at this patch
(but have not tried it), and it adds an additional EV_MSC event
when hidinput_apple_event() has to generate an EV_KEY event. So
I confirm that should solve this issue and I'm adding the patch
tag (I don't know whether the patch needs an update, though).

-- 
Vincent Lefèvre <vincent@vinc17.net> - Web: <https://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

[toc] | [prev] | [next] | [standalone]

#72070 — Bug#757356: Apple keyboard: Scan code event (EV_MSC) not generated when the EV_KEY event is generated by hid-apple.c

FromSalvatore Bonaccorso <carnil@debian.org>
Date2021-06-02 17:30 +0200
SubjectBug#757356: Apple keyboard: Scan code event (EV_MSC) not generated when the EV_KEY event is generated by hid-apple.c
Message-ID<ClAYG-6ee-23@gated-at.bofh.it>
In reply to#71889
Hi Vincent,

On Wed, May 26, 2021 at 12:02:12PM +0200, Vincent Lefevre wrote:
> Control: retitle -1 Apple keyboard: Scan code event (EV_MSC) not generated when the EV_KEY event is generated by hid-apple.c
> Control: tags -1 patch
> 
> On 2021-05-26 10:39:11 +0200, Vincent Lefevre wrote:
> > And the cursor keys. Actually, all the keys corresponding to
> > 
> > static const struct applespi_key_translation applespi_fn_codes[] = {
> >         { KEY_BACKSPACE, KEY_DELETE },
> >         { KEY_ENTER,    KEY_INSERT },
> >         { KEY_F1,       KEY_BRIGHTNESSDOWN,     APPLE_FLAG_FKEY },
> >         { KEY_F2,       KEY_BRIGHTNESSUP,       APPLE_FLAG_FKEY },
> >         { KEY_F3,       KEY_SCALE,              APPLE_FLAG_FKEY },
> >         { KEY_F4,       KEY_DASHBOARD,          APPLE_FLAG_FKEY },
> >         { KEY_F5,       KEY_KBDILLUMDOWN,       APPLE_FLAG_FKEY },
> >         { KEY_F6,       KEY_KBDILLUMUP,         APPLE_FLAG_FKEY },
> >         { KEY_F7,       KEY_PREVIOUSSONG,       APPLE_FLAG_FKEY },
> >         { KEY_F8,       KEY_PLAYPAUSE,          APPLE_FLAG_FKEY },
> >         { KEY_F9,       KEY_NEXTSONG,           APPLE_FLAG_FKEY },
> >         { KEY_F10,      KEY_MUTE,               APPLE_FLAG_FKEY },
> >         { KEY_F11,      KEY_VOLUMEDOWN,         APPLE_FLAG_FKEY },
> >         { KEY_F12,      KEY_VOLUMEUP,           APPLE_FLAG_FKEY },
> >         { KEY_RIGHT,    KEY_END },
> >         { KEY_LEFT,     KEY_HOME },
> >         { KEY_DOWN,     KEY_PAGEDOWN },
> >         { KEY_UP,       KEY_PAGEUP },
> >         { }
> > };
> > 
> > in drivers/input/keyboard/applespi.c.
> > 
> > Just in case, in /etc/modprobe.d/hid_apple.conf, I have
> > 
> > options hid_apple fnmode=2
> > options hid_apple iso_layout=0
> 
> But since I'm using hid_apple, I should have taken
> drivers/hid/hid-apple.c, which has the same kind of code:
> 
> static const struct apple_key_translation apple_fn_keys[] = {
>         { KEY_BACKSPACE, KEY_DELETE },
>         { KEY_ENTER,    KEY_INSERT },
>         { KEY_F1,       KEY_BRIGHTNESSDOWN, APPLE_FLAG_FKEY },
>         { KEY_F2,       KEY_BRIGHTNESSUP,   APPLE_FLAG_FKEY },
>         { KEY_F3,       KEY_SCALE,          APPLE_FLAG_FKEY },
>         { KEY_F4,       KEY_DASHBOARD,      APPLE_FLAG_FKEY },
>         { KEY_F5,       KEY_KBDILLUMDOWN,   APPLE_FLAG_FKEY },
>         { KEY_F6,       KEY_KBDILLUMUP,     APPLE_FLAG_FKEY },
>         { KEY_F7,       KEY_PREVIOUSSONG,   APPLE_FLAG_FKEY },
>         { KEY_F8,       KEY_PLAYPAUSE,      APPLE_FLAG_FKEY },
>         { KEY_F9,       KEY_NEXTSONG,       APPLE_FLAG_FKEY },
>         { KEY_F10,      KEY_MUTE,           APPLE_FLAG_FKEY },
>         { KEY_F11,      KEY_VOLUMEDOWN,     APPLE_FLAG_FKEY },
>         { KEY_F12,      KEY_VOLUMEUP,       APPLE_FLAG_FKEY },
>         { KEY_UP,       KEY_PAGEUP },
>         { KEY_DOWN,     KEY_PAGEDOWN },
>         { KEY_LEFT,     KEY_HOME },
>         { KEY_RIGHT,    KEY_END },
>         { }
> };
> 
> In the conditions from hidinput_apple_event(), the only ones that
> should match according to my settings are
> 
>         if (usage->code == fn_keycode) {
> 
> and
> 
>         if (fnmode) {
> 
> and these are the keys (when trans is true, for fnmode) for which I do
> not get a scan code event. Said otherwise, if hidinput_apple_event()
> returns 1, I do not get a scan code event. There are input_event()
> calls, but I suppose that they will just generate an EV_KEY event,
> and EV_MSC is the one that is missing.
> 
> Note: in hid-apple.c, apple_event() calls hidinput_apple_event(), and
> one has
> 
> static struct hid_driver apple_driver = {
> [...]
>         .event = apple_event,
> [...]
> };
> module_hid_driver(apple_driver);
> 
> I forgot that there was
> 
>   https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=757356#35
> 
> from Daniel Lin, with a patch, in 2017. I've looked at this patch
> (but have not tried it), and it adds an additional EV_MSC event
> when hidinput_apple_event() has to generate an EV_KEY event. So
> I confirm that should solve this issue and I'm adding the patch
> tag (I don't know whether the patch needs an update, though).

Can you, time permitting, starting from there (and needed refreshes)
try to confirm if the patch solves the issue on top of 5.10.40? If so,
next step would be to propose the change/report the bug at least, to
upstream, get_maintainers.pl would suggest to report it to:

Jiri Kosina <jikos@kernel.org> (maintainer:HID CORE LAYER)
Benjamin Tissoires <benjamin.tissoires@redhat.com> (maintainer:HID CORE LAYER)
linux-input@vger.kernel.org (open list:HID CORE LAYER)
linux-kernel@vger.kernel.org (open list)

Regards,
Salvatore

[toc] | [prev] | [next] | [standalone]

#72393 — Bug#757356: Apple keyboard: Scan code event (EV_MSC) not generated when the EV_KEY event is generated by hid-apple.c

FromVincent Lefevre <vincent@vinc17.net>
Date2021-07-19 17:00 +0200
SubjectBug#757356: Apple keyboard: Scan code event (EV_MSC) not generated when the EV_KEY event is generated by hid-apple.c
Message-ID<CCCUp-4Bs-1@gated-at.bofh.it>
In reply to#72070

[Multipart message — attachments visible in raw view] — view raw

On 2021-06-02 17:24:38 +0200, Salvatore Bonaccorso wrote:
> Can you, time permitting, starting from there (and needed refreshes)
> try to confirm if the patch solves the issue on top of 5.10.40?

First, the patch did not apply correctly on top of 5.10.46 (currently
in unstable). So I've updated it and attached this new version. (I'm not
sure that the change concerning REL_HWHEEL is needed, but in any case,
it may be safer and it shouldn't hurt, thanks to the "type == EV_KEY"
test.)

Then I couldn't test it because the kernel build fails:

[...]
  CC      fs/locks.o
  CC      fs/binfmt_script.o
  CC      fs/binfmt_elf.o
  CC      fs/compat_binfmt_elf.o
  CC      fs/posix_acl.o
  CC      fs/coredump.o
  CC      fs/drop_caches.o
  CC      fs/fhandle.o
  CC      fs/dcookies.o
  CC [M]  fs/binfmt_misc.o
  CC [M]  fs/mbcache.o
  AR      fs/built-in.a
make[2]: *** [debian/rules:7: build-arch] Error 2
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
make[1]: *** [scripts/Makefile.package:77: deb-pkg] Error 2
make: *** [Makefile:1573: deb-pkg] Error 2

I don't know whether this matters, but the /usr/src/linux-source-5.10.tar.xz
archive is not extracted properly by tar, with directories having
incorrect timestamps. I've reported a bug for this:

  https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=991275

-- 
Vincent Lefèvre <vincent@vinc17.net> - Web: <https://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

[toc] | [prev] | [next] | [standalone]

#72420 — Bug#757356: Apple keyboard: Scan code event (EV_MSC) not generated when the EV_KEY event is generated by hid-apple.c

FromVincent Lefevre <vincent@vinc17.net>
Date2021-07-21 16:30 +0200
SubjectBug#757356: Apple keyboard: Scan code event (EV_MSC) not generated when the EV_KEY event is generated by hid-apple.c
Message-ID<CDlot-6yU-1@gated-at.bofh.it>
In reply to#72070
On 2021-06-02 17:24:38 +0200, Salvatore Bonaccorso wrote:
> Hi Vincent,
> 
> On Wed, May 26, 2021 at 12:02:12PM +0200, Vincent Lefevre wrote:
[...]
> > I forgot that there was
> > 
> >   https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=757356#35
> > 
> > from Daniel Lin, with a patch, in 2017. I've looked at this patch
> > (but have not tried it), and it adds an additional EV_MSC event
> > when hidinput_apple_event() has to generate an EV_KEY event. So
> > I confirm that should solve this issue and I'm adding the patch
> > tag (I don't know whether the patch needs an update, though).
> 
> Can you, time permitting, starting from there (and needed refreshes)
> try to confirm if the patch solves the issue on top of 5.10.40?

I could build and test the patched kernel, and I confirm that the
new patch at

  https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=757356#75

solves the issue for me.

> If so, next step would be to propose the change/report the bug at
> least, to upstream, get_maintainers.pl would suggest to report it
> to:
> 
> Jiri Kosina <jikos@kernel.org> (maintainer:HID CORE LAYER)
> Benjamin Tissoires <benjamin.tissoires@redhat.com> (maintainer:HID CORE LAYER)
> linux-input@vger.kernel.org (open list:HID CORE LAYER)
> linux-kernel@vger.kernel.org (open list)

Since Daniel Lin (Cc'ed for any comment) is the author of the
original patch, I suppose that the patch should have:

Co-developed-by: Daniel Lin <ephemient@gmail.com>
Signed-off-by: Daniel Lin <ephemient@gmail.com>
Co-developed-by: Vincent Lefevre <vincent@vinc17.net>
Signed-off-by: Vincent Lefevre <vincent@vinc17.net>

as described at
  https://www.kernel.org/doc/html/latest/process/submitting-patches.html

if this is OK for him.

-- 
Vincent Lefèvre <vincent@vinc17.net> - Web: <https://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

[toc] | [prev] | [next] | [standalone]

#72424 — Bug#757356: Apple keyboard: Scan code event (EV_MSC) not generated when the EV_KEY event is generated by hid-apple.c

FromDaniel Lin <ephemient@gmail.com>
Date2021-07-22 00:40 +0200
SubjectBug#757356: Apple keyboard: Scan code event (EV_MSC) not generated when the EV_KEY event is generated by hid-apple.c
Message-ID<CDt2F-2Nm-1@gated-at.bofh.it>
In reply to#72420

[Multipart message — attachments visible in raw view] — view raw

Yes, I haven't used a machine with hid_apple in many years, but the patch
sign-off is OK with me.

On Wed, Jul 21, 2021 at 10:24 AM Vincent Lefevre <vincent@vinc17.net> wrote:

> On 2021-06-02 17:24:38 +0200, Salvatore Bonaccorso wrote:
> > Hi Vincent,
> >
> > On Wed, May 26, 2021 at 12:02:12PM +0200, Vincent Lefevre wrote:
> [...]
> > > I forgot that there was
> > >
> > >   https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=757356#35
> > >
> > > from Daniel Lin, with a patch, in 2017. I've looked at this patch
> > > (but have not tried it), and it adds an additional EV_MSC event
> > > when hidinput_apple_event() has to generate an EV_KEY event. So
> > > I confirm that should solve this issue and I'm adding the patch
> > > tag (I don't know whether the patch needs an update, though).
> >
> > Can you, time permitting, starting from there (and needed refreshes)
> > try to confirm if the patch solves the issue on top of 5.10.40?
>
> I could build and test the patched kernel, and I confirm that the
> new patch at
>
>   https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=757356#75
>
> solves the issue for me.
>
> > If so, next step would be to propose the change/report the bug at
> > least, to upstream, get_maintainers.pl would suggest to report it
> > to:
> >
> > Jiri Kosina <jikos@kernel.org> (maintainer:HID CORE LAYER)
> > Benjamin Tissoires <benjamin.tissoires@redhat.com> (maintainer:HID CORE
> LAYER)
> > linux-input@vger.kernel.org (open list:HID CORE LAYER)
> > linux-kernel@vger.kernel.org (open list)
>
> Since Daniel Lin (Cc'ed for any comment) is the author of the
> original patch, I suppose that the patch should have:
>
> Co-developed-by: Daniel Lin <ephemient@gmail.com>
> Signed-off-by: Daniel Lin <ephemient@gmail.com>
> Co-developed-by: Vincent Lefevre <vincent@vinc17.net>
> Signed-off-by: Vincent Lefevre <vincent@vinc17.net>
>
> as described at
>   https://www.kernel.org/doc/html/latest/process/submitting-patches.html
>
> if this is OK for him.
>
> --
> Vincent Lefèvre <vincent@vinc17.net> - Web: <https://www.vinc17.net/>
> 100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
> Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)
>

[toc] | [prev] | [next] | [standalone]

#72479 — Bug#757356: Apple keyboard: Scan code event (EV_MSC) not generated when the EV_KEY event is generated by hid-apple.c

FromVincent Lefevre <vincent@vinc17.net>
Date2021-07-26 16:20 +0200
SubjectBug#757356: Apple keyboard: Scan code event (EV_MSC) not generated when the EV_KEY event is generated by hid-apple.c
Message-ID<CF9Cy-87Y-1@gated-at.bofh.it>
In reply to#72424
On 2021-07-21 18:28:44 -0400, Daniel Lin wrote:
> Yes, I haven't used a machine with hid_apple in many years, but the
> patch sign-off is OK with me.

Thanks. For the reference of my patch submission a few days ago:

  https://www.spinics.net/lists/linux-input/msg74111.html

  https://lore.kernel.org/patchwork/project/lkml/list/?series=509091

-- 
Vincent Lefèvre <vincent@vinc17.net> - Web: <https://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.kernel

csiph-web