Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.kernel > #67539 > unrolled thread

Bug#965074: cdc_ncm: ethernet multicast traffic is filtered out

Back to article view | Back to linux.debian.kernel

Contents

  Bug#965074: cdc_ncm: ethernet multicast traffic is filtered out wxcafe <wxcafe@wxcafe.net> - 2020-07-15 19:00 +0200
    Bug#965074: cdc_ncm: ethernet multicast traffic is filtered out Wxcafé <wxcafe@wxcafe.net> - 2020-07-15 19:10 +0200
    Bug#965074: cdc_ncm: ethernet multicast traffic is filtered out Bjørn Mork <bjorn@mork.no> - 2020-07-15 20:50 +0200
      Bug#965074: cdc_ncm: ethernet multicast traffic is filtered out Wxcafé <wxcafe@wxcafe.net> - 2020-07-16 00:50 +0200
    Bug#965074: Patches to make multicast proccesing on CDC NCM drivers Greg KH <gregkh@linuxfoundation.org> - 2020-09-02 14:10 +0200
      Bug#965074: Patches to make multicast proccesing on CDC NCM drivers Santiago Ruano Rincón <santiago.ruano-rincon@imt-atlantique.fr> - 2020-09-02 15:40 +0200
        Bug#965074: Patches to make multicast proccesing on CDC NCM drivers Greg KH <gregkh@linuxfoundation.org> - 2020-09-02 17:50 +0200
          Bug#965074: Patches to make multicast proccesing on CDC NCM drivers Santiago Ruano Rincón <santiago.ruano-rincon@imt-atlantique.fr> - 2020-09-03 10:00 +0200
    Bug#965074: Patches to make multicast proccesing on CDC NCM drivers Santiago Ruano Rincón <santiago.ruano-rincon@imt-atlantique.fr> - 2020-09-02 14:10 +0200
    Bug#965074: Patches to make multicast proccesing on CDC NCM drivers Bjørn Mork <bjorn@mork.no> - 2020-09-03 19:30 +0200
    Bug#965074: marked as done (cdc_ncm: ethernet multicast traffic  is filtered out) "Debian Bug Tracking System" <owner@bugs.debian.org> - 2020-10-22 13:50 +0200

#67539 — Bug#965074: cdc_ncm: ethernet multicast traffic is filtered out

Package: linux-image-amd64
Version: 4.19+105+deb10u4
Severity: important
Tags: ipv6

Hey,

linux's cdc_ncm driver has a bug with multicast ethernet traffic, which breaks
mDNS and ipv6, among other things. Miguel Rodríguez Pérez (miguel@det.uvigo.gal)
wrote patches fixing that two years ago, but they never got merged even though
as far as I can tell he fixed all the problems mentionned.
(https://patchwork.kernel.org/project/linux-usb/list/?submitter=181339&state=%2A&archive=both)

I tried rebasing them on current mainline (5.7.8/5.8.0-rc5) and submit them but
have been met with a lot of trouble with my formatting, and also don't want to
use my real name (see https://marc.info/?l=linux-netdev&m=159467301013480&w=2 https://marc.info/?t=159477625000002&r=1&w=2 https://marc.info/?t=159477644000003&r=1&w=2 https://marc.info/?t=159477680800001&r=1&w=2 https://marc.info/?t=159477644200002&r=1&w=2 https://marc.info/?t=159477662400001&r=1&w=2 etc)

As far as I know nothing should pose any problem with merging these, all the
objections mentionned in the thread are resolved (as far as I can tell, I'm not
a kernel dev), they build correctly on mainline, and work well.

Cheers.

-- System Information:
Debian Release: 10.4
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 5.5.0-0.bpo.2-amd64 (SMP w/4 CPU cores)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_US.UTF-8), LANGUAGE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_US.UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages linux-image-amd64 depends on:
ii  linux-image-4.19.0-9-amd64  4.19.118-2

linux-image-amd64 recommends no packages.

linux-image-amd64 suggests no packages.

-- no debconf information

[toc] | [next] | [standalone]

#67540

BTW, I reported this on one of my servers running 5.5.0 (installed
manually) but it affects every version up to 5.8.0-rc5, which is why I
reported to the meta-package linux-image-amd64.


-- 
Wxcafé <wxcafe@wxcafe.net>

On Wed, 2020-07-15 at 16:41 +0000, wxcafe wrote:
> Package: linux-image-amd64
> Version: 4.19+105+deb10u4
> Severity: important
> Tags: ipv6
> 
> Hey,
> 
> linux's cdc_ncm driver has a bug with multicast ethernet traffic,
> which breaks
> mDNS and ipv6, among other things. Miguel Rodríguez Pérez (
> miguel@det.uvigo.gal)
> wrote patches fixing that two years ago, but they never got merged
> even though
> as far as I can tell he fixed all the problems mentionned.
> (
> https://patchwork.kernel.org/project/linux-usb/list/?submitter=181339&state=%2A&archive=both
> )
> 
> I tried rebasing them on current mainline (5.7.8/5.8.0-rc5) and
> submit them but
> have been met with a lot of trouble with my formatting, and also
> don't want to
> use my real name (see 
> https://marc.info/?l=linux-netdev&m=159467301013480&w=2 
> https://marc.info/?t=159477625000002&r=1&w=2 
> https://marc.info/?t=159477644000003&r=1&w=2 
> https://marc.info/?t=159477680800001&r=1&w=2 
> https://marc.info/?t=159477644200002&r=1&w=2 
> https://marc.info/?t=159477662400001&r=1&w=2 etc)
> 
> As far as I know nothing should pose any problem with merging these,
> all the
> objections mentionned in the thread are resolved (as far as I can
> tell, I'm not
> a kernel dev), they build correctly on mainline, and work well.
> 
> Cheers.
> 
> -- System Information:
> Debian Release: 10.4
>   APT prefers stable
>   APT policy: (500, 'stable')
> Architecture: amd64 (x86_64)
> 
> Kernel: Linux 5.5.0-0.bpo.2-amd64 (SMP w/4 CPU cores)
> Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE,
> TAINT_UNSIGNED_MODULE
> Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
> (ignored: LC_ALL set to en_US.UTF-8), LANGUAGE=en_US.UTF-8
> (charmap=UTF-8) (ignored: LC_ALL set to en_US.UTF-8)
> Shell: /bin/sh linked to /usr/bin/dash
> Init: systemd (via /run/systemd/system)
> 
> Versions of packages linux-image-amd64 depends on:
> ii  linux-image-4.19.0-9-amd64  4.19.118-2
> 
> linux-image-amd64 recommends no packages.
> 
> linux-image-amd64 suggests no packages.
> 
> -- no debconf information

[toc] | [prev] | [next] | [standalone]

#67541

FWIW, I made an attempt resubmitting these patches since it looked like
I was part of the problem back in 2018 ;-)

I'd CCed you, and would appreciate it if you could test the series.  I
don't have any cdc_ncm devices with multicast filter support AFAIK.


Bjørn

[toc] | [prev] | [next] | [standalone]

#67543

Hey! Thank you so much for the resubmission

I just tested the patches on 5.7.8 and it works perfectly!

Cheers

-- 
Wxcafé <wxcafe@wxcafe.net>

On Wed, 2020-07-15 at 20:44 +0200, Bjørn Mork wrote:
> FWIW, I made an attempt resubmitting these patches since it looked
> like
> I was part of the problem back in 2018 ;-)
> 
> I'd CCed you, and would appreciate it if you could test the
> series.  I
> don't have any cdc_ncm devices with multicast filter support AFAIK.
> 
> 
> Bjørn

[toc] | [prev] | [next] | [standalone]

#67962 — Bug#965074: Patches to make multicast proccesing on CDC NCM drivers

On Wed, Sep 02, 2020 at 01:47:18PM +0200, Santiago Ruano Rincón wrote:
> El 30/07/20 a las 16:07, Oliver Neukum escribió:
> > Am Donnerstag, den 30.07.2020, 15:53 +0200 schrieb Santiago Ruano
> > Rincón:
> > > Hi,
> > > 
> > > Miguel Rodríguez sent this set of patches two years ago to fix the lack
> > > of multicast processing on CDC NCM driver:
> > > 
> > > https://www.spinics.net/lists/linux-usb/msg170611.html
> > > https://www.spinics.net/lists/linux-usb/msg170603.html
> > > https://www.spinics.net/lists/linux-usb/msg170567.html
> > > https://www.spinics.net/lists/linux-usb/msg170568.html
> > > 
> > > I've using a DKMS version of them, available in
> > > https://github.com/stbuehler/fixed-cdc-ether-ncm/tree/wip/patches
> > > since more than a year ago, and they are working fine with my Dell D6000
> > > docking station. IPv6 connectivity is broken without them.
> > > 
> > > Is there any chance to consider those patches (or what would be needed
> > > to make it happen)?
> > > It would be great to have them upstream!
> > 
> > Hi,
> > 
> > they have been merged on Wednesday.
> …
> 
> Great, thanks!
> 
> It would be possible to apply/backport Miguel's patches (along with
> 5fd99b5d9950d6300467ded18ff4e44af0b4ae55) to stable versions please?

I don't see that git commit id in Linus's tree, are you sure it is
correct?

> FWIW, in the context of Debian, I'm personally interested in 4.19.y.

What specific list of commits are you wanting to see backported?

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#67966 — Bug#965074: Patches to make multicast proccesing on CDC NCM drivers

[Multipart message — attachments visible in raw view] — view raw

El 02/09/20 a las 14:05, Greg KH escribió:
> On Wed, Sep 02, 2020 at 01:47:18PM +0200, Santiago Ruano Rincón wrote:
> > El 30/07/20 a las 16:07, Oliver Neukum escribió:
> > > Am Donnerstag, den 30.07.2020, 15:53 +0200 schrieb Santiago Ruano
> > > Rincón:
> > > > Hi,
> > > > 
> > > > Miguel Rodríguez sent this set of patches two years ago to fix the lack
> > > > of multicast processing on CDC NCM driver:
> > > > 
> > > > https://www.spinics.net/lists/linux-usb/msg170611.html
> > > > https://www.spinics.net/lists/linux-usb/msg170603.html
> > > > https://www.spinics.net/lists/linux-usb/msg170567.html
> > > > https://www.spinics.net/lists/linux-usb/msg170568.html
> > > > 
> > > > I've using a DKMS version of them, available in
> > > > https://github.com/stbuehler/fixed-cdc-ether-ncm/tree/wip/patches
> > > > since more than a year ago, and they are working fine with my Dell D6000
> > > > docking station. IPv6 connectivity is broken without them.
> > > > 
> > > > Is there any chance to consider those patches (or what would be needed
> > > > to make it happen)?
> > > > It would be great to have them upstream!
> > > 
> > > Hi,
> > > 
> > > they have been merged on Wednesday.
> > …
> > 
> > Great, thanks!
> > 
> > It would be possible to apply/backport Miguel's patches (along with
> > 5fd99b5d9950d6300467ded18ff4e44af0b4ae55) to stable versions please?
> 
> I don't see that git commit id in Linus's tree, are you sure it is
> correct?

I should had mention it is found in linux-next, sorry. Please see
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=969365#10

> > FWIW, in the context of Debian, I'm personally interested in 4.19.y.
> 
> What specific list of commits are you wanting to see backported?

This:

37a2ebdd9e597ae1a0270ac747883ea8f6f767b6
e10dcb1b6ba714243ad5a35a11b91cc14103a9a9
e506addeff844237d60545ef4f6141de21471caf
0226009ce0f6089f9b31211f7a2703cf9a327a01

Thanks,

 -- santiago

[toc] | [prev] | [next] | [standalone]

#67967 — Bug#965074: Patches to make multicast proccesing on CDC NCM drivers

On Wed, Sep 02, 2020 at 03:27:28PM +0200, Santiago Ruano Rincón wrote:
> El 02/09/20 a las 14:05, Greg KH escribió:
> > On Wed, Sep 02, 2020 at 01:47:18PM +0200, Santiago Ruano Rincón wrote:
> > > El 30/07/20 a las 16:07, Oliver Neukum escribió:
> > > > Am Donnerstag, den 30.07.2020, 15:53 +0200 schrieb Santiago Ruano
> > > > Rincón:
> > > > > Hi,
> > > > > 
> > > > > Miguel Rodríguez sent this set of patches two years ago to fix the lack
> > > > > of multicast processing on CDC NCM driver:
> > > > > 
> > > > > https://www.spinics.net/lists/linux-usb/msg170611.html
> > > > > https://www.spinics.net/lists/linux-usb/msg170603.html
> > > > > https://www.spinics.net/lists/linux-usb/msg170567.html
> > > > > https://www.spinics.net/lists/linux-usb/msg170568.html
> > > > > 
> > > > > I've using a DKMS version of them, available in
> > > > > https://github.com/stbuehler/fixed-cdc-ether-ncm/tree/wip/patches
> > > > > since more than a year ago, and they are working fine with my Dell D6000
> > > > > docking station. IPv6 connectivity is broken without them.
> > > > > 
> > > > > Is there any chance to consider those patches (or what would be needed
> > > > > to make it happen)?
> > > > > It would be great to have them upstream!
> > > > 
> > > > Hi,
> > > > 
> > > > they have been merged on Wednesday.
> > > …
> > > 
> > > Great, thanks!
> > > 
> > > It would be possible to apply/backport Miguel's patches (along with
> > > 5fd99b5d9950d6300467ded18ff4e44af0b4ae55) to stable versions please?
> > 
> > I don't see that git commit id in Linus's tree, are you sure it is
> > correct?
> 
> I should had mention it is found in linux-next, sorry. Please see
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=969365#10

Ah, nothing I can do with patches that are not yet in Linus's tree.

> > > FWIW, in the context of Debian, I'm personally interested in 4.19.y.
> > 
> > What specific list of commits are you wanting to see backported?
> 
> This:
> 
> 37a2ebdd9e597ae1a0270ac747883ea8f6f767b6
> e10dcb1b6ba714243ad5a35a11b91cc14103a9a9
> e506addeff844237d60545ef4f6141de21471caf
> 0226009ce0f6089f9b31211f7a2703cf9a327a01

These do not look like bugfixes, but a new feature being added for this
driver.  So why not just use a newer kernel version for this feature?

thanks,

greg k-h

[toc] | [prev] | [next] | [standalone]

#67975 — Bug#965074: Patches to make multicast proccesing on CDC NCM drivers

[Multipart message — attachments visible in raw view] — view raw

El 02/09/20 a las 17:45, Greg KH escribió:
> On Wed, Sep 02, 2020 at 03:27:28PM +0200, Santiago Ruano Rincón wrote:
> > El 02/09/20 a las 14:05, Greg KH escribió:
> > > On Wed, Sep 02, 2020 at 01:47:18PM +0200, Santiago Ruano Rincón wrote:
> > > > El 30/07/20 a las 16:07, Oliver Neukum escribió:
> > > > > Am Donnerstag, den 30.07.2020, 15:53 +0200 schrieb Santiago Ruano
> > > > > Rincón:
…
> > > > 
> > > > It would be possible to apply/backport Miguel's patches (along with
> > > > 5fd99b5d9950d6300467ded18ff4e44af0b4ae55) to stable versions please?
> > > 
> > > I don't see that git commit id in Linus's tree, are you sure it is
> > > correct?
> > 
> > I should had mention it is found in linux-next, sorry. Please see
> > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=969365#10
> 
> Ah, nothing I can do with patches that are not yet in Linus's tree.
> 

ACK.

> > > > FWIW, in the context of Debian, I'm personally interested in 4.19.y.
> > > 
> > > What specific list of commits are you wanting to see backported?
> > 
> > This:
> > 
> > 37a2ebdd9e597ae1a0270ac747883ea8f6f767b6
> > e10dcb1b6ba714243ad5a35a11b91cc14103a9a9
> > e506addeff844237d60545ef4f6141de21471caf
> > 0226009ce0f6089f9b31211f7a2703cf9a327a01
> 
> These do not look like bugfixes, but a new feature being added for this
> driver.  So why not just use a newer kernel version for this feature?

From my point of view as user these are bugfixes, since IPv6 NDP or any
other protocol relying on multicast do not work without them. In other
words, my computer's networking is broken.

I want to have them in linux stable releases because that would make
easier to include them in Debian stable release.

Thanks!

 -- Santiago

[toc] | [prev] | [next] | [standalone]

#67963 — Bug#965074: Patches to make multicast proccesing on CDC NCM drivers

[Multipart message — attachments visible in raw view] — view raw

El 30/07/20 a las 16:07, Oliver Neukum escribió:
> Am Donnerstag, den 30.07.2020, 15:53 +0200 schrieb Santiago Ruano
> Rincón:
> > Hi,
> > 
> > Miguel Rodríguez sent this set of patches two years ago to fix the lack
> > of multicast processing on CDC NCM driver:
> > 
> > https://www.spinics.net/lists/linux-usb/msg170611.html
> > https://www.spinics.net/lists/linux-usb/msg170603.html
> > https://www.spinics.net/lists/linux-usb/msg170567.html
> > https://www.spinics.net/lists/linux-usb/msg170568.html
> > 
> > I've using a DKMS version of them, available in
> > https://github.com/stbuehler/fixed-cdc-ether-ncm/tree/wip/patches
> > since more than a year ago, and they are working fine with my Dell D6000
> > docking station. IPv6 connectivity is broken without them.
> > 
> > Is there any chance to consider those patches (or what would be needed
> > to make it happen)?
> > It would be great to have them upstream!
> 
> Hi,
> 
> they have been merged on Wednesday.
…

Great, thanks!

It would be possible to apply/backport Miguel's patches (along with
5fd99b5d9950d6300467ded18ff4e44af0b4ae55) to stable versions please?

FWIW, in the context of Debian, I'm personally interested in 4.19.y.

Best regards,

 -- Santiago

[toc] | [prev] | [next] | [standalone]

#67980 — Bug#965074: Patches to make multicast proccesing on CDC NCM drivers

Santiago Ruano Rincón <santiago.ruano-rincon@imt-atlantique.fr> writes:
> El 02/09/20 a las 17:45, Greg KH escribió:
>> On Wed, Sep 02, 2020 at 03:27:28PM +0200, Santiago Ruano Rincón wrote:
>>
>> > This:
>> > 
>> > 37a2ebdd9e597ae1a0270ac747883ea8f6f767b6
>> > e10dcb1b6ba714243ad5a35a11b91cc14103a9a9
>> > e506addeff844237d60545ef4f6141de21471caf
>> > 0226009ce0f6089f9b31211f7a2703cf9a327a01
>> 
>> These do not look like bugfixes, but a new feature being added for this
>> driver.  So why not just use a newer kernel version for this feature?
>
> From my point of view as user these are bugfixes, since IPv6 NDP or any
> other protocol relying on multicast do not work without them. In other
> words, my computer's networking is broken.

I was in doubt when I submitted these, but ended up specfying net-next
instead of net+stable as the target for a reason.  This is a new feature
as Greg says. Even if the feature is essential for your use case, it is
still new. "Has never been supported" isn't really a bug.

And I am still convinced that my decision was correct.  The patches are
a bit more intrusive than I'd be comfortable submitting to stable, as
was demonstrated by the stupid build bug I added... Fixed by commit
5fd99b5d9950 ("net: cdc_ncm: Fix build error") BTW.

> I want to have them in linux stable releases because that would make
> easier to include them in Debian stable release.

This has not been an absolute requirement in the past. Distros tend to
have a more relaxed stable policy.

Using a newer kernel until Debian moves on is obviously also an option.



Bjørn

[toc] | [prev] | [next] | [standalone]

#68415 — Bug#965074: marked as done (cdc_ncm: ethernet multicast traffic is filtered out)

[Multipart message — attachments visible in raw view] — view raw

Your message dated Thu, 22 Oct 2020 13:45:32 +0200
with message-id <20201022114532.GA1667806@jcristau-z4>
and subject line Re: Bug#965074: cdc_ncm: ethernet multicast traffic is filtered out
has caused the Debian Bug report #965074,
regarding cdc_ncm: ethernet multicast traffic is filtered out
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
965074: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=965074
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.kernel

csiph-web