Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.debian.kernel > #66991 > unrolled thread
| Started by | John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> |
|---|---|
| First post | 2020-05-05 07:10 +0200 |
| Last post | 2020-09-11 22:40 +0200 |
| Articles | 5 — 4 participants |
Back to article view | Back to linux.debian.kernel
Bug#959768: initramfs-tools: Does not account for different so versions of libgcc_s John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> - 2020-05-05 07:10 +0200
Processed: Re: Bug#959768: initramfs-tools: Does not account for different so versions of libgcc_s "Debian Bug Tracking System" <owner@bugs.debian.org> - 2020-05-14 08:30 +0200
Bug#959768: [PATCH] initramfs-tools/hook-functions: Fix libgcc_s.so.1 dependency Helge Deller <deller@gmx.de> - 2020-05-28 00:20 +0200
Bug#959768: [PATCH] initramfs-tools/hook-functions: Fix libgcc_s.so.1 dependency Ben Hutchings <ben@decadent.org.uk> - 2020-06-11 15:00 +0200
Bug#959768: marked as done (initramfs-tools: Does not account for different so versions of libgcc_s) "Debian Bug Tracking System" <owner@bugs.debian.org> - 2020-09-11 22:40 +0200
| From | John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de> |
|---|---|
| Date | 2020-05-05 07:10 +0200 |
| Subject | Bug#959768: initramfs-tools: Does not account for different so versions of libgcc_s |
| Message-ID | <A2Y09-4e1-1@gated-at.bofh.it> |
Source: initramfs-tools Severity: important User: debian-hppa@lists.debian.org Usertags: hppa,m68k Hello! In #950254 [1], a change was introduced to copy libgcc_s.so.1 into the initrd. Unfortunately, this change has introduced a regression on some architectures as the shared library has a different so version on these targets. amd64: root@z6:~> ls -l /lib/x86_64-linux-gnu/libgcc* -rw-r--r-- 1 root root 100736 May 2 14:09 /lib/x86_64-linux-gnu/libgcc_s.so.1 root@z6:~> hppa: root@phantom:~# ls -l /lib/hppa-linux-gnu/libgcc* -rw-r--r-- 1 root root 84412 Apr 18 09:56 /lib/hppa-linux-gnu/libgcc_s.so.4 root@phantom:~# m68k: root@elgar:~> ls -l /lib/m68k-linux-gnu/libgcc* -rw-r--r-- 1 root root 59116 Apr 18 11:56 /lib/m68k-linux-gnu/libgcc_s.so.2 root@elgar:~> Can you fix the change from #950254 to account for the different so versions of that library? Thanks, Adrian > [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=950254 -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaubitz@debian.org `. `' Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
[toc] | [next] | [standalone]
| From | "Debian Bug Tracking System" <owner@bugs.debian.org> |
|---|---|
| Date | 2020-05-14 08:30 +0200 |
| Subject | Processed: Re: Bug#959768: initramfs-tools: Does not account for different so versions of libgcc_s |
| Message-ID | <A6fxw-Uw-9@gated-at.bofh.it> |
| In reply to | #66991 |
Processing control commands: > severity -1 important Bug #959768 [src:initramfs-tools] initramfs-tools: Does not account for different so versions of libgcc_s Ignoring request to change severity of Bug 959768 to the same value. -- 959768: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=959768 Debian Bug Tracking System Contact owner@bugs.debian.org with problems
[toc] | [prev] | [next] | [standalone]
| From | Helge Deller <deller@gmx.de> |
|---|---|
| Date | 2020-05-28 00:20 +0200 |
| Subject | Bug#959768: [PATCH] initramfs-tools/hook-functions: Fix libgcc_s.so.1 dependency |
| Message-ID | <AbcyZ-4l1-1@gated-at.bofh.it> |
| In reply to | #66991 |
Due to Debian bug #950254 the hook-functions copies libgcc_s.so.1 into
the initramfs image. But this breaks architectures which ship other
versions of libgcc_s, e.g. hppa (libgcc_s.so.4) or m68k (libgcc_s.so.2).
Fix it by searching the relevant libgcc_so files.
The fix is modelled after the btrfs hook functions in
/usr/share/initramfs-tools/hooks/btrfs.
Tested on hppa.
Signed-off-by: Helge Deller <deller@gmx.de>
Noticed-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=959768
Fixes: f2ac13e8881f ("hook-functions: copy_exec: Copy libgcc_s.so.0 along with libpthread.so")
diff -up ./hook-functions.org ./hook-functions
--- ./hook-functions.org 2020-05-27 21:57:26.994595173 +0000
+++ ./hook-functions 2020-05-27 21:57:30.182574623 +0000
@@ -182,7 +182,7 @@ copy_file() {
# Location of the image dir is assumed to be $DESTDIR
# We never overwrite the target if it exists.
copy_exec() {
- local src target x nonoptlib ret
+ local src target x nonoptlib ret libgcc
src="${1}"
target="${2:-$1}"
@@ -209,7 +209,10 @@ copy_exec() {
# Handle common dlopen() dependency (Debian bug #950254)
case "${x}" in
*/libpthread.so.*)
- copy_exec "${x%/*}/libgcc_s.so.1" || return
+ LIBC_DIR=$(dirname "${x}")
+ find -L "$LIBC_DIR" -maxdepth 1 -name 'libgcc_s.*' -type f | while read -r libgcc; do
+ copy_exec "${libgcc}" || return
+ done
;;
esac
[toc] | [prev] | [next] | [standalone]
| From | Ben Hutchings <ben@decadent.org.uk> |
|---|---|
| Date | 2020-06-11 15:00 +0200 |
| Subject | Bug#959768: [PATCH] initramfs-tools/hook-functions: Fix libgcc_s.so.1 dependency |
| Message-ID | <AguYh-3SS-9@gated-at.bofh.it> |
| In reply to | #66991 |
[Multipart message — attachments visible in raw view] — view raw
On Thu, 2020-06-11 at 12:16 +0200, John Paul Adrian Glaubitz wrote: > Hi Helge! > > On 5/28/20 12:14 AM, Helge Deller wrote: > > Due to Debian bug #950254 the hook-functions copies libgcc_s.so.1 into > > the initramfs image. But this breaks architectures which ship other > > versions of libgcc_s, e.g. hppa (libgcc_s.so.4) or m68k (libgcc_s.so.2). > > > > Fix it by searching the relevant libgcc_so files. > > The fix is modelled after the btrfs hook functions in > > /usr/share/initramfs-tools/hooks/btrfs. > Could you open a merge request on Salsa so that Ben just needs to merge this > change? I actually implemented a fix for this already but didn't push it. Can you check whether the benh/libgcc_s branch works for you? Ben. -- Ben Hutchings If the facts do not conform to your theory, they must be disposed of.
[toc] | [prev] | [next] | [standalone]
| From | "Debian Bug Tracking System" <owner@bugs.debian.org> |
|---|---|
| Date | 2020-09-11 22:40 +0200 |
| Subject | Bug#959768: marked as done (initramfs-tools: Does not account for different so versions of libgcc_s) |
| Message-ID | <ANXZT-86k-3@gated-at.bofh.it> |
| In reply to | #66991 |
[Multipart message — attachments visible in raw view] — view raw
Your message dated Fri, 11 Sep 2020 20:36:04 +0000 with message-id <E1kGpm8-000IoC-1o@fasolo.debian.org> and subject line Bug#959768: fixed in initramfs-tools 0.138 has caused the Debian Bug report #959768, regarding initramfs-tools: Does not account for different so versions of libgcc_s to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@bugs.debian.org immediately.) -- 959768: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=959768 Debian Bug Tracking System Contact owner@bugs.debian.org with problems
[toc] | [prev] | [standalone]
Back to top | Article view | linux.debian.kernel
csiph-web