Bug#932845: TS-219 RTC issue with Debian Buster

From	Oliver Hartkopp <socketcan@hartkopp.net>
Newsgroups	linux.debian.bugs.dist, linux.debian.kernel
Subject	Bug#932845: TS-219 RTC issue with Debian Buster
Date	2019-07-26 13:00 +0200
Message-ID	<yo678-3LW-13@gated-at.bofh.it> (permalink)
References	(5 earlier) <yo4RH-34Q-1@gated-at.bofh.it> <yo51n-38q-3@gated-at.bofh.it> <yo5NM-3ED-1@gated-at.bofh.it> <yn9JL-ZU-1@gated-at.bofh.it> <yo5NM-3ED-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Cross-posted to 2 groups.

Show all headers | View raw

Just a thought:

There are some of these rtc drivers that set

rtc->rtc->uie_unsupported = 1;

in the case that they can't assign an irq line.

But others set

rtc->rtc->uie_unsupported = 1;

when they don't support an (alarm) trigger with 1 sec accuracy.

Wouldn't it make sense to put

+       select RTC_INTF_DEV
+       select RTC_INTF_DEV_UIE_EMUL

in the Kconfig entries of the latter devices?

Best regards,
Oliver


On 26.07.19 12:26, Oliver Hartkopp wrote:
> Hello Alexandre,
> 
> On 26.07.19 11:39, Alexandre Belloni wrote:
> 
>>>>> Maybe this problem is only relevant for the S35390A and PCF8563 
>>>>> chip which
>>>>> both lack the UIE support needed by hwclock. Both have only alarm 
>>>>> triggers
>>>>> in a minute accuracy according to the driver source code.
>>>>
>>>> AFAIK the rtc framework should then emulate this event somehow.
>>>
>>> I don't think so. When the rtc chip is not able to trigger an event 
>>> with a
>>> one second resolution - how can you emulate that?
>>>
>>
>> CONFIG_RTC_INTF_DEV_UIE_EMUL emulates it by polling the RTC.
>>
> 
> Just booted my NAS box and /boot/config-4.19.0-5-marvell contains
> 
> # CONFIG_RTC_INTF_DEV_UIE_EMUL is not set
> 
> Would be cool when this would make hwclock happy.
> 
> Best regards,
> Oliver

Thread

Bug#932845: TS-219 RTC issue with Debian Buster Oliver Hartkopp <socketcan@hartkopp.net> - 2019-07-23 22:40 +0200
  Bug#932845: TS-219 RTC issue with Debian Buster Uwe Kleine-König <uwe@kleine-koenig.org> - 2019-07-24 09:20 +0200
    Bug#932845: TS-219 RTC issue with Debian Buster Oliver Hartkopp <socketcan@hartkopp.net> - 2019-07-25 16:50 +0200
      Bug#932845: TS-219 RTC issue with Debian Buster Uwe Kleine-König <u.kleine-koenig@pengutronix.de> - 2019-07-26 09:50 +0200
        Bug#932845: TS-219 RTC issue with Debian Buster Oliver Hartkopp <socketcan@hartkopp.net> - 2019-07-26 11:40 +0200
          Bug#932845: TS-219 RTC issue with Debian Buster Alexandre Belloni <alexandre.belloni@bootlin.com> - 2019-07-26 11:50 +0200
            Bug#932845: TS-219 RTC issue with Debian Buster Oliver Hartkopp <socketcan@hartkopp.net> - 2019-07-26 12:40 +0200
              Bug#932845: TS-219 RTC issue with Debian Buster Oliver Hartkopp <socketcan@hartkopp.net> - 2019-07-26 13:00 +0200
  Bug#932845: TS-219 RTC issue with Debian Buster Oliver Hartkopp <socketcan@hartkopp.net> - 2019-07-26 21:20 +0200
  Bug#932845: TS-219 RTC issue with Debian Buster Uwe Kleine-König <u.kleine-koenig@pengutronix.de> - 2019-07-28 21:50 +0200
    Bug#932845: TS-219 RTC issue with Debian Buster Oliver Hartkopp <socketcan@hartkopp.net> - 2019-07-29 08:30 +0200
  Processed: Re: Bug#932845: TS-219 RTC issue with Debian Buster "Debian Bug Tracking System" <owner@bugs.debian.org> - 2019-07-28 21:50 +0200

csiph-web