Bug#910366: linux: ath9k-htc on OHCI -> bogus usb xfer

From	"W. Martin Borgert" <debacle@debian.org>
Newsgroups	linux.debian.bugs.dist, linux.debian.kernel
Subject	Bug#910366: linux: ath9k-htc on OHCI -> bogus usb xfer
Date	2018-10-05 14:20 +0200
Message-ID	<wFxfj-1t9-1@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Cross-posted to 2 groups.

Show all headers | View raw

Package: linux
Version: 4.9.110-1
Tags: patch

This is regression, on older (3.x) kernels, it used to work:
On my USB 1.1 port I cannot use my USB WLAN adaptor anymore
(TL-WN722N with hostapd).

When I remove the following lines, everything is fine again:

diff --git a/drivers/usb/core/urb.c b/drivers/usb/core/urb.c
index 3d27477..a317e1e 100644
--- a/drivers/usb/core/urb.c
+++ b/drivers/usb/core/urb.c
@@ -443,11 +443,6 @@ int usb_submit_urb(struct urb *urb, gfp_t mem_flags)
  	 * cause problems in HCDs if they get it wrong.
  	 */

-	/* Check that the pipe's type matches the endpoint's type */
-	if (usb_pipetype(urb->pipe) != pipetypes[xfertype])
-		dev_WARN(&dev->dev, "BOGUS urb xfer, pipe %x != type %x\n",
-			usb_pipetype(urb->pipe), pipetypes[xfertype]);
-
  	/* Check against a simple/standard policy */
  	allowed = (URB_NO_TRANSFER_DMA_MAP | URB_NO_INTERRUPT | URB_DIR_MASK |
  			URB_FREE_BUFFER);

Thanks to Alexey Brodkin for finding the culprit.

See here:

https://lists.openwrt.org/pipermail/openwrt-devel/2016-July/001723.html

and here:

http://lists.infradead.org/pipermail/linux-snps-arc/2016-July/001310.html

Back to linux.debian.kernel | Previous | Next | Find similar | Unroll thread

Thread

Bug#910366: linux: ath9k-htc on OHCI -> bogus usb xfer "W. Martin Borgert" <debacle@debian.org> - 2018-10-05 14:20 +0200

csiph-web