Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.debian.kernel > #60635

Re: [PATCH v5] scripts/package/builddeb: split generating packaging and build

Path csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From Masahiro Yamada <yamada.masahiro@socionext.com>
Newsgroups linux.debian.kernel
Subject Re: [PATCH v5] scripts/package/builddeb: split generating packaging and build
Date Thu, 05 Apr 2018 17:10:02 +0200
Message-ID <vBeGu-69t-13@gated-at.bofh.it> (permalink)
References <vBbpg-3W7-23@gated-at.bofh.it>
X-Original-To Riku Voipio <riku.voipio@linaro.org>
X-Mailbox-Line From debian-kernel-request@lists.debian.org Thu Apr 5 15:06:17 2018
Old-Return-Path <yamada.masahiro@socionext.com>
X-Amavis-Spam-Status No, score=-1.88 tagged_above=-10000 required=5.3 tests=[BAYES_00=-2, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FOURLA=0.1, MURPHY_DRUGS_REL8=0.02, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=no autolearn_force=no
X-Policyd-Weight NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_BL_NJABL=-1.5 CL_IP_EQ_HELO_IP=-2 (check from: .socionext. - helo: .conssluserg-03.nifty. - helo-domain: .nifty.) FROM/MX_MATCHES_NOT_HELO(DOMAIN)=0; rate: -5
Dkim-Filter OpenDKIM Filter v2.10.3 conssluserg-03.nifty.com w35EoNRX014911
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1522939824; bh=Gd+VvOwgIXswvet4OhY7u5JvEqcApRUcjtnmU9TVMcM=; h=In-Reply-To:References:From:Date:Subject:To:Cc:From; b=WD4KMJlG9WhkroM3zmBTAcUvYuLnvhdshvfSCI/7QvX0QExtFHZI7olgZUUFtvIX9 ZHzdNk5C7EqZaXUkk4dAC1INU4EaJ/kwNrm3dt5jOQGAbj83gAHgG6viMwfPvZSSA/ SZyo9shKGoa3GytZVqudzPEwlFt+FLuhtoiYRjWRFdN2Dz+yvENwtr6SLSLOB3gm5X YAqApLgBH3J9MCQKlYzjhMq137Uuv6iMQktMTvyexj9cB4vi0NxwjgciddefPaMcGy cpxepm6Cq9h77Xh1H0QijXfRQPmIiiH2HO2mTj2QfE17eSnOGPxliiD0CqGGN+ZQ3W 1a+woHr8U6Sqg==
X-Nifty-Srcip [209.85.217.182]
X-Gm-Message-State AElRT7Fu0QXJ0qNNzMD9L0P0fFStTRpDcaYm5b2NvzdT54v1sKWP5LsX LNx+S6vDFYFfDgg5KdzJoGRrhFqX6Tvpf6gAnZI=
X-Google-SMTP-Source AIpwx4/mFhQNk9/c4DcPzNqID6wQP7jPL8BPQv5Gnq9gjdQt3ZRr5C9O5VLz0oiRbnMNvShvS7xcAbaBx+Liv5rcii8=
X-Received by 10.159.46.7 with SMTP id t7mr13849723uaj.199.1522939823116; Thu, 05 Apr 2018 07:50:23 -0700 (PDT)
MIME-Version 1.0
X-Gmail-Original-Message-ID <CAK7LNASm_7+vRr_uM8efR+UgUaQzJYQH=mE9DCv3yv46F0sV9Q@mail.gmail.com>
Content-Type text/plain; charset="UTF-8"
X-Mailing-List <debian-kernel@lists.debian.org> archive/latest/116273
List-ID <debian-kernel.lists.debian.org>
List-URL <https://lists.debian.org/debian-kernel/>
List-Archive https://lists.debian.org/msgid-search/CAK7LNASm_7+vRr_uM8efR+UgUaQzJYQH=mE9DCv3yv46F0sV9Q@mail.gmail.com
Approved robomod@news.nic.it
Lines 29
Organization linux.* mail to news gateway
Sender robomod@news.nic.it
X-Original-Cc Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>, debian-kernel <debian-kernel@lists.debian.org>
X-Original-Date Thu, 5 Apr 2018 23:49:42 +0900
X-Original-Message-ID <CAK7LNASm_7+vRr_uM8efR+UgUaQzJYQH=mE9DCv3yv46F0sV9Q@mail.gmail.com>
X-Original-References <20180405112229.5576-1-riku.voipio@linaro.org>
Xref csiph.com linux.debian.kernel:60635

Show key headers only | View raw


2018-04-05 20:22 GMT+09:00  <riku.voipio@linaro.org>:
> From: Riku Voipio <riku.voipio@linaro.org>
>
> Move debian/ directory generation out of builddeb to a new script,
> mkdebian. The package build commands are kept in builddeb, which
> is now an internal command called from debian/rules.
>
> With these changes in place, we can now use dpkg-buildpackage from
> deb-pkg and bindeb-pkg removing need for handrolled source/changes
> generation.
>
> This patch is based on the criticism of the current state of builddeb
> discussed on:
>
> https://patchwork.kernel.org/patch/9656403/
>
> Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
> ---

Applied to linux-kbuild
with the following fix-up.  Thanks!


> +cat <<EOF > debian/rules
> +#!$(command -v $MAKE)  -f

I see two spaces between '$(command -v $MAKE)' and '-f'

I removed one space.

Back to linux.debian.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH v5] scripts/package/builddeb: split generating packaging and build riku.voipio@linaro.org - 2018-04-05 13:40 +0200
  Re: [PATCH v5] scripts/package/builddeb: split generating packaging  and build Masahiro Yamada <yamada.masahiro@socionext.com> - 2018-04-05 17:10 +0200

csiph-web