Re: [PATCH] kbuild: Do not use hyphen in exported variable name

From	Ben Hutchings <ben@decadent.org.uk>
Newsgroups	linux.debian.kernel
Subject	Re: [PATCH] kbuild: Do not use hyphen in exported variable name
Date	2017-08-19 22:20 +0200
Message-ID	<uginT-5OS-3@gated-at.bofh.it> (permalink)
References	(2 earlier) <tzk81-5ta-7@gated-at.bofh.it> <tBYaZ-4ky-7@gated-at.bofh.it> <tBYkF-4nQ-1@gated-at.bofh.it> <ug0AG-35E-1@gated-at.bofh.it> <uggm6-4B1-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Sun, 2017-08-20 at 02:37 +0900, Masahiro Yamada wrote:
[...]
> I did "grep SHELL" in kernel sources, but I could not
> find suspicious line.
> 
> 
> Is there anyone that sets SHELL
> in debian specific patches?

No, there isn't.  But I finally worked out the trigger conditions:

1. Source directory name includes a shell special character.  This is
true in Debian whenever we build a release candidate, because the
source directory is named after the package version, and we use ~ to
represent a pre-release version (e.g. 4.13~rc5 sorts before 4.13).

2. Object directory is outside the source directory, or at least two
levels below it (see the definition of srctree in the top level
Makefile).  This is always true in Debian package builds.

Shell comamnds to reproduce this:

rsync --archive --exclude /.git/ . /tmp/linux~/
cd /tmp/linux~
make mrproper
make O=one/two ARCH=arm64 defconfig
make -C one/two ARCH=arm64 dtbs
make -C one/two ARCH=arm64 INSTALL_DTBS_PATH=dtbs~ dtbs_install

Ben.

-- 
Ben Hutchings
The generation of random numbers is too important to be left to chance.
                                                       - Robert Coveyou

Back to linux.debian.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] kbuild: Do not use hyphen in exported variable name Ben Hutchings <ben@decadent.org.uk> - 2017-04-18 03:10 +0200
  Re: [PATCH] kbuild: Do not use hyphen in exported variable name Sam Ravnborg <sam@ravnborg.org> - 2017-04-18 07:10 +0200
  Re: [PATCH] kbuild: Do not use hyphen in exported variable name Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-04-23 09:10 +0200
    Re: [PATCH] kbuild: Do not use hyphen in exported variable name Ben Hutchings <ben@decadent.org.uk> - 2017-04-23 09:30 +0200
      Re: [PATCH] kbuild: Do not use hyphen in exported variable name Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-04-30 16:40 +0200
        Re: [PATCH] kbuild: Do not use hyphen in exported variable name Ben Hutchings <ben@decadent.org.uk> - 2017-04-30 16:50 +0200
          Re: [PATCH] kbuild: Do not use hyphen in exported variable name Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-05-03 07:10 +0200
          Re: [PATCH] kbuild: Do not use hyphen in exported variable name Ben Hutchings <ben@decadent.org.uk> - 2017-08-19 03:20 +0200
            Re: [PATCH] kbuild: Do not use hyphen in exported variable name Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-08-19 20:10 +0200
              Re: [PATCH] kbuild: Do not use hyphen in exported variable name Ben Hutchings <ben@decadent.org.uk> - 2017-08-19 22:20 +0200

csiph-web