Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.kernel > #57626

Re: [PATCH 3/3] builddeb: add make fastdeb-pkg target

Show key headers only | View raw

Hi Riku,


2017-04-20 19:53 GMT+09:00 Riku Voipio <riku.voipio@linaro.org>:
> Hi,
>
> Thanks for taking time to review.
>
> On 18 April 2017 at 17:31, Masahiro Yamada
> <yamada.masahiro@socionext.com> wrote:
>> Before expanding this even more,
>> please help me understand this script.
>>
>> Commit 3716001b implemented source package build
>> at the end of the builddeb script.
>> However, the binary packages are still built in its own way.
>> (So, debian/rules is not used in general workflows,
>> so we need to test it explicitly somehow.)
>
> Historic reasons.. since the builddeb already existed, the easiest way
> to implement debian/rules was to make a skeleton debian/rules that
> calls builddeb indrectly.
>
>> Why do not we create a source package first,
>> then build binary packages from it?
>
> I wouldn't do a source package per se, but we could create a debian/
> directory tree and the call dpkg-buildpackage. This would be a more
> substantial overhaul that might break some expected behavior of
> deb-pkg targets. If people think its worth, I can give it a shot.


In hindsight, it seems more straightforward to me
to build the binary packages from the source package.
But, I know this refactoring will need lots of changes, which may
break something.

Once we support this fastdeb-pkg target,
we will not be able to convert the script in that way.
(because we do not have a standard way to generate a particular binary
package from *.dsc)
That's why I asked the question, and I want to be careful.



>> rpm-pkg does that way.
>> (generate a spec-file, then run rpmbuild)
>
> speaking of the mkspec script, it would be nice to refactor it to here
> documents over endless lines of echo.

As always, cleaning patches are welcome.



-- 
Best Regards
Masahiro Yamada

Back to linux.debian.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] builddeb: add make fastdeb-pkg target riku.voipio@linaro.org - 2017-03-31 15:30 +0200
  Re: [PATCH 3/3] builddeb: add make fastdeb-pkg target Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-04-18 17:00 +0200
    Re: [PATCH 3/3] builddeb: add make fastdeb-pkg target Riku Voipio <riku.voipio@linaro.org> - 2017-04-20 13:10 +0200
      Re: [PATCH 3/3] builddeb: add make fastdeb-pkg target Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-04-21 12:20 +0200
        Re: [PATCH 3/3] builddeb: add make fastdeb-pkg target Ben Hutchings <ben@decadent.org.uk> - 2017-04-21 17:10 +0200

csiph-web