Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.debian.kernel > #57434
| From | Michal Marek <mmarek@suse.com> |
|---|---|
| Newsgroups | linux.debian.bugs.dist, linux.debian.kernel |
| Subject | Bug#856474: [PATCH] Kbuild.include: addtree: Remove quotes before matching path |
| Date | 2017-04-03 15:50 +0200 |
| Message-ID | <tsawO-7yd-21@gated-at.bofh.it> (permalink) |
| References | <tmuHU-4rH-9@gated-at.bofh.it> <ts546-3XB-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Cross-posted to 2 groups.
On 2017-04-03 09:42, Masahiro Yamada wrote: > Each Makefile knows it wants to see > additional headers in the source tree, or objtree. > > I am guessing the right approach in a long run is, > we require -I to specify $(srctree) or $(objtree) explicitly. > > ccflags-y := -I$(srctree)/foo/bar/baz > > or > > ccflags-y := -I$(objtree)/foo/bar/baz > > > (For the latter, we can omit $(objtree)/ as it is ./) > > > Then, delete $(call flags,_c_flags) after the conversion. Agreed. The addtree function is more of a hack to make things just work with O=, but AFAIK there is no clean way to implement VPATH for -I arguments. So it's sensible to get rid of the hack. It looks like it's going to be lot of work though: $ git grep -e '-I' -- '*Makefile*' | wc -l 732 $ git grep -e '-I *\$(\(src\|obj\)tree)' -- '*Makefile*' | wc -l 166 Michal
Back to linux.debian.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Bug#856474: [PATCH] Kbuild.include: addtree: Remove quotes before matching path Ben Hutchings <ben@decadent.org.uk> - 2017-03-18 23:10 +0100
Bug#856474: [PATCH] Kbuild.include: addtree: Remove quotes before matching path Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-04-03 10:00 +0200
Bug#856474: [PATCH] Kbuild.include: addtree: Remove quotes before matching path Michal Marek <mmarek@suse.com> - 2017-04-03 15:50 +0200
Bug#856474: [PATCH] Kbuild.include: addtree: Remove quotes before matching path Sam Ravnborg <sam@ravnborg.org> - 2017-04-03 22:40 +0200
Bug#856474: [PATCH] Kbuild.include: addtree: Remove quotes before matching path Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-04-04 06:10 +0200
Bug#856474: [PATCH] Kbuild.include: addtree: Remove quotes before matching path Michal Marek <mmarek@suse.com> - 2017-04-04 09:10 +0200
csiph-web