Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.kernel > #57408

Bug#853122: [Regression] Changes to i2c-piix4.c initialisation prevent loading of sp5100_tco watchdog driver on AMD SB800 chipset

Cross-posted to 3 groups.

Show all headers | View raw

On 04/01/2017 03:13 AM, Boszormenyi Zoltan wrote:
> 2017-03-31 17:05 keltezéssel, Guenter Roeck írta:
>> On Fri, Mar 31, 2017 at 04:46:02PM +0200, Boszormenyi Zoltan wrote:
>>> 2017-03-31 14:49 keltezéssel, Guenter Roeck írta:
>>>> request_muxed_region() can fail, and literally every other driver
>>>> using it checks for that failure. Please do the same.
>>>
>>> In what circumstances can request_muxed_region() fail? As far as
>>> I can see, only if two drivers use the same I/O port base and the
>>> already present region did not use IORESOURCE_MUXED which is
>>> not the case here. When request_muxed_region() is used consistently,
>>> subsequent requests are put on a wait queue and the first one is
>>> woken up when the region is released. So, it's basically a mutex.
>>> Am I missing something here?
>>>
>>
>> Yes. failure to allocate the resource is one.
>
> So, a common mutex should be used.
>

Just because you don't want to check for errors ?

I am not on favor of your new solution. I think it violates layering all over
the place, and I dislike the idea of having a global mutex as you propose.
I won't shut it down, but I'll let others provide feedback on your new series
of patches.

Guenter

> I have also added synchronization to the USB PCI quirks code and
> have split the patch into three pieces now (USB quirks, i2c-piix4 and
> sp5100_tco) and they were sent to the relevant mailing lists.
>
> I don't know which subsystem wants to take it, all 3 patches are
> needed at once.
>
> Best regards,
> Zoltán Böszörményi
>

Back to linux.debian.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Bug#853122: sp5100_tco: I/O address 0x0cd6 already in use Paul Menzel <pm.debian@googlemail.com> - 2017-01-29 23:30 +0100
  Processed: sp5100_tco: I/O address 0x0cd6 already in use owner@bugs.debian.org (Debian Bug Tracking System) - 2017-01-29 23:30 +0100
  Bug#853122: [Regression] Changes to i2c-piix4.c initialisation prevent loading of sp5100_tco watchdog driver on AMD SB800 chipset Paul Menzel <paulepanter@users.sourceforge.net> - 2017-03-03 10:00 +0100
    Bug#853122: [Regression] Changes to i2c-piix4.c initialisation prevent loading of sp5100_tco watchdog driver on AMD SB800 chipset Wolfram Sang <wsa@the-dreams.de> - 2017-03-03 11:30 +0100
      Bug#853122: [Regression] Changes to i2c-piix4.c initialisation prevent loading of sp5100_tco watchdog driver on AMD SB800 chipset Paul Menzel <paulepanter@users.sourceforge.net> - 2017-03-31 09:30 +0200
        Bug#853122: [Regression] Changes to i2c-piix4.c initialisation prevent loading of sp5100_tco watchdog driver on AMD SB800 chipset Guenter Roeck <linux@roeck-us.net> - 2017-03-31 15:20 +0200
          Bug#853122: [Regression] Changes to i2c-piix4.c initialisation prevent loading of sp5100_tco watchdog driver on AMD SB800 chipset Boszormenyi Zoltan <zboszor@pr.hu> - 2017-03-31 16:50 +0200
            Bug#853122: [Regression] Changes to i2c-piix4.c initialisation prevent loading of sp5100_tco watchdog driver on AMD SB800 chipset Guenter Roeck <linux@roeck-us.net> - 2017-03-31 17:10 +0200
              Bug#853122: [Regression] Changes to i2c-piix4.c initialisation prevent loading of sp5100_tco watchdog driver on AMD SB800 chipset Boszormenyi Zoltan <zboszor@pr.hu> - 2017-04-01 12:20 +0200
                Bug#853122: [Regression] Changes to i2c-piix4.c initialisation prevent loading of sp5100_tco watchdog driver on AMD SB800 chipset Guenter Roeck <linux@roeck-us.net> - 2017-04-01 15:40 +0200
                Bug#853122: [Regression] Changes to i2c-piix4.c initialisation prevent loading of sp5100_tco watchdog driver on AMD SB800 chipset Boszormenyi Zoltan <zboszor@pr.hu> - 2017-04-01 18:30 +0200
                Bug#853122: [Regression] Changes to i2c-piix4.c initialisation prevent loading of sp5100_tco watchdog driver on AMD SB800 chipset Boszormenyi Zoltan <zboszor@pr.hu> - 2017-04-01 18:40 +0200
                Bug#853122: [Regression] Changes to i2c-piix4.c initialisation prevent loading of sp5100_tco watchdog driver on AMD SB800 chipset Paul Menzel <paulepanter@users.sourceforge.net> - 2017-04-03 08:40 +0200
                Bug#853122: [Regression] Changes to i2c-piix4.c initialisation prevent loading of sp5100_tco watchdog driver on AMD SB800 chipset Boszormenyi Zoltan <zboszor@pr.hu> - 2017-04-03 10:10 +0200
                Bug#853122: [Regression] Changes to i2c-piix4.c initialisation prevent loading of sp5100_tco watchdog driver on AMD SB800 chipset Boszormenyi Zoltan <zboszor@pr.hu> - 2017-06-27 14:30 +0200
  Bug#853122: Same Error Carl N <carlnikolov@gmail.com> - 2017-08-31 04:40 +0200
  Bug#853122: Same error sp5100_tco: I/O address 0x0cd6 already in use Sisim Biva <sisimbiva@gmail.com> - 2017-10-02 10:20 +0200
  Bug#853122: posts bugs alain BELLEC <alain_bellec@bbox.fr> - 2017-10-02 12:30 +0200
  Bug#853122: [Regression] Changes to i2c-piix4.c initialisation prevent loading of sp5100_tco watchdog driver on AMD SB800 chipset Gyorgy Kapolnas <rty042@gmail.com> - 2017-11-22 12:30 +0100
  Bug#853122: linux-image-4.13.0-0.bpo.1-amd64: Also present at Gigabyte GA-AM1M-S2H Rainer Dorsch <ml@bokomoko.de> - 2017-12-16 21:30 +0100

csiph-web