Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.kernel > #56832

Bug#853073: Wrong firmware loaded as a result of commit 339162b

Cross-posted to 2 groups.

Show all headers | View raw

On 01/29/2017 07:13 PM, Jurij Smakov wrote:
> [Contacting authors of the problematic commit with proposed patch]
>
> Hello,
>
> I was investigating the regression in performance of wifi on my laptop (using
> rtl8192ce driver) and I believe that it is a result of recent commit 339162b:
>
> https://github.com/torvalds/linux/commit/cf4747d7535a936105f0abe8d8109d3fe339162b
>
> I believe that during the refactoring the default name of the firmware file was
> erroneously changed to rtlwifi/rtl8192cfwU.bin (was rtlwifi/rtl8192cfw.bin
> before this change) and, as a result, some logic used to determine the correct
> name of the firmware file for different sub-versions of the card was removed
> mistakenly as well. This causes wrong firmware to be loaded on my machine
> (rtl8192cfwU.bin instead of rtl8192cfw.bin), resulting in much more unstable link.
>
> Please consider applying the following patch to fix this situation:
>
> http://www.wooyd.org/tmp/rtl8192ce_firmware.patch
>
> I built a kernel with this patch applied, and the expected firmware was loaded
> as a result, fixing my problem:
>
> [   13.202250] rtl8192ce: Using firmware rtlwifi/rtl8192cfw.bin
> [   13.253980] ieee80211 phy0: Selected rate control algorithm 'rtl_rc'
> [   13.254434] rtlwifi: rtlwifi: wireless switch is on
> [   13.460663] rtl8192ce 0000:03:00.0: firmware: direct-loading firmware
> rtlwifi/rtl8192cfw.bin

Jurij,

Good catch. That explains why I have been unable to duplicate the problems that 
some users have reported. As it happens, my test chip uses 
rtlwifi/rtl8192cfwU_B.bin and was not affected by the bug.

I will be sending the fix to mainline with you as the author.

Thanks,

Larry

Back to linux.debian.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Bug#853073: Wrong firmware loaded as a result of commit 339162b Jurij Smakov <jurij@wooyd.org> - 2017-01-30 02:20 +0100
  Bug#853073: Wrong firmware loaded as a result of commit 339162b Larry Finger <Larry.Finger@lwfinger.net> - 2017-01-30 03:10 +0100

csiph-web