Re: [PATCH] Consolidate gadget config

From	Ben Hutchings <ben@decadent.org.uk>
Newsgroups	linux.debian.kernel
Subject	Re: [PATCH] Consolidate gadget config
Date	2017-01-27 22:20 +0100
Message-ID	<t4m66-Rh-3@gated-at.bofh.it> (permalink)
References	<t4fxD-5cg-15@gated-at.bofh.it> <t4kdY-88u-15@gated-at.bofh.it> <t4lD3-ro-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Fri, 2017-01-27 at 22:30 +0200, Riku Voipio wrote:
> On 27 January 2017 at 21:09, Ben Hutchings <ben@decadent.org.uk> wrote:
> > On Fri, 2017-01-27 at 16:02 +0200, riku.voipio@linaro.org wrote:
> > > From: Riku Voipio <riku.voipio@linaro.org>
> > > 
> > > If CONFIG_USB_GADGET is selected, enable all configfs functions as
> > > modules and most popular legacy modules (ethernet and serial).
> > > g_nokia left as armhf specific (Nokia N900 tradition)
> > 
> > [...]
> > > --- a/debian/config/armhf/config
> > > +++ b/debian/config/armhf/config
> > > @@ -1114,9 +1114,6 @@ CONFIG_USB_GADGET=m
> > >  ##
> > >  ## file: drivers/usb/gadget/legacy/Kconfig
> > >  ##
> > > -CONFIG_USB_ETH=m
> > > -CONFIG_USB_ETH_RNDIS=y
> > > -CONFIG_USB_GADGETFS=m
> > >  CONFIG_USB_G_NOKIA=m
> > > 
> > >  ##
> > > diff --git a/debian/config/config b/debian/config/config
> > > index c744073f9..d6ec09462 100644
> > > --- a/debian/config/config
> > > +++ b/debian/config/config
> > 
> > [...]
> > > +##
> > > +## file: drivers/usb/gadget/legacy/Kconfig
> > > +##
> > > +CONFIG_USB_ETH=m
> > > +CONFIG_USB_ETH_RNDIS=y
> > > +CONFIG_USB_GADGETFS=m
> > > +CONFIG_USB_FUNCTIONFS=m
> > > +CONFIG_USB_FUNCTIONFS_ETH=y
> > > +CONFIG_USB_FUNCTIONFS_RNDIS=y
> > > +CONFIG_USB_FUNCTIONFS_GENERIC=y
> > > +CONFIG_USB_G_SERIAL=m
> > 
> > Sorry to mess you around, but I wonder now if it really makes sense to
> > enable more of the legacy interface.  If I understood correctly, the
> > configfs interface provides all the same functionality and more, and
> > userspace should be moving to use that.
> > 
> > Perhaps we should:
> > 1. Enable the configfs interface in the top-level config
> > 2. Leave armhf with limited legacy configuration interface support for
> > stretch (in case there are users that depend on it)
> > 3. Disable the legacy interface post-stretch.
> 
> I thought about it, but frankly using g_ether and g_serial is so convenient.
> it's a matter of "modprobe  g_ether && dhclient -i usb0".
> Using the modern configfs way is quite a bit of more steps:
> 
> http://events.linuxfoundation.org/sites/events/files/slides/USB%20Gadget%20Configfs%20API_0.pdf

I know, that's the same document I found.

> We would at least need libusbg and gadget-tool
> (https://github.com/kopasiak/gt) included in
> debian before deprecating.

It's rather sad that they haven't been packaged yet.  Can you open an
ITP or RFP for them?

I've applied your proposed changes but I would like to remove the
legacy interfaces once gadget-tool is packaged.

Ben.

-- 
Ben Hutchings
Design a system any fool can use, and only a fool will want to use it.

Back to linux.debian.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Consolidate gadget config riku.voipio@linaro.org - 2017-01-27 15:20 +0100
  Re: [PATCH] Consolidate gadget config Ben Hutchings <ben@decadent.org.uk> - 2017-01-27 20:20 +0100
    Re: [PATCH] Consolidate gadget config Riku Voipio <riku.voipio@linaro.org> - 2017-01-27 21:50 +0100
      Re: [PATCH] Consolidate gadget config Ben Hutchings <ben@decadent.org.uk> - 2017-01-27 22:20 +0100

csiph-web