Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.debian.kernel > #89719

Bug#1118465: Regression: linux-image-5.10.0-36-arm64 fails to bring up LAN7800 USB NIC: "NO-CARRIER" and "state DOWN"

From Salvatore Bonaccorso <carnil@debian.org>
Newsgroups linux.debian.bugs.dist, linux.debian.kernel
Subject Bug#1118465: Regression: linux-image-5.10.0-36-arm64 fails to bring up LAN7800 USB NIC: "NO-CARRIER" and "state DOWN"
Date 2025-10-22 14:50 +0200
Message-ID <LIGrU-76o8-5@gated-at.bofh.it> (permalink)
References <LI1oJ-6EES-7@gated-at.bofh.it> <LI1oJ-6EES-7@gated-at.bofh.it> <LIr9v-6Wbz-1@gated-at.bofh.it> <LI1oJ-6EES-7@gated-at.bofh.it> <LIr9v-6Wbz-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Cross-posted to 2 groups.

Show all headers | View raw


Hi Ben,

In case Axel can confirm, there is a "off-by-one" in one of the Fixes:

On Tue, Oct 21, 2025 at 10:27:37PM +0200, Ben Hutchings wrote:
> Control: tag -1 upstream patch moreinfo
> 
> Does this patch fix it?
> 
> Ben.
> 
> -- 
> Ben Hutchings
> Editing code like this is akin to sticking plasters on the bleeding
> stump of a severed limb. - me, 29 June 1999

> From 4f97e494a3e2500166be4e8b53b4c412d6a44a9f Mon Sep 17 00:00:00 2001
> From: Ben Hutchings <benh@debian.org>
> Date: Tue, 21 Oct 2025 22:18:49 +0200
> Subject: [PATCH] usbnet: Report link up even when the interface is not yet up
> 
> Even after commit 466d393700f9 ("net: usbnet: Fix the wrong
> netif_carrier_on() call"), usbnet isn't calling netif_carrier_on() in
> all the same cases it would before.  Specifically, if the link is
> reported up before EVENT_DEV_OPEN is set, netif_carrier_on() may no
> longer be called.
> 
> Fix this by checking for EVENT_LINK_CARRIER_ON first in
> __handle_link_change(), before EVENT_DEV_OPEN.
> 
> References: https://bugs.debian.org/1118465
> Reported-by: Axel Beckert <axel@ethz.ch>
> Fixes: 0d9cfc9b8cb1 ("net: usbnet: Avoid potential RCU stall on LINK_CHANGE event")
> Fixes: 466d393700f9 ("net: usbnet: Fix the wrong netif_carrier_on() call")

Should that be
Fixes: 8466d393700f ("net: usbnet: Fix the wrong netif_carrier_on() call")
?

Spotted it while checking to see ee which other stable series are affected.

Regards,
Salvatore

Back to linux.debian.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

Bug#1118465: Regression: linux-image-5.10.0-36-arm64 fails to bring up LAN7800 USB NIC: "NO-CARRIER" and "state DOWN" Ben Hutchings <ben@decadent.org.uk> - 2025-10-21 22:30 +0200
  Processed: Re: Bug#1118465: Regression: linux-image-5.10.0-36-arm64  fails to bring up LAN7800 USB NIC: "NO-CARRIER" and "state DOWN" "Debian Bug Tracking System" <owner@bugs.debian.org> - 2025-10-21 22:30 +0200
  Bug#1118465: Regression: linux-image-5.10.0-36-arm64 fails to bring up LAN7800 USB NIC: "NO-CARRIER" and "state DOWN" Salvatore Bonaccorso <carnil@debian.org> - 2025-10-22 14:50 +0200
  Bug#1118465: Regression: linux-image-5.10.0-36-arm64 fails to bring up LAN7800 USB NIC: "NO-CARRIER" and "state DOWN" Axel Beckert <abe@debian.org> - 2025-10-23 16:50 +0200
    Bug#1118465: Regression: linux-image-5.10.0-36-arm64 fails to bring up LAN7800 USB NIC: "NO-CARRIER" and "state DOWN" Axel Beckert <abe@debian.org> - 2025-11-08 18:40 +0100
      Bug#1118465: Regression: linux-image-5.10.0-36-arm64 fails to bring up LAN7800 USB NIC: "NO-CARRIER" and "state DOWN" Salvatore Bonaccorso <carnil@debian.org> - 2025-11-08 22:00 +0100

csiph-web