Bug#991943: klibc: please consider including machine-readable copyright file

From	Ben Hutchings <ben@decadent.org.uk>
Newsgroups	linux.debian.bugs.dist, linux.debian.kernel
Subject	Bug#991943: klibc: please consider including machine-readable copyright file
Date	2025-03-04 06:30 +0100
Message-ID	<Kmt0R-3trK-1@gated-at.bofh.it> (permalink)
References	(1 earlier) <CJ7iO-8fL-5@gated-at.bofh.it> <CKVGx-2rg-5@gated-at.bofh.it> <CKVQe-2uH-7@gated-at.bofh.it> <CJ7iO-8fL-5@gated-at.bofh.it> <CKVQe-2uH-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Cross-posted to 2 groups.

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, 11 Aug 2021 14:40:20 +0200 Andrej Shadura <andrew.shadura@collabora.co.uk> wrote:
> On 11/08/2021 14:30, Andrej Shadura wrote:
> > On Fri, 06 Aug 2021 14:31:26 +0200 Andrej Shadura <andrewsh@debian.org>
> > wrote:
> >> Please consider including the attached machine-readable copyright file.
> >> I tried to make it as precise as I can based on the information in the
> >> source and accompanying text files; improve it as you see fit.
> > 
> > I’ve noticed a few issues with the proposed copyright file. I have fixed
> > them; please find the attached patch to the packaging.

Thanks for having a go at this.

> Of course, once again I’ve forgotten something:
> 
> Files: debian/*
> Copyright:
>  2005      Jeff Bailey <jbailey@raspberryginger.com>
>  2005-2014 maximilian attems <maks@sternwelten.at>
>  2015-2021 Ben Hutchings <ben@decadent.org.uk>
> 
> I’m not sure what the license of the packaging is.

I believe it should be the same as upstream's default license, i.e.
Expat.

I think the contributions of Jeff Bailey and several others are
© Canonical Ltd.  And there have been a couple of other contributors
whose work is still present and looks large enough to be copyrightable.

[...]

> +Files: *
> +Copyright: 2004-2021, H. Peter Anvin and klibc contributors
> +License: BSD-3-clause and/or GPL-2 and/or Expat

Using "... and/or ..." is not allowed by the format, and I don't think
it would be a useful description anyway.

Since usr/klibc/LICENSE says that the Expat license applies to "all
remaining files", I think the wildcard paragraph should simply have
"License: Expat" and all the other paragraphs with "License: Expat" can
be dropped.

[...]

> +Files: scripts/basic/fixdep.c
> +Copyright: 2002, Kai Germaschewski <kai.germaschewski@gmx.de>
> +License: GPL-2

In fact, the files under scripts/ are mostly derived from the Linux
kernel's scripts directory (though with many changes), so I think all of
them should have "License: GPL-2".

[...]
> +Files: usr/dash/src/bltin/test.c

This should be "usr/dash/bltin/test.c".

> +Copyright: Erik Baalbergen, Eric Gisin, Arnold Robbins, J.T. Conklin
> +License: public-domain

Public domain means copyright has been disclaimed, so I think no
copyright holders should be listed.  But the policy is not explicit
about this, and lintian insists there has to be a Copyright field.

The files usr/dash/hetio.[ch] also have different license terms from the
rest of usr/dash.

[...]
> +Files:
> + usr/include/arch/sparc/*
> + usr/klibc/arch/sparc/*
> +Copyright:
> + 1994, Allen Briggs
> + 1993, Adam Glass
> + 1988, University of Utah.
> + 1982, 1990, 1992, 1993, The Regents of the University of California.
> +License: BSD-4-Clause-UC

The files usr/include/paths.h and usr/utils/cat.c are also under this
license.

[...]
> +Files: usr/klibc/arch/ia64/klibc.ld
> +Copyright: 2014-2018, Free Software Foundation, Inc.
> +License: FSFAP

This file has since been removed upstream.

> +Files: usr/utils/cpio.c
> +Copyright: 1990-1992, 2001-2004, Free Software Foundation, Inc.
> +License: GPL-2+

The file usr/utils/insmod.c is also GPL-2+.

> +Files: usr/utils/minips.c
> +Copyright: 1998, Albert Cahalan
> +License: LGPL-2+
[...]
> +License: GPL-2
> + On Debian GNU/Linux systems, the complete text of the GNU General Public
> + License v2 can be found in /usr/share/common-licenses/GPL-2.

Several license texts are missing at the bottom of the file.

I'm attaching a patch that I think covers all the files correctly, and
satisfies lintian.  If you could check my work that would be
appreciated.

Ben.

-- 
Ben Hutchings
Experience is directly proportional to the value of equipment destroyed
                                                    - Carolyn Scheppner

Back to linux.debian.kernel | Previous | Next | Find similar | Unroll thread

Thread

Bug#991943: klibc: please consider including machine-readable copyright file Ben Hutchings <ben@decadent.org.uk> - 2025-03-04 06:30 +0100

csiph-web