Bug#1076483: [PATCH] cpufreq: intel_pstate: Make hwp_notify_lock a raw spinlock

From	xiao sheng wen(肖盛文) <atzlinux@sina.com>
Newsgroups	linux.debian.bugs.dist, linux.debian.kernel
Subject	Bug#1076483: [PATCH] cpufreq: intel_pstate: Make hwp_notify_lock a raw spinlock
Date	2024-10-01 03:50 +0200
Message-ID	<JsAbw-g5oY-1@gated-at.bofh.it> (permalink)
References	<JpGGt-ebBs-3@gated-at.bofh.it> <JsAbw-g5oY-3@gated-at.bofh.it> <JsAbw-g5oY-5@gated-at.bofh.it> <J133z-2EFt-9@gated-at.bofh.it> <JsAbw-g5oY-5@gated-at.bofh.it>
Organization	https://www.atzlinux.com

Cross-posted to 2 groups.

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

在 2024/9/28 19:51, Uwe Kleine-König 写道:
> Hello,
> 
> On Fri, Sep 27, 2024 at 03:47:08AM -0700, srinivas pandruvada wrote:
>> On Thu, 2024-09-19 at 10:11 +0200, Uwe Kleine-König wrote:
>>> notify_hwp_interrupt() is called via sysvec_thermal() ->
>>> smp_thermal_vector() -> intel_thermal_interrupt() in hard irq
>>> context.
>>> For this reason it must not use a simple spin_lock that sleeps with
>>> PREEMPT_RT enabled. So convert it to a raw spinlock.
>>>
>>> Reported-by: xiao sheng wen <atzlinux@sina.com>
>>> Link: https://bugs.debian.org/1076483
>>> Signed-off-by: Uwe Kleine-König <ukleinek@debian.org>
>>
>> Missing Tested-by?
> 
> Neither I nor anybody else did test that patch before I sent it to the
> list (apart from a build test). I guess xiao sheng wen might have
> replied with a Tested-by tag.
Yes, I had tested this patch on my notebook(base on Debian kernel 
6.10.11-1 (2024-09-22) source code).
Work perfect!

This bug exist in 6.9.9-rt-amd64 #1  Debian 6.9.9-1:
https://linux-hardware.org/?probe=d57f4d29a8&log=dmesg

This bug fixed in PREEMPT_RT atzlinux 6.10.11-1 (2024-09-22) with this 
patch:
https://linux-hardware.org/?probe=de5a44374a&log=dmesg

Tested-by: xiao sheng wen <atzlinux@sina.com>

> 
>>      Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> 
> Thanks
> Uwe

Regards,
-- 
肖盛文 xiao sheng wen
Debian QA page: 
https://qa.debian.org/developer.php?login=atzlinux%40sina.com
Debian salsa: https://salsa.debian.org/atzlinux-guest
GnuPG Public Key: 0x00186602339240CB

Thread

Bug#1076483: Call Trace on rt kernel, CPU Intel 13th Gen Intel(R) Core(TM) i5-1340P xiao sheng wen <atzlinux@sina.com> - 2024-07-17 05:00 +0200
  Processed: this bug also exist in 6.10-rt-amd64 "Debian Bug Tracking System" <owner@bugs.debian.org> - 2024-07-19 05:40 +0200
  Bug#1076483: [PATCH] cpufreq: intel_pstate: Make hwp_notify_lock a raw spinlock xiao sheng wen(肖盛文) <atzlinux@sina.com> - 2024-09-23 04:10 +0200
    Bug#1076483: [PATCH] cpufreq: intel_pstate: Make hwp_notify_lock a raw spinlock Uwe Kleine-König <ukleinek@debian.org> - 2024-09-26 10:00 +0200
      Bug#1076483: [PATCH] cpufreq: intel_pstate: Make hwp_notify_lock a raw spinlock xiao sheng wen(肖盛文) <atzlinux@sina.com> - 2024-09-27 12:00 +0200
        Bug#1076483: [PATCH] cpufreq: intel_pstate: Make hwp_notify_lock a raw spinlock Uwe Kleine-König <u.kleine-koenig@baylibre.com> - 2024-10-05 18:10 +0200
          Bug#1076483: [PATCH] cpufreq: intel_pstate: Make hwp_notify_lock a raw spinlock xiao sheng wen(肖盛文) <atzlinux@sina.com> - 2024-10-06 04:50 +0200
  Bug#1076483: [PATCH] cpufreq: intel_pstate: Make hwp_notify_lock a raw spinlock xiao sheng wen(肖盛文) <atzlinux@sina.com> - 2024-10-01 03:50 +0200
  Processed: Re: Bug#1076483: [PATCH] cpufreq: intel_pstate: Make  hwp_notify_lock a raw spinlock "Debian Bug Tracking System" <owner@bugs.debian.org> - 2024-10-05 18:10 +0200
  Processed: Re: Bug#1076483: [PATCH] cpufreq: intel_pstate: Make  hwp_notify_lock a raw spinlock "Debian Bug Tracking System" <owner@bugs.debian.org> - 2024-10-06 04:50 +0200

csiph-web