Bug#1039883: [PATCH] ext4: don't track ranges in fast_commit if inode has inlined data

From	"Luis Henriques (SUSE)" <luis.henriques@linux.dev>
Newsgroups	linux.debian.bugs.dist, linux.debian.kernel
Subject	Bug#1039883: [PATCH] ext4: don't track ranges in fast_commit if inode has inlined data
Date	2024-06-19 00:40 +0200
Message-ID	<IQPEC-3TIE-11@gated-at.bofh.it> (permalink)
References	<GLVm1-1I2F-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Cross-posted to 2 groups.

Show all headers | View raw

When fast-commit needs to track ranges, it has to handle inodes that have
inlined data in a different way because ext4_fc_write_inode_data(), in the
actual commit path, will attempt to map the required blocks for the range.
However, inodes that have inlined data will have it's data stored in
inode->i_block and, eventually, in the extended attribute space.

Unfortunately, because fast commit doesn't currently support extended
attributes, the solution is to mark this commit as ineligible.

Link: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1039883
Signed-off-by: Luis Henriques (SUSE) <luis.henriques@linux.dev>
---
 fs/ext4/fast_commit.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/fs/ext4/fast_commit.c b/fs/ext4/fast_commit.c
index 87c009e0c59a..d3a67bc06d10 100644
--- a/fs/ext4/fast_commit.c
+++ b/fs/ext4/fast_commit.c
@@ -649,6 +649,12 @@ void ext4_fc_track_range(handle_t *handle, struct inode *inode, ext4_lblk_t star
 	if (ext4_test_mount_flag(inode->i_sb, EXT4_MF_FC_INELIGIBLE))
 		return;
 
+	if (ext4_has_inline_data(inode)) {
+		ext4_fc_mark_ineligible(inode->i_sb, EXT4_FC_REASON_XATTR,
+					handle);
+		return;
+	}
+
 	args.start = start;
 	args.end = end;

Back to linux.debian.kernel | Previous | Next | Find similar | Unroll thread

Thread

Bug#1039883: [PATCH] ext4: don't track ranges in fast_commit if inode has inlined data "Luis Henriques (SUSE)" <luis.henriques@linux.dev> - 2024-06-19 00:40 +0200

csiph-web