Bug#1036543: [PATCH 5.10 076/529] crypto: ccp: Use the stack for small SEV command buffers

From	"Adam D. Barratt" <adam@adam-barratt.org.uk>
Newsgroups	linux.debian.bugs.dist, linux.debian.kernel
Subject	Bug#1036543: [PATCH 5.10 076/529] crypto: ccp: Use the stack for small SEV command buffers
Date	2023-08-18 22:40 +0200
Message-ID	<H4eqd-2NrF-3@gated-at.bofh.it> (permalink)
References	(3 earlier) <GzHHP-bAx7-13@gated-at.bofh.it> <GzHHP-bAx7-15@gated-at.bofh.it> <GzHHP-bAx7-5@gated-at.bofh.it> <Gy9yy-aDdA-7@gated-at.bofh.it> <GzHHP-bAx7-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Cross-posted to 2 groups.

Show all headers | View raw

Control: close -1 5.10.191-1

On Fri, 2023-05-26 at 17:36 +0200, Ben Hutchings wrote:
> On Wed, 2023-05-17 at 16:06 +0200, Greg Kroah-Hartman wrote:
> > On Wed, May 17, 2023 at 04:02:35PM +0200, Greg Kroah-Hartman wrote:
> > > On Wed, May 17, 2023 at 02:56:21PM +0200, Ben Hutchings wrote:
[..]
> > > Julien Cristau reported a regression in ccp - the
> > > > WARN_ON_ONCE(!virt_addr_valid(data)) is now being triggered.  I
> > > > believe
> > > > this was introduced by the above commit, which depends on:
> > > > 
> > > > commit 8347b99473a313be6549a5b940bc3c56a71be81c
> > > > Author: Sean Christopherson <seanjc@google.com>
> > > > Date:   Tue Apr 6 15:49:48 2021 -0700
> > > >  
> > > >     crypto: ccp: Play nice with vmalloc'd memory for SEV
> > > > command structs
> > > > 
> > > > Ben.
> > > > 
> > > 
> > > Thanks for letting me know, now queued up.
> > 
> > Nope, now dropped, it breaks the build :(
> 
> I've now looked further and found that we need both:
> 
> d5760dee127b crypto: ccp: Reject SEV commands with mismatching
> command buffer
> 8347b99473a3 crypto: ccp: Play nice with vmalloc'd memory for SEV
> command structs
> 
> (Not yet tested; I'll ask Julien if he can do that.)
> 

Having just upgraded several affected debian.org nodes, I'm happy to
confirm that the 5.10.191-1 kernel resolves the issue for us.

Regards,

Adam

Thread

Bug#1036543: linux: WARNING at drivers/crypto/ccp/sev-dev.c:168 __sev_do_cmd_locked+0x31b/0x350 [ccp] Julien Cristau <jcristau@debian.org> - 2023-05-22 11:00 +0200
  Processed: linux: WARNING at drivers/crypto/ccp/sev-dev.c:168  __sev_do_cmd_locked+0x31b/0x350 [ccp] "Debian Bug Tracking System" <owner@bugs.debian.org> - 2023-05-22 11:00 +0200
  Bug#1036543: [PATCH 5.10 076/529] crypto: ccp: Use the stack for small SEV command buffers Ben Hutchings <ben@decadent.org.uk> - 2023-05-26 17:40 +0200
    Bug#1036543: [PATCH 5.10 076/529] crypto: ccp: Use the stack for small SEV command buffers Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2023-06-07 20:10 +0200
    Bug#1036543: [PATCH 5.10 076/529] crypto: ccp: Use the stack for small SEV command buffers "Adam D. Barratt" <adam@adam-barratt.org.uk> - 2023-08-18 22:40 +0200
  Processed: Re: [PATCH 5.10 076/529] crypto: ccp: Use the stack  for small SEV command buffers "Debian Bug Tracking System" <owner@bugs.debian.org> - 2023-08-18 22:40 +0200

csiph-web