Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.kernel > #79554

Bug#1040738: linux: Please review firmware related Debian patches

Cross-posted to 2 groups.

Show key headers only | View raw

Source: linux
Version: 6.4.1-1~exp1
Severity: wishlist

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

While working on building/testing a Debian kernel for the PineTab2 I
noticed that I got a firmware (related) *error* in `dmesg`, while that
was not the case on a kernel with a Debian (based) config and the
upstream kernel source. Neither was it reported as an error in the OOTB
provided image/kernel (ALARM).
In both other cases it was reported as a *warning*.

When I build a new Debian kernel with the "firmware_class: Log every
success and failure against given device" patch removed (and adjusted
`d/patches/debian/firmware_class-refer-to-debian-wiki-firmware-page.patch`
to fix the resulting issue), then that same firmware related message was
reported as a warning too.

Before:  
```
root@pinetab2:~# dmesg --level emerg,alert,crit,err
[    0.000000] clk: failed to reparent gpll to clk_rtc32k_frac: -22
[    0.000000] clk: failed to reparent gpll to clk_rtc32k_frac: -22
[   23.391432] spi-nor spi4.0: unrecognized JEDEC id bytes: 00 00 00 00 00 00
[   23.466581] ov5648 2-0036: failed to find 168000000 clk rate in endpoint link-frequencies
[   23.513593] Goodix-TS 1-005d: firmware: failed to load goodix_911_cfg.bin (-2)
[   23.513603] firmware_class: See https://wiki.debian.org/Firmware for information about missing firmware
[   23.513640] Goodix-TS 1-005d: firmware: failed to load goodix_911_cfg.bin (-2)
```

After:  
```
root@pinetab2:~# dmesg --level emerg,alert,crit,err
[    0.000000] clk: failed to reparent gpll to clk_rtc32k_frac: -22
[    0.000000] clk: failed to reparent gpll to clk_rtc32k_frac: -22
[   32.571259] firmware_class: See https://wiki.debian.org/Firmware for information about missing firmware
[   32.589465] ov5648 2-0036: failed to find 168000000 clk rate in endpoint link-frequencies
```
Note: The `spi-nor` msg already disappeared on a reboot, but is
irrelevant anyway. And looks like my patch (removal) wasn't complete,
but that also seems irrelevant.

I really don't like ignoring errors I see in `dmesg`. But this isn't the
first instance where I was inclined to do exactly that as the
Debian patch(es) 'upgrade' an upstream warning to an error.
And IIUC/IIRC I've also seen that several times when triaging Debian
kernel bugs, f.e. with an issue which 'rhymes' with yolo-debug.

So hereby a request to review the firmware related Debian patches to see
whether they still are the best way to solve the (initial) problem and
if not, improve on them so they will.

Cheers,
  Diederik

- -- System Information:
Debian Release: trixie/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'unstable'), (500, 'testing'), (500, 'oldstable'), (101, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 6.3.0-2-amd64 (SMP w/16 CPU threads; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

-----BEGIN PGP SIGNATURE-----

iHUEARYIAB0WIQT1sUPBYsyGmi4usy/XblvOeH7bbgUCZKsmVQAKCRDXblvOeH7b
bg0LAP43Zo91VX1KK8d7/Icsl3JerHPBmNAOskhTvGv3NkT5yAD+Obg69navr+Rw
sNgU43OHquxKFhGhlBOo1UWN+M9XNAg=
=9ctN
-----END PGP SIGNATURE-----

Back to linux.debian.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Bug#1040738: linux: Please review firmware related Debian patches Diederik de Haas <didi.debian@cknow.org> - 2023-07-09 23:40 +0200
  Bug#1040738: marked as done (linux: Please review firmware  related Debian patches) "Debian Bug Tracking System" <owner@bugs.debian.org> - 2024-06-19 17:10 +0200

csiph-web