Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.kernel > #72424

Bug#757356: Apple keyboard: Scan code event (EV_MSC) not generated when the EV_KEY event is generated by hid-apple.c

Cross-posted to 2 groups.

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

Yes, I haven't used a machine with hid_apple in many years, but the patch
sign-off is OK with me.

On Wed, Jul 21, 2021 at 10:24 AM Vincent Lefevre <vincent@vinc17.net> wrote:

> On 2021-06-02 17:24:38 +0200, Salvatore Bonaccorso wrote:
> > Hi Vincent,
> >
> > On Wed, May 26, 2021 at 12:02:12PM +0200, Vincent Lefevre wrote:
> [...]
> > > I forgot that there was
> > >
> > >   https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=757356#35
> > >
> > > from Daniel Lin, with a patch, in 2017. I've looked at this patch
> > > (but have not tried it), and it adds an additional EV_MSC event
> > > when hidinput_apple_event() has to generate an EV_KEY event. So
> > > I confirm that should solve this issue and I'm adding the patch
> > > tag (I don't know whether the patch needs an update, though).
> >
> > Can you, time permitting, starting from there (and needed refreshes)
> > try to confirm if the patch solves the issue on top of 5.10.40?
>
> I could build and test the patched kernel, and I confirm that the
> new patch at
>
>   https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=757356#75
>
> solves the issue for me.
>
> > If so, next step would be to propose the change/report the bug at
> > least, to upstream, get_maintainers.pl would suggest to report it
> > to:
> >
> > Jiri Kosina <jikos@kernel.org> (maintainer:HID CORE LAYER)
> > Benjamin Tissoires <benjamin.tissoires@redhat.com> (maintainer:HID CORE
> LAYER)
> > linux-input@vger.kernel.org (open list:HID CORE LAYER)
> > linux-kernel@vger.kernel.org (open list)
>
> Since Daniel Lin (Cc'ed for any comment) is the author of the
> original patch, I suppose that the patch should have:
>
> Co-developed-by: Daniel Lin <ephemient@gmail.com>
> Signed-off-by: Daniel Lin <ephemient@gmail.com>
> Co-developed-by: Vincent Lefevre <vincent@vinc17.net>
> Signed-off-by: Vincent Lefevre <vincent@vinc17.net>
>
> as described at
>   https://www.kernel.org/doc/html/latest/process/submitting-patches.html
>
> if this is OK for him.
>
> --
> Vincent Lefèvre <vincent@vinc17.net> - Web: <https://www.vinc17.net/>
> 100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
> Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)
>

Back to linux.debian.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Bug#757356: Scan codes still not generated for F1 to F12, Enter and Backspace Vincent Lefevre <vincent@vinc17.net> - 2021-05-26 10:00 +0200
  Bug#757356: Scan code event not generated for some keys of the Apple keyboard: those in applespi_fn_codes Vincent Lefevre <vincent@vinc17.net> - 2021-05-26 10:50 +0200
    Bug#757356: Apple keyboard: Scan code event (EV_MSC) not generated when the EV_KEY event is generated by hid-apple.c Vincent Lefevre <vincent@vinc17.net> - 2021-05-26 12:10 +0200
      Bug#757356: Apple keyboard: Scan code event (EV_MSC) not generated when the EV_KEY event is generated by hid-apple.c Salvatore Bonaccorso <carnil@debian.org> - 2021-06-02 17:30 +0200
        Bug#757356: Apple keyboard: Scan code event (EV_MSC) not generated when the EV_KEY event is generated by hid-apple.c Vincent Lefevre <vincent@vinc17.net> - 2021-07-19 17:00 +0200
        Bug#757356: Apple keyboard: Scan code event (EV_MSC) not generated when the EV_KEY event is generated by hid-apple.c Vincent Lefevre <vincent@vinc17.net> - 2021-07-21 16:30 +0200
          Bug#757356: Apple keyboard: Scan code event (EV_MSC) not generated when the EV_KEY event is generated by hid-apple.c Daniel Lin <ephemient@gmail.com> - 2021-07-22 00:40 +0200
            Bug#757356: Apple keyboard: Scan code event (EV_MSC) not generated when the EV_KEY event is generated by hid-apple.c Vincent Lefevre <vincent@vinc17.net> - 2021-07-26 16:20 +0200

csiph-web