Re: Salsa CI job 'missing-breaks' to be enabled by default starting March 1st

From	Lorenzo <plorenzo@disroot.org>
Newsgroups	linux.debian.devel
Subject	Re: Salsa CI job 'missing-breaks' to be enabled by default starting March 1st
Date	2025-03-06 14:50 +0100
Message-ID	<KnjLS-434i-7@gated-at.bofh.it> (permalink)
References	<Kk5P3-1UU0-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello Otto,

[please keep me in CC, I'm not subscribed]

> Salsa CI has had for many years the job 'missing-breaks' that
> complements piuparts by checking that the files a package introduce
> don't clash with files shipped by any other package in the
> distribution without having proper Breaks/Replaces in the
> `debian/control` file. This job works well, being quick to run and has
> had zero false positives in our experience.

In salsa CI now I see:

$ check_for_missing_breaks_replaces.py -o ${WORKING_DIR}/missing_breaks.xml --changes-file ${WORKING_DIR}/*.changes
[ERROR] Missing Breaks/Replaces found
[ERROR] runit-init conflicts with init-system-helpers files: {'/usr/share/man/man8/invoke-rc.d.8.gz', '/usr/sbin/service', '/usr/sbin/invoke-rc.d', '/usr/share/man/man8/service.8.gz'}
Uploading artifacts for failed job

this looks like false positive, file are in fact diverted. Does the test
check for for diversions?

> ## Schedule
>
> 1. March 1st: Enable this job by default, but in allow_failure mode,
> making Salsa CI yellow on packages that fail on this job
> 2. March 31st: Remove the allow_failure mode, potentially making the
> Salsa CI red for packages that fail on this job

Could you please consider delaying 2. until diversion are properly
detected?

Best Regards,
Lorenzo

Thread

Salsa CI job 'missing-breaks' to be enabled by default starting March 1st Otto Kekäläinen <otto@debian.org> - 2025-02-25 17:20 +0100
  Re: Salsa CI job 'missing-breaks' to be enabled by default starting  March 1st Guillem Jover <guillem@debian.org> - 2025-02-25 18:20 +0100
    Re: Salsa CI job 'missing-breaks' to be enabled by default starting  March 1st Arnaud Rebillout <arnaudr@debian.org> - 2025-02-26 03:10 +0100
      Re: Salsa CI job 'missing-breaks' to be enabled by default starting  March 1st Otto Kekäläinen <otto@debian.org> - 2025-02-27 02:50 +0100
  Salsa CI job 'missing-breaks' to be enabled by default starting  March 1st Simon Richter <sjr@debian.org> - 2025-02-25 18:40 +0100
  Re: Salsa CI job 'missing-breaks' to be enabled by default starting  March 1st Lorenzo <plorenzo@disroot.org> - 2025-03-06 14:50 +0100
    Re: Salsa CI job 'missing-breaks' to be enabled by default starting  March 1st NoisyCoil <noisycoil@disroot.org> - 2025-03-06 16:00 +0100
      Re: Salsa CI job 'missing-breaks' to be enabled by default starting  March 1st Bastian Blank <waldi@debian.org> - 2025-03-06 17:30 +0100
        Re: Salsa CI job 'missing-breaks' to be enabled by default starting  March 1st NoisyCoil <noisycoil@disroot.org> - 2025-03-06 17:30 +0100
          Re: Salsa CI job 'missing-breaks' to be enabled by default starting  March 1st Bastian Blank <waldi@debian.org> - 2025-03-06 18:10 +0100
            Re: Salsa CI job 'missing-breaks' to be enabled by default starting  March 1st Matthias Urlichs <matthias@urlichs.de> - 2025-03-06 18:40 +0100
              Re: Salsa CI job 'missing-breaks' to be enabled by default starting  March 1st Bastian Blank <waldi@debian.org> - 2025-03-06 20:10 +0100
                Re: Salsa CI job 'missing-breaks' to be enabled by default starting  March 1st Matthias Urlichs <matthias@urlichs.de> - 2025-03-06 21:10 +0100
    Re: Salsa CI job 'missing-breaks' to be enabled by default starting  March 1st Otto Kekäläinen <otto@debian.org> - 2025-03-06 20:00 +0100
      Re: Salsa CI job 'missing-breaks' to be enabled by default starting  March 1st Chris Hofstaedtler <zeha@debian.org> - 2025-03-06 23:10 +0100
        Re: Salsa CI job 'missing-breaks' to be enabled by default starting  March 1st Matthias Urlichs <matthias@urlichs.de> - 2025-03-07 08:30 +0100
          Re: Salsa CI job 'missing-breaks' to be enabled by default starting  March 1st Otto Kekäläinen <otto@debian.org> - 2025-03-13 00:40 +0100

csiph-web