Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.bugs.rc > #283647

Bug#966813: e2fsprogs: FTBFS with GCC 10: multiple definition of ... due to -fno-common

Show all headers | View raw

On Sun, Aug 02, 2020 at 07:23:35PM +0200, Andreas Beckmann wrote:
> 
> e2fsprogs/experimental started to FTBFS when GCC 10 was made the default compiler:
>

Thanks for the bug report.  This is fixed in e2fsprogs 1.45.6-1 by:

commit 336c440ccea8f94b0728f881cddee84f730e7cc7
Author: Lukas Czerner <lczerner@redhat.com>
Date:   Mon Feb 10 16:24:59 2020 +0100

    tst_libext2fs: Avoid multiple definition of global variables
    
    gcc version 10 changed the default from -fcommon to -fno-common and as a
    result e2fsprogs make check tests fail because tst_libext2fs.c end up
    with a build error.
    
    This is because it defines two global variables debug_prog_name and
    extra_cmds that are already defined in debugfs/debugfs.c. With -fcommon
    linker was able to resolve those into the same object, however with
    -fno-common it's no longer able to do it and we end up with multiple
    definition errors.
    
    Fix the problem by using SKIP_GLOBDEFS macro to skip the variables
    definition in debugfs.c. Note that debug_prog_name is also defined in
    lib/ext2fs/extent.c when DEBUG macro is used, but this does not work even
    with older gcc versions and is never used regardless so I am not going to
    bother with it.
    
    Signed-off-by: Lukas Czerner <lczerner@redhat.com>
    Reviewed-by: Eric Sandeen <sandeen@redhat.com>
    Signed-off-by: Theodore Ts'o <tytso@mit.edu>

It's just that the e2fsprogs/experimental hasn't been updated in a while.

The next time the e2fsprogs/experimental gets updated with a new test
version, this will no longer be a problem.

Cheers,

							- Ted

Back to linux.debian.bugs.rc | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Bug#966813: e2fsprogs: FTBFS with GCC 10: multiple definition of ... due to -fno-common Andreas Beckmann <anbe@debian.org> - 2020-08-02 19:30 +0200
  Bug#966813: e2fsprogs: FTBFS with GCC 10: multiple definition of ... due to -fno-common tytso@mit.edu - 2020-08-02 23:00 +0200

csiph-web