Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.debian.bugs.dist > #980798 > unrolled thread
| Started by | "Chris Lamb" <lamby@debian.org> |
|---|---|
| First post | 2019-10-25 11:00 +0200 |
| Last post | 2019-10-28 15:40 +0100 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.debian.bugs.dist
Bug#943471: khard: please make the build reproducible "Chris Lamb" <lamby@debian.org> - 2019-10-25 11:00 +0200
Bug#943471: khard: please make the build reproducible Félix Sipma <felix+debian@gueux.org> - 2019-10-28 14:50 +0100
Bug#943471: khard: please make the build reproducible "Chris Lamb" <lamby@debian.org> - 2019-10-28 15:30 +0100
Bug#943471: khard: please make the build reproducible Félix Sipma <felix+debian@gueux.org> - 2019-10-28 15:40 +0100
| From | "Chris Lamb" <lamby@debian.org> |
|---|---|
| Date | 2019-10-25 11:00 +0200 |
| Subject | Bug#943471: khard: please make the build reproducible |
| Message-ID | <yV3BU-7ng-7@gated-at.bofh.it> |
[Multipart message — attachments visible in raw view] — view raw
Source: khard
Version: 0.15.0-2
Severity: wishlist
Tags: patch
User: reproducible-builds@lists.alioth.debian.org
Usertags: buildpath
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org
Hi,
Whilst working on the Reproducible Builds effort [0] we noticed
that khard could not be built reproducibly.
This is because it includes the absolute build directory in the
documentation via the SPEC_FILE attribute. Patch attached that
calculates this dynamically instead.
[0] https://reproducible-builds.org/
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` lamby@debian.org / chris-lamb.co.uk
`-
[toc] | [next] | [standalone]
| From | Félix Sipma <felix+debian@gueux.org> |
|---|---|
| Date | 2019-10-28 14:50 +0100 |
| Message-ID | <yWdzc-2fu-5@gated-at.bofh.it> |
| In reply to | #980798 |
[Multipart message — attachments visible in raw view] — view raw
Hi Chris, Thanks for the report and the attached patch. Would you want to file a pull request to upstream directly? https://github.com/scheibler/khard If not, of course I can do that by myself. Regards, -- Félix
[toc] | [prev] | [next] | [standalone]
| From | "Chris Lamb" <lamby@debian.org> |
|---|---|
| Date | 2019-10-28 15:30 +0100 |
| Message-ID | <yWebT-2P7-3@gated-at.bofh.it> |
| In reply to | #980798 |
forwarded 943471 https://github.com/scheibler/khard/pull/233
thanks
Félix Sipma wrote:
> Thanks for the report and the attached patch. Would you want to file a
> pull request to upstream directly?
No problem. I've forwarded this upstream here:
https://github.com/scheibler/khard/pull/233
As part of this I noticed that the patch I previously attached was a
little bit garbled so it won't apply completely cleanly... but I think
after the above PR is merged and released you will just need to do:
--- a/debian/rules 2019-10-25 09:18:54.208690284 +0100
--- b/debian/rules 2019-10-25 09:33:48.499676643 +0100
@@ -8,5 +8,9 @@
make man
dh_auto_build
+override_dh_auto_clean:
+ dh_auto_clean
+ rm -f khard/version.py
+
… but you may need to add `tar-ignore = "*/version.py"` to debian/
source/options too, I am not quite sure right now.
Hope that helps.
Best wishes,
--
,''`.
: :' : Chris Lamb
`. `'` lamby@debian.org / chris-lamb.co.uk
`-
[toc] | [prev] | [next] | [standalone]
| From | Félix Sipma <felix+debian@gueux.org> |
|---|---|
| Date | 2019-10-28 15:40 +0100 |
| Message-ID | <yWelz-2Sv-9@gated-at.bofh.it> |
| In reply to | #981267 |
[Multipart message — attachments visible in raw view] — view raw
On 2019-10-28 14:19+0000, Chris Lamb wrote: > No problem. I've forwarded this upstream here: > > https://github.com/scheibler/khard/pull/233 > > As part of this I noticed that the patch I previously attached was a > little bit garbled so it won't apply completely cleanly... but I think > after the above PR is merged and released you will just need to do: > > --- a/debian/rules 2019-10-25 09:18:54.208690284 +0100 > --- b/debian/rules 2019-10-25 09:33:48.499676643 +0100 > @@ -8,5 +8,9 @@ > make man > dh_auto_build > > +override_dh_auto_clean: > + dh_auto_clean > + rm -f khard/version.py > + > > … but you may need to add `tar-ignore = "*/version.py"` to debian/ > source/options too, I am not quite sure right now. > > Hope that helps. > > Best wishes, OK, I'll keep this in mind. Thanks again, -- Félix
[toc] | [prev] | [standalone]
Back to top | Article view | linux.debian.bugs.dist
csiph-web