Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.bugs.dist > #908897 > unrolled thread

Bug#904308: test suite: git invokes $EDITOR/$VISUAL/sensible-editor

Started bySean Whitton <spwhitton@spwhitton.name>
First post2018-07-23 08:40 +0200
Last post2018-07-23 11:50 +0200
Articles 6 — 2 participants

Back to article view | Back to linux.debian.bugs.dist

Contents

  Bug#904308: test suite: git invokes $EDITOR/$VISUAL/sensible-editor Sean Whitton <spwhitton@spwhitton.name> - 2018-07-23 08:40 +0200
    Bug#904308: test suite: git invokes $EDITOR/$VISUAL/sensible-editor Ian Jackson <ijackson@chiark.greenend.org.uk> - 2018-07-23 11:40 +0200
    Bug#904308: test suite: git invokes $EDITOR/$VISUAL/sensible-editor Ian Jackson <ijackson@chiark.greenend.org.uk> - 2018-07-23 11:40 +0200
    Bug#904308: [PATCH] test suite: unset VISUAL, which interferes. Ian Jackson <ijackson@chiark.greenend.org.uk> - 2018-07-23 11:50 +0200
      Bug#904308: [PATCH] test suite: unset VISUAL, which interferes. Sean Whitton <spwhitton@spwhitton.name> - 2018-07-24 05:10 +0200
    Bug#904308: [PATCH] test suite: unset EDITOR, which interferes. Ian Jackson <ijackson@chiark.greenend.org.uk> - 2018-07-23 11:50 +0200

#908897 — Bug#904308: test suite: git invokes $EDITOR/$VISUAL/sensible-editor

FromSean Whitton <spwhitton@spwhitton.name>
Date2018-07-23 08:40 +0200
SubjectBug#904308: test suite: git invokes $EDITOR/$VISUAL/sensible-editor
Message-ID<weCFI-4fs-15@gated-at.bofh.it>

[Multipart message — attachments visible in raw view] — view raw

Source: dgit
Version: 5.10

When the test suite runs the user's configured editor can be invoked.
This can pop up new X windows and sometimes tests will fail.  Sometimes
it is git that is invoking the editor:

    + git commit
    Waiting for Emacs...*ERROR*: Quit

    error: There was a problem with the editor 'emacsclient -amg -c'.
    Please supply the message using either -m or -F option.
    + test 1 = 0
    + t-report-failure
    + set +x
    TEST FAILED
    cwd: /home/spwhitton/src/dgit/tests/tmp/overwrite-chkclog/example
    funcs: t-report-failure main
    lines: 1 0
    files: tests/lib tests/tests/overwrite-chkclog

And sometimes, it seems, dpkg-source (following output was with
EDITOR=nano VISUAL=nano):

    + pname=gitattrs
    + cat
    + EDITOR='perl -pi /home/spwhitton/src/dgit/tests/tmp/gitattributes/editor.pl'
    + dpkg-source -iX --commit . gitattrs
    dpkg-source: info: local changes detected, the modified files are:
     example.quilt-edit/.gitattributes
    .[?1049h.[1;24r.[m.[4l.[?7h.[?1h.=.[?1h.=.[?1h.=.[39;49m.[?25l.[39;49m.[m.[H.[2J.[22;33H.[0;7m[ Reading File ].[m.[22;32H.[0;7m[ Read 182 lines ].[m.[H.[39;49m.[0;7m  GNU nano 2.7.4   File: example.quilt-edit/debian/patches/gitattrs             .[3;1H.[mDescription: <short summary of the patch>. TODO: Put a short summary on the line above and replace this paragraph. with a longer explanation of this change. Complete the meta-information. with other relevant fields (see below for details). To make it easier, the. information below has been extracted from the changelog. Adjust it or drop. it.. ..[10dexample (1.0-1) UNRELEASED; urgency=medium. ..[12d * convert.Author: Ian Jackson <ijackson@chiark.greenend.org.uk>.---.The information above should follow the Patch Tagging Guidelines, please.checkout http://dep.debian.net/deps/dep3/ to learn about the format. Here.are templates for supplementary fields that you might want to add:.Origin: <vendor|upstream|other>, <url of original patch>.Bug: <url in upstream bugtracker>..[0;7m^G.[m Get Help  .[0;7m^O.[m Write Out .[0;7m^W.[m Where Is  .[0;7m^K.[m Cut Text  .[0;7m^J.[m Justify   .[0;7m^C.[m Cur Pos..[0;7m^X.[m Exit.[14G.[0;7m^R.[m Read File .[0;7m^\.[m Replace   .[0;7m^U.[m Uncut Text.[0;7m^T.[m To Spell  .[0;7m^_.[m Go To Line..[?12l.[?25h.[3d.[24;1H.[?1049l.[?1l.>Received SIGHUP or SIGTERM
    dpkg-source: error: sensible-editor gave error exit status 1
    + test 2 = 0
    + t-report-failure
    + set +x
    TEST FAILED
    cwd: /home/spwhitton/src/dgit/tests/tmp/gitattributes/example.quilt-edit
    funcs: t-report-failure quilt_addpatch sfmt_setup main
    lines: 1 105 241 0
    files: tests/lib tests/tests/gitattributes tests/tests/gitattributes tests/tests/gitattributes

It's pretty annoying to have new emacs frames popping up / the buffer
you are looking at switching to some temporary test suite file.

-- 
Sean Whitton

[toc] | [next] | [standalone]

#908920

FromIan Jackson <ijackson@chiark.greenend.org.uk>
Date2018-07-23 11:40 +0200
Message-ID<weFtU-64F-7@gated-at.bofh.it>
In reply to#908897
Ian Jackson writes ("Re: Bug#904308: test suite: git invokes $EDITOR/$VISUAL/sensible-editor"):
> Can you please send me the output of
>    printenv | sort
> ?

Never mind.  The problem is that a couple of the tests set EDITOR but
do not set VISUAL.  So it will run your VISUAL if you have one.

You can work around this bug by not setting VISUAL.  Nowadays I don't
think there is any difference between EDITOR and VISUAL.

Ian.

-- 
Ian Jackson <ijackson@chiark.greenend.org.uk>   These opinions are my own.

If I emailed you from an address @fyvzl.net or @evade.org.uk, that is
a private address which bypasses my fierce spamfilter.

[toc] | [prev] | [next] | [standalone]

#908922

FromIan Jackson <ijackson@chiark.greenend.org.uk>
Date2018-07-23 11:40 +0200
Message-ID<weFtU-64F-9@gated-at.bofh.it>
In reply to#908897
Sean Whitton writes ("Bug#904308: test suite: git invokes $EDITOR/$VISUAL/sensible-editor"):
> Source: dgit
> Version: 5.10
> 
> When the test suite runs the user's configured editor can be invoked.
> This can pop up new X windows and sometimes tests will fail.  Sometimes
> it is git that is invoking the editor:

Can you please send me the output of
   printenv | sort
?

Ian.

[toc] | [prev] | [next] | [standalone]

#908924 — Bug#904308: [PATCH] test suite: unset VISUAL, which interferes.

FromIan Jackson <ijackson@chiark.greenend.org.uk>
Date2018-07-23 11:50 +0200
SubjectBug#904308: [PATCH] test suite: unset VISUAL, which interferes.
Message-ID<weFDA-68B-5@gated-at.bofh.it>
In reply to#908897
Ian Jackson writes ("[PATCH] test suite: unset EDITOR, which interferes."):
> Closes:#904308.

The Subject line of this patch was wrong but I think the code is
right.

Sean, can you test it please ?

Ian.

[toc] | [prev] | [next] | [standalone]

#909095 — Bug#904308: [PATCH] test suite: unset VISUAL, which interferes.

FromSean Whitton <spwhitton@spwhitton.name>
Date2018-07-24 05:10 +0200
SubjectBug#904308: [PATCH] test suite: unset VISUAL, which interferes.
Message-ID<weVS1-fW-5@gated-at.bofh.it>
In reply to#908924

[Multipart message — attachments visible in raw view] — view raw

Hello,

On Mon 23 Jul 2018 at 10:43AM +0100, Ian Jackson wrote:

> Sean, can you test it please ?

Works.  Thanks!

-- 
Sean Whitton

[toc] | [prev] | [next] | [standalone]

#908926 — Bug#904308: [PATCH] test suite: unset EDITOR, which interferes.

FromIan Jackson <ijackson@chiark.greenend.org.uk>
Date2018-07-23 11:50 +0200
SubjectBug#904308: [PATCH] test suite: unset EDITOR, which interferes.
Message-ID<weFDA-68B-7@gated-at.bofh.it>
In reply to#908897
Closes:#904308.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
---
 debian/changelog | 2 +-
 tests/lib        | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/debian/changelog b/debian/changelog
index 1d496bbc..c1ab7e75 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,6 +1,6 @@
 dgit (5.11~) unstable; urgency=medium
 
-  * 
+  * test suite: unset EDITOR, which interferes.  Closes:#904308.
 
  --
 
diff --git a/tests/lib b/tests/lib
index 99345ce1..2771252b 100644
--- a/tests/lib
+++ b/tests/lib
@@ -64,6 +64,7 @@ env -0 >$tmp/.save-env
 ln -f $troot/ssh ssh
 
 export DEBCHANGE_VENDOR=dpkg
+unset VISUAL
 
 mkdir -p $tmp/incoming
 cat <<END >$tmp/dput.cf
-- 
2.11.0

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.bugs.dist

csiph-web