Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.bugs.dist > #880112 > unrolled thread

Bug#889740: thunderbird: Faulty apparmor configuration

Back to article view | Back to linux.debian.bugs.dist

Contents

  Bug#889740: thunderbird: Faulty apparmor configuration Christoph Pleger <christoph.pleger@cs.uni-dortmund.de> - 2018-02-06 17:10 +0100
    Bug#889740: Info received (Bug#889740: thunderbird: Faulty apparmor configuration) Marcin Owsiany <marcin@owsiany.pl> - 2018-02-07 07:40 +0100
    Bug#889740: thunderbird: Faulty apparmor configuration Marcin Owsiany <marcin@owsiany.pl> - 2018-02-07 07:40 +0100
    Bug#889740: xmotd: crashes when built with hardening Christoph Pleger <christoph.pleger@cs.uni-dortmund.de> - 2018-02-13 12:50 +0100
    Bug#889740: xmotd: crashes when built with hardening Hugo Lefeuvre <hle@debian.org> - 2018-02-18 10:40 +0100

#880112 — Bug#889740: thunderbird: Faulty apparmor configuration

Package: xmotd
Version: 1.17.3b-9

Dear maintainers,

on several Debian 9 computers, the stretch version of xmotd crashed 
every time with the following error message:

xmotd: Bad address

Then, I installed version 1.17.3b-8 from oldstable, which did not crash. 
Then, I built from source, which gave the following results:

1. Neither 1.17.3b-8 nor 1.17.3b-9 work if compiled under stretch.

2. Version 1.17.3b-8 works if compiled under jessie.

3. Version 1.17.3b-9 works if compiled under jessie AND hardening flags 
are removed from debian/rules.

Regards
   Christoph

[toc] | [next] | [standalone]

#880340 — Bug#889740: Info received (Bug#889740: thunderbird: Faulty apparmor configuration)

[Multipart message — attachments visible in raw view] — view raw

FTR https://qa.debian.org/bls/packages/x/xmotd.html summarizes them nicely.

[toc] | [prev] | [next] | [standalone]

#880341

[Multipart message — attachments visible in raw view] — view raw

The issue is caused by lack of getTimeStampName declaration in xmotd.c. The
implicit declaration assumed instead causes the pointer to buf to be cast
to an int, in turn causing some truncation of bits which are non-zero in
this case of a static buffer placed in a far location in address space
(probably in some special section when hardening is used). utime() detects
this and returns EFAULT.

The build log shows plenty of warnings, some of which might have a similar
effect.

[toc] | [prev] | [next] | [standalone]

#881315 — Bug#889740: xmotd: crashes when built with hardening

[Multipart message — attachments visible in raw view] — view raw

Hello,

so, I suggest the attached patch for a solution. It removes most compile 
time warnings and makes xmotd to not crash (tested on stretch amd64).

Regards
   Christoph

[toc] | [prev] | [next] | [standalone]

#882265 — Bug#889740: xmotd: crashes when built with hardening

[Multipart message — attachments visible in raw view] — view raw

I've had a look at your patch, looks fine to me.

Thanks !

Cheers,
 Hugo

-- 
             Hugo Lefeuvre (hle)    |    www.owl.eu.com
4096/ 9C4F C8BF A4B0 8FC5 48EB 56B8 1962 765B B9A8 BACA

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.bugs.dist

csiph-web