Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.debian.bugs.dist > #875375 > unrolled thread

Bug#887345: BIRD should be part of "network.target"

Started byVincent Bernat <bernat@debian.org>
First post2018-01-15 11:40 +0100
Last post2018-01-15 17:30 +0100
Articles 5 — 2 participants

Back to article view | Back to linux.debian.bugs.dist


Contents

  Bug#887345: BIRD should be part of "network.target" Vincent Bernat <bernat@debian.org> - 2018-01-15 11:40 +0100
    Bug#887345: BIRD should be part of "network.target" Vincent Bernat <bernat@debian.org> - 2018-01-15 12:20 +0100
      Bug#887345: BIRD should be part of "network.target" Vincent Bernat <bernat@debian.org> - 2018-01-15 17:00 +0100
      Bug#887345: BIRD should be part of "network.target" Ondrej Zajicek <santiago@crfreenet.org> - 2018-01-15 17:20 +0100
        Bug#887345: BIRD should be part of "network.target" Vincent Bernat <bernat@debian.org> - 2018-01-15 17:30 +0100

#875375 — Bug#887345: BIRD should be part of "network.target"

FromVincent Bernat <bernat@debian.org>
Date2018-01-15 11:40 +0100
SubjectBug#887345: BIRD should be part of "network.target"
Message-ID<v8alj-eV-3@gated-at.bofh.it>
Package: bird
Version: 1.6.3-3
Severity: normal

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hey!

On shutdown, BIRD is stopped early due to "After=network.target". This
is troublesome when other services need the network to correctly
stop. I am unsure of the right fix. Maybe:

[Unit]
Before=network.target

[Install]
WantedBy=network-online.target

The "network.target" is mostly used on shutdown and BIRD would start
correctly even when no interface is correctly configured (but the
router ID may be guessed incorrectly in this case). The
"network-online.target" is mostly used on startup and would ensure
routing is correctly setup on boot.

- -- System Information:
Debian Release: buster/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'unstable'), (101, 'experimental-debug'), (101, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.14.0-3-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.utf8, LC_CTYPE=fr_FR.utf8 (charmap=UTF-8), LANGUAGE=fr_FR.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages bird depends on:
ii  adduser              3.116
ii  init-system-helpers  1.51
ii  libc6                2.26-4
ii  libreadline7         7.0-3
ii  libtinfo5            6.0+20171125-1
ii  ucf                  3.0036

bird recommends no packages.

Versions of packages bird suggests:
ii  bird-doc  1.6.3-3

- -- Configuration Files:
/etc/bird/bird.conf [Errno 13] Permission denied: '/etc/bird/bird.conf'
/etc/bird/bird6.conf [Errno 13] Permission denied: '/etc/bird/bird6.conf'
/etc/bird/envvars [Errno 13] Permission denied: '/etc/bird/envvars'

- -- no debconf information

-----BEGIN PGP SIGNATURE-----

iQJGBAEBCAAwFiEErvI0h2bzccaJpzYAlaQv6DU1JfkFAlpcgkESHGJlcm5hdEBk
ZWJpYW4ub3JnAAoJEJWkL+g1NSX5GosP/0qPrIocW3tJblDkHdFpyFuOIHGeFEzp
gadD2lkJ0QB44i1ic8TPF44o8KI+509s/4gYnX44q6xEAfNiIZ4j4SQUZn4r80WP
4Cbax06WpIiao9aCJ/vasGtpExW2JGBpnSqxDGOies6am/nss8X4scHti1CoXWDI
pkpflTwMvX8gqYowHApQOmWMn1F4qIWmk0a3hwc1HyFfeH0ITXzKnsVF4DElAm0B
f39w81HmavrVjJdspOp62GT/UtUEpiLh9gleno4zW+26HaGhT1ntM/FqHOLT+NlV
nSp5WpAFYVXJXYSDFZlUzydVNeP9hLamfeLora0Lf+JWc+zBv/6ES67rTsztVbIp
DXExnU8AUPq+MkK2w2TLD4xG6umaGhSwmInwJ2uy76ZMHv7kG19ibGmjj9KkIE4z
tERW07N8rWfOOQtWU3zg35uMlvTcGx/zf9Xd9ltHVqKGEovdDjyYrFV5NZtPtL1l
jDaT3VObjyWFd+hFzFjXRXtFA+7Z/EnY5MiwOwY8wXDFs59wX1VAjKfaEzgCBfZm
pDBtO3XQf4sZ9Ytg0nZJxc00q6teC4/E6AD+H+W+hsSleaQ/hqNSFAJgqyN0OetD
2tAiaT/uur83VUrhrYbZ6PnKm0j4diPk/yzSeQ5josPoqaUdRl3jRfjjMvG+AJSD
v4xojzPJbDvb
=jEqF
-----END PGP SIGNATURE-----

[toc] | [next] | [standalone]


#875391

FromVincent Bernat <bernat@debian.org>
Date2018-01-15 12:20 +0100
Message-ID<v8aY1-Me-11@gated-at.bofh.it>
In reply to#875375

[Multipart message — attachments visible in raw view] — view raw

 ❦ 15 janvier 2018 11:28 +0100, Vincent Bernat <bernat@debian.org> :

> On shutdown, BIRD is stopped early due to "After=network.target". This
> is troublesome when other services need the network to correctly
> stop. I am unsure of the right fix. Maybe:
[...]

A better solution (for me) would be:

[Unit]
Description=BIRD Internet Routing Daemon (IPv4)
After=network-pre.target systemd-sysctl.service systemd-udevd.service
Before=network.target multi-user.target shutdown.target
Conflicts=shutdown.target
Wants=network.target
DefaultDependencies=no

However, it should be noted that makes BIRD start really early (IP may
not even have been configured, which is troublesome for implicit router
ID). Also, we may miss other dependencies (syslog, /var). After
discussing it on #debian-devel, this kind of configuration doesn't get
many votes.
-- 
All generalizations are false, including this one.
		-- Mark Twain

[toc] | [prev] | [next] | [standalone]


#875473

FromVincent Bernat <bernat@debian.org>
Date2018-01-15 17:00 +0100
Message-ID<v8fl1-3AR-33@gated-at.bofh.it>
In reply to#875391

[Multipart message — attachments visible in raw view] — view raw

 ❦ 15 janvier 2018 12:12 +0100, Vincent Bernat <bernat@debian.org> :

>> On shutdown, BIRD is stopped early due to "After=network.target". This
>> is troublesome when other services need the network to correctly
>> stop. I am unsure of the right fix. Maybe:
> [...]
>
> A better solution (for me) would be:
>
> [Unit]
> Description=BIRD Internet Routing Daemon (IPv4)
> After=network-pre.target systemd-sysctl.service systemd-udevd.service
> Before=network.target multi-user.target shutdown.target
> Conflicts=shutdown.target
> Wants=network.target
> DefaultDependencies=no
>
> However, it should be noted that makes BIRD start really early (IP may
> not even have been configured, which is troublesome for implicit router
> ID). Also, we may miss other dependencies (syslog, /var). After
> discussing it on #debian-devel, this kind of configuration doesn't get
> many votes.

As there is not much to do with this bug, feel free to close it if you
feel there is no obvious solution.
-- 
An honest tale speeds best being plainly told.
		-- William Shakespeare, "Henry VI"

[toc] | [prev] | [next] | [standalone]


#875476

FromOndrej Zajicek <santiago@crfreenet.org>
Date2018-01-15 17:20 +0100
Message-ID<v8fEl-3Zw-3@gated-at.bofh.it>
In reply to#875391
On Mon, Jan 15, 2018 at 12:12:30PM +0100, Vincent Bernat wrote:
>  ❦ 15 janvier 2018 11:28 +0100, Vincent Bernat <bernat@debian.org> :
> 
> > On shutdown, BIRD is stopped early due to "After=network.target". This
> > is troublesome when other services need the network to correctly
> > stop. I am unsure of the right fix. Maybe:
> [...]
> 
> A better solution (for me) would be:
> 
> [Unit]
> Description=BIRD Internet Routing Daemon (IPv4)
> After=network-pre.target systemd-sysctl.service systemd-udevd.service
> Before=network.target multi-user.target shutdown.target
> Conflicts=shutdown.target
> Wants=network.target
> DefaultDependencies=no
> 
> However, it should be noted that makes BIRD start really early (IP may
> not even have been configured, which is troublesome for implicit router
> ID). Also, we may miss other dependencies (syslog, /var). After
> discussing it on #debian-devel, this kind of configuration doesn't get
> many votes.

Just a question, how this problem is handled by daemons in similar
position, like hostapd or wpasupplicant?

-- 
Elen sila lumenn' omentielvo

Ondrej 'Santiago' Zajicek (email: santiago@crfreenet.org)
OpenPGP encrypted e-mails preferred (KeyID 0x11DEADC3, wwwkeys.pgp.net)
"To err is human -- to blame it on a computer is even more so."

[toc] | [prev] | [next] | [standalone]


#875477

FromVincent Bernat <bernat@debian.org>
Date2018-01-15 17:30 +0100
Message-ID<v8fO1-431-1@gated-at.bofh.it>
In reply to#875476

[Multipart message — attachments visible in raw view] — view raw

 ❦ 15 janvier 2018 17:03 +0100, Ondrej Zajicek <santiago@crfreenet.org> :

>> A better solution (for me) would be:
>> 
>> [Unit]
>> Description=BIRD Internet Routing Daemon (IPv4)
>> After=network-pre.target systemd-sysctl.service systemd-udevd.service
>> Before=network.target multi-user.target shutdown.target
>> Conflicts=shutdown.target
>> Wants=network.target
>> DefaultDependencies=no
>> 
>> However, it should be noted that makes BIRD start really early (IP may
>> not even have been configured, which is troublesome for implicit router
>> ID). Also, we may miss other dependencies (syslog, /var). After
>> discussing it on #debian-devel, this kind of configuration doesn't get
>> many votes.
>
> Just a question, how this problem is handled by daemons in similar
> position, like hostapd or wpasupplicant?

They use something similar as the proposed solution.

[Unit]
Description=WPA supplicant daemon (interface-specific version)
Requires=sys-subsystem-net-devices-%i.device
After=sys-subsystem-net-devices-%i.device
Before=network.target
Wants=network.target

I just noticed that Quagga is using something similar too:

[Unit]
Description=GNU Zebra routing manager
Wants=network.target
Before=network.target
After=network-pre.target

openvswitch:

[Unit]
Description=Open vSwitch
Before=network.target network.service
After=network-pre.target ovsdb-server.service ovs-vswitchd.service
PartOf=network.target

ndisc:

[Unit]
Description=IPv6 Recursive DNS Server discovery Daemon
Documentation=man:rdnssd(8)
Before=network.target
Requires=network.target

So, maybe just:

[Unit]
Description=BIRD Internet Routing Daemon (IPv4)
Before=network.target
Wants=network.target
After=network-pre.target

But again, I think there is no guarantee interfaces have been
configured.
-- 
Write and test a big program in small pieces.
            - The Elements of Programming Style (Kernighan & Plauger)

[toc] | [prev] | [standalone]


Back to top | Article view | linux.debian.bugs.dist


csiph-web