Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.debian.bugs.dist > #871883 > unrolled thread

Bug#885726: golang-github-hashicorp-go-sockaddr: Source includes "cmd/sockaddr/vendor/vendor.json" listed in Files-Excluded header

Started byChris Lamb <lamby@debian.org>
First post2017-12-29 16:40 +0100
Last post2017-12-30 15:30 +0100
Articles 4 — 2 participants

Back to article view | Back to linux.debian.bugs.dist


Contents

  Bug#885726: golang-github-hashicorp-go-sockaddr: Source includes "cmd/sockaddr/vendor/vendor.json" listed in Files-Excluded header Chris Lamb <lamby@debian.org> - 2017-12-29 16:40 +0100
    Bug#885726: [pkg-go] Bug#885726: golang-github-hashicorp-go-sockaddr: Source includes "cmd/sockaddr/vendor/vendor.json" listed in Files-Excluded header Martín Ferrari <tincho@tincho.org> - 2017-12-30 13:00 +0100
      Bug#885726: [pkg-go] Bug#885726: golang-github-hashicorp-go-sockaddr: Source includes "cmd/sockaddr/vendor/vendor.json" listed in Files-Excluded header Chris Lamb <lamby@debian.org> - 2017-12-30 13:10 +0100
        Bug#885726: [pkg-go] Bug#885726: golang-github-hashicorp-go-sockaddr: Source includes "cmd/sockaddr/vendor/vendor.json" listed in Files-Excluded header Martín Ferrari <tincho@tincho.org> - 2017-12-30 15:30 +0100

#871883 — Bug#885726: golang-github-hashicorp-go-sockaddr: Source includes "cmd/sockaddr/vendor/vendor.json" listed in Files-Excluded header

FromChris Lamb <lamby@debian.org>
Date2017-12-29 16:40 +0100
SubjectBug#885726: golang-github-hashicorp-go-sockaddr: Source includes "cmd/sockaddr/vendor/vendor.json" listed in Files-Excluded header
Message-ID<v24Vk-1tK-17@gated-at.bofh.it>
Source: golang-github-hashicorp-go-sockaddr
Version: 0.0~git20170627.41949a1+ds-1
Severity: important
User: lamby@debian.org
Usertags: files-excluded

Dear Maintainer,

golang-github-hashicorp-go-sockaddr lists "cmd/sockaddr/vendor/*" in the Files-Excluded field
in debian/copyright but the source tree contains cmd/sockaddr/vendor/vendor.json.

This might be a DFSG violation, the referenced files are probably not
attributed in debian/copyright or the upstream tarball was simply not
repacked as intended. Alternatively, the field is simply out of date.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[toc] | [next] | [standalone]


#872128 — Bug#885726: [pkg-go] Bug#885726: golang-github-hashicorp-go-sockaddr: Source includes "cmd/sockaddr/vendor/vendor.json" listed in Files-Excluded header

FromMartín Ferrari <tincho@tincho.org>
Date2017-12-30 13:00 +0100
SubjectBug#885726: [pkg-go] Bug#885726: golang-github-hashicorp-go-sockaddr: Source includes "cmd/sockaddr/vendor/vendor.json" listed in Files-Excluded header
Message-ID<v2nXX-5NH-1@gated-at.bofh.it>
In reply to#871883
On 29/12/17 16:28, Chris Lamb wrote:

> golang-github-hashicorp-go-sockaddr lists "cmd/sockaddr/vendor/*" in the Files-Excluded field
> in debian/copyright but the source tree contains cmd/sockaddr/vendor/vendor.json.
> 
> This might be a DFSG violation, the referenced files are probably not
> attributed in debian/copyright or the upstream tarball was simply not
> repacked as intended. Alternatively, the field is simply out of date.

The vendor.json is an autogenerated file that keeps versions (commit
hashes and dates) of every vendored dependency. I usually keep it around
for reference, as it is very useful when things break. I really don't
see much the point of removing it, or making a very complicated
files-excluded field. Also, how can it be a DFSG violation?


-- 
Martín Ferrari (Tincho)

[toc] | [prev] | [next] | [standalone]


#872131 — Bug#885726: [pkg-go] Bug#885726: golang-github-hashicorp-go-sockaddr: Source includes "cmd/sockaddr/vendor/vendor.json" listed in Files-Excluded header

FromChris Lamb <lamby@debian.org>
Date2017-12-30 13:10 +0100
SubjectBug#885726: [pkg-go] Bug#885726: golang-github-hashicorp-go-sockaddr: Source includes "cmd/sockaddr/vendor/vendor.json" listed in Files-Excluded header
Message-ID<v2o7D-67I-11@gated-at.bofh.it>
In reply to#872128
Hi Martín,

> Also, how can it be a DFSG violation?

It was just an entirely-generic list of possible problems, don't
worry.

> I really don't see much the point of removing it, or making a very complicated
> files-excluded field.

Mmm. I have a rough plan to make this an autoreject Lintian tag, so that
would be problematic here. :)

Would something like (untested) "cmd/sockaddr/vendor/*/*" not work, ooi?


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

[toc] | [prev] | [next] | [standalone]


#872146 — Bug#885726: [pkg-go] Bug#885726: golang-github-hashicorp-go-sockaddr: Source includes "cmd/sockaddr/vendor/vendor.json" listed in Files-Excluded header

FromMartín Ferrari <tincho@tincho.org>
Date2017-12-30 15:30 +0100
SubjectBug#885726: [pkg-go] Bug#885726: golang-github-hashicorp-go-sockaddr: Source includes "cmd/sockaddr/vendor/vendor.json" listed in Files-Excluded header
Message-ID<v2qj8-7vC-5@gated-at.bofh.it>
In reply to#872131
On 30/12/17 13:06, Chris Lamb wrote:

>> Also, how can it be a DFSG violation?

> It was just an entirely-generic list of possible problems, don't
> worry.

Ah, OK.

>> I really don't see much the point of removing it, or making a very complicated
>> files-excluded field.
> 
> Mmm. I have a rough plan to make this an autoreject Lintian tag, so that
> would be problematic here. :)
> 
> Would something like (untested) "cmd/sockaddr/vendor/*/*" not work, ooi?

I guess.. Also, we should probably remove that field from most packages,
since we have decided to use upstream git history, and repack on git, so
there is no real usage for it --except documentation.


-- 
Martín Ferrari (Tincho)

[toc] | [prev] | [standalone]


Back to top | Article view | linux.debian.bugs.dist


csiph-web