Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.bugs.dist > #1260561 > unrolled thread

Bug#1114691: dependency relationship is upsetting dak

Back to article view | Back to linux.debian.bugs.dist

Contents

  Bug#1114691: dependency relationship is upsetting dak Paul Tagliamonte <paultag@debian.org> - 2025-09-08 20:20 +0200
    Bug#1114691: moreinfo Paul Tagliamonte <paultag@debian.org> - 2025-09-08 20:20 +0200
    Bug#1114691: retitle, some investigation Paul Tagliamonte <paultag@debian.org> - 2025-09-09 05:30 +0200
    Bug#1114691: trailing comma in Build-Depends* causes dak to error globally Paul Tagliamonte <paultag@debian.org> - 2025-09-09 05:40 +0200
    Bug#1114691: trailing comma in Build-Depends* causes dak to error globally Paul Tagliamonte <paultag@debian.org> - 2025-09-09 18:10 +0200

#1260561 — Bug#1114691: dependency relationship is upsetting dak

[Multipart message — attachments visible in raw view] — view raw

Package: hdf5
Severity: normal
User: paultag@debian.org
Usertags: ftp
X-Debbugs-CC: ftpmaster@ftp-master.debian.org
thanks

Hello, maintainer!

I'm sorry in advance for this bug report, it's not very actionable, and 
it needs some followup, perhaps from the ftpteam.

Recently[1], something channged with the hdf5 package where it changed a 
dependency line enough to confuse dak -- the debian archive itself.

I have not had a second to triage this beyond "dget recent changes and 
look by eye at things". Nothing looks bad by eye at first glance; so 
this needs some triaging.

I *think* trailing commas are valid? I didn't recall seeing anything 
else - I also haven't had a chance to look into the .debs, yet.

This shows up whenever we invoke dak on ftp-master.d.o; a line shows up 
like this:

| Checking reverse dependencies...
| Error for source hdf5: Problem Parsing Dependency
| No dependency problem found.

I'm not sure if this is a bug in dak or the hdf5 package, but i'm going 
to file it here to start, since I didn't see anything passby.

Thanks for your hard work!
   Paul, with his ftp-team hat half-on

[1]: since the last time I was in the RM queue

-- 
   ⢀⣴⠾⠻⢶⣦⠀               Paul Tagliamonte <paultag>
   ⣾⠁⢠⠒⠀⣿⡁  https://people.debian.org/~paultag | https://pault.ag/
   ⢿⡄⠘⠷⠚⠋        Debian, the universal operating system.
   ⠈⠳⣄⠀⠀  4096R / FEF2 EB20 16E6 A856 B98C  E820 2DCD 6B5D E858 ADF3

[toc] | [next] | [standalone]

#1260562 — Bug#1114691: moreinfo

[Multipart message — attachments visible in raw view] — view raw

lol, it even shows up in the cruft-report

will try and find cycles for this

[1]: https://ftp-master.debian.org/cruft-report-daily.txt

-- 
   ⢀⣴⠾⠻⢶⣦⠀               Paul Tagliamonte <paultag>
   ⣾⠁⢠⠒⠀⣿⡁  https://people.debian.org/~paultag | https://pault.ag/
   ⢿⡄⠘⠷⠚⠋        Debian, the universal operating system.
   ⠈⠳⣄⠀⠀  4096R / FEF2 EB20 16E6 A856 B98C  E820 2DCD 6B5D E858 ADF3

[toc] | [prev] | [next] | [standalone]

#1260611 — Bug#1114691: retitle, some investigation

[Multipart message — attachments visible in raw view] — view raw

retitle 1114691 trailing comma in Build-Depends* causes dak to error globally
affects 1114691 ftp.debian.org
thanks

I dug into this, here's what I know now.

When we do a dak rm, dak will load the archive dependencies to detect 
breakage. It does this by SELECT-ing source_metadata (basically, the 
keys from a parsed deb822 dsc), source (the source version itself),
and newest_src_association (newest source for a sutie).

Long story short what is _basically_ this SQL is run:

```
SELECT s.source, string_agg(sm.value, ', ') as build_dep
   FROM source s
   JOIN source_metadata sm ON s.id = sm.src_id
   WHERE s.id = 976181
     AND sm.key_id IN (18, 8)
   GROUP BY s.id, s.source
```

Where "s.id = 976181" is the hdf5 in sid, and the "(18, 8)" are the 
metadata fields "Build-Depends" and "Build-Depends-Indep", respectively.

The intent of this code is to create a single Dependency line comprised 
of both B-D and B-D-I, which it concats using string_agg with ", ".

You can maybe see where this is going by now :)

The output of that SQL is:

|  hdf5   | debhelper (>= 10~), mpi-default-dev, libopenmpi-dev [!armel !armhf !any-i386 !hppa !m68k !powerpc !sh4 !x32], libmpich-dev, zlib1g-dev, libjpeg-dev, gfortran, sharutils, chrpath, libaec-dev, libcurl4-openssl-dev, libssl-dev, default-jdk-headless (>= 2:1.7) [!hppa !hurd-any] <!nojava>, javahelper [!hppa !hurd-any] <!nojava>, junit4 [!hppa !hurd-any] <!nojava>, libslf4j-java [!hppa !hurd-any] <!nojava>, libopenmpi-dev (>= 5.0.8-6.1) [ppc64el],, doxygen, php-cli
| (1 row)

I'm sure everyone's guessed by now, but just to spell it out, While 
"foo," is accepted by the Python apt_pkg module, "foo,, bar" is not.

There are a few places where this could have been avoided:

   1) humans working with d/control can take steps to ensure there are 
      not trailing commas.

   2) dpkg could strip trailing commas when it generates the dsc, like it 
      does with dependencies for binaries in debs

   3) dak could strip trailing commas on the way into the table

   4) the sql query above could handle a trailing comma gracefully

I think #1 is perhaps unhelpful, since other tooling handles trailing 
commas well. Similarly, I'm not convinced #3 is a good idea. Mangling 
the contents of a dsc into the archive db seems like a real bad idea.

I think there's a good case to be made that #2 is a prudent idea, 
although, nothing stops people from creating dscs like this by hand or 
using a different tool.

#4 seems like the obvious next step, since we've already got this 
package in the archive, and the string handling here is acutely to 
blame.

Something like, perhaps:

   replace(string_agg(sm.value, ', '), ',,', ',')

Since anything other than a trailing "," here would be invalid basically 
everywhere, so seeing a ",,," is asotonishingly unlikely.

I'll send up a PR for review soon :tm:

   paultag, without any hats on this time

-- 
   ⢀⣴⠾⠻⢶⣦⠀               Paul Tagliamonte <paultag>
   ⣾⠁⢠⠒⠀⣿⡁  https://people.debian.org/~paultag | https://pault.ag/
   ⢿⡄⠘⠷⠚⠋        Debian, the universal operating system.
   ⠈⠳⣄⠀⠀  4096R / FEF2 EB20 16E6 A856 B98C  E820 2DCD 6B5D E858 ADF3

[toc] | [prev] | [next] | [standalone]

#1260612 — Bug#1114691: trailing comma in Build-Depends* causes dak to error globally

[Multipart message — attachments visible in raw view] — view raw

Salsa MR filed at 
https://salsa.debian.org/ftp-team/dak/-/merge_requests/296 for 
discussion

-- 
   ⢀⣴⠾⠻⢶⣦⠀               Paul Tagliamonte <paultag>
   ⣾⠁⢠⠒⠀⣿⡁  https://people.debian.org/~paultag | https://pault.ag/
   ⢿⡄⠘⠷⠚⠋        Debian, the universal operating system.
   ⠈⠳⣄⠀⠀  4096R / FEF2 EB20 16E6 A856 B98C  E820 2DCD 6B5D E858 ADF3

[toc] | [prev] | [next] | [standalone]

#1260687 — Bug#1114691: trailing comma in Build-Depends* causes dak to error globally

[Multipart message — attachments visible in raw view] — view raw

reassign 1114691 ftp.debian.org
affects 1114691 src:hdf5
thanks

[snip]

>  2) dpkg could strip trailing commas when it generates the dsc, like it 
>     does with dependencies for binaries in debs

dpkg does, in fact, do this. In this case, this dsc was not created by 
dpkg, so this point is moot.

I think it's fine if we reassign this to ftp.d.o now. No other packages
part of the no-change uploads were impacted, and this isn't an issue 
with the hdf5 package, so long as you use dpkg to build your dsc.

   paultag

-- 
   ⢀⣴⠾⠻⢶⣦⠀               Paul Tagliamonte <paultag>
   ⣾⠁⢠⠒⠀⣿⡁  https://people.debian.org/~paultag | https://pault.ag/
   ⢿⡄⠘⠷⠚⠋        Debian, the universal operating system.
   ⠈⠳⣄⠀⠀  4096R / FEF2 EB20 16E6 A856 B98C  E820 2DCD 6B5D E858 ADF3

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.bugs.dist

csiph-web