Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.bugs.dist > #1271098 > unrolled thread

Bug#1121155: xrt-xocl-dkms: module fails to build for Linux 6.18: error: implicit declaration of function 'ida_simple_get'

Back to article view | Back to linux.debian.bugs.dist

Contents

  Bug#1121155: xrt-xocl-dkms: module fails to build for Linux 6.18: error: implicit declaration of function 'ida_simple_get' Andreas Beckmann <anbe@debian.org> - 2025-11-21 23:00 +0100
    Bug#1121155: xrt-xocl-dkms: module fails to build for Linux 6.18: error: implicit declaration of function 'ida_simple_get' Andreas Beckmann <anbe@debian.org> - 2025-11-27 00:00 +0100
    Bug#1121155: xrt-xocl-dkms: module fails to build for Linux 6.18: error: implicit declaration of function 'ida_simple_get' Andreas Beckmann <anbe@debian.org> - 2025-12-22 03:00 +0100

#1271098 — Bug#1121155: xrt-xocl-dkms: module fails to build for Linux 6.18: error: implicit declaration of function 'ida_simple_get'

Package: xrt-xocl-dkms
Version: 202610.2.21.21-4
Severity: normal
Tags: upstream

Hi,

xrt-xocl-dkms fails to build a module for Linux 6.18 in experimental:

DKMS (dkms-3.2.2) make.log for xrt/2.21.0 for kernel 6.18-amd64 (x86_64)
Fri Nov 21 09:42:19 UTC 2025

Building module(s)
# command: cd driver/xocl; make KERNEL_SRC=/lib/modules/6.18-amd64/build; cd ../..
cd userpf; make all
make[1]: Entering directory '/var/lib/dkms/xrt/2.21.0/build/driver/xocl/userpf'
/var/lib/dkms/xrt/2.21.0/build/driver/xocl/userpf
make -C /lib/modules/6.18-amd64/build M=/var/lib/dkms/xrt/2.21.0/build/driver/xocl/userpf modules
make[2]: Entering directory '/usr/src/linux-headers-6.18-amd64'
make[3]: Entering directory '/var/lib/dkms/xrt/2.21.0/build/driver/xocl/userpf'
  CC [M]  ../xocl_subdev.o
../xocl_subdev.c: In function '__xocl_subdev_reserve':
../xocl_subdev.c:170:24: error: implicit declaration of function 'ida_simple_get' [-Wimplicit-function-declaration]
  170 |         subdev->inst = ida_simple_get(&subdev_inst_ida,
      |                        ^~~~~~~~~~~~~~
../xocl_subdev.c: In function '__xocl_subdev_destroy':
../xocl_subdev.c:428:9: error: implicit declaration of function 'ida_simple_remove' [-Wimplicit-function-declaration]
  428 |         ida_simple_remove(&subdev_inst_ida, subdev->inst);
      |         ^~~~~~~~~~~~~~~~~
make[5]: *** [/usr/src/linux-headers-6.18-common/scripts/Makefile.build:292: ../xocl_subdev.o] Error 1
make[4]: *** [/usr/src/linux-headers-6.18-common/Makefile:2034: .] Error 2
make[3]: *** [/usr/src/linux-headers-6.18-common/Makefile:260: __sub-make] Error 2
make[3]: Leaving directory '/var/lib/dkms/xrt/2.21.0/build/driver/xocl/userpf'
make[2]: *** [/usr/src/linux-headers-6.18-common/Makefile:260: __sub-make] Error 2
make[2]: Leaving directory '/usr/src/linux-headers-6.18-amd64'
make[1]: *** [Makefile:137: all] Error 2
make[1]: Leaving directory '/var/lib/dkms/xrt/2.21.0/build/driver/xocl/userpf'
make: *** [Makefile:2: all] Error 2

# exit code: 0
# elapsed time: 00:00:03
----------------------------------------------------------------


Andreas

[toc] | [next] | [standalone]

#1271754

Followup-For: Bug #1121155

I've sent a few fixes for regressions in supporting older kernels
directly to the corresponding upstream bugs.

Two more changes that are maybe not perfectly suited for upstream:

1)
Please add
    BUILD_EXCLUSIVE_KERNEL_MIN="4.18"
to the generated dkms.conf
struct_size() was added by 610b15c50e86eb1e4b77274fabcaea29ac72d6a8 in
v4.18 and is used unconditionally in xrt-xocl-dkms
(That minimum setting is not perfect, since struct_size() was
backported to a few stable kernel branches but for Debian and
derivatives it should be sufficient).

2)
--- a/xrt/XRT/src/runtime_src/core/pcie/driver/linux/xocl/xocl_drv.h
+++ b/xrt/XRT/src/runtime_src/core/pcie/driver/linux/xocl/xocl_drv.h
@@ -44,6 +44,9 @@
 #include <linux/moduleparam.h>
 #include <linux/cdev.h>
 #include <linux/vmalloc.h>
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 11, 0)
+#include <linux/sched/signal.h>
+#endif
 
 #include "xocl_types.h"
 #include "xclbin.h"

signal.h is not included transitively by all (old) kernel versions,
e.g. 5.5.0. There is a RHEL specific conditional further down to include
signal.h, I'm not sure how they would interact, maybe the two could be
merged.


Andreas

[toc] | [prev] | [next] | [standalone]

#1275459

[Multipart message — attachments visible in raw view] — view raw

Followup-For: Bug #1121155

Linux v6.18 support seems to be fixed in the last upload, but one change
for supporting older kernels was missed upstream (in addition to the two
changes for setting BUILD_EXCLUSIVE_KERNEL_MIN and a missing #include I
previously mentioned here), patch attached.

Andreas

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.bugs.dist

csiph-web