Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.bugs.dist > #1270057 > unrolled thread

Bug#1120289: trixie-pu: magit/4.3.5-1+deb13u1

Back to article view | Back to linux.debian.bugs.dist

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Bug#1120289: trixie-pu: magit/4.3.5-1+deb13u1 Soren Stoutner <soren@debian.org> - 2025-11-13 20:10 +0100
    Bug#1120289: trixie-pu: magit/4.3.5-1+deb13u1 Soren Stoutner <soren@debian.org> - 2025-11-18 03:00 +0100
      Bug#1120289: trixie-pu: magit/4.3.5-1+deb13u1 "Adam D. Barratt" <adam@adam-barratt.org.uk> - 2025-11-18 07:30 +0100
      Bug#1120549: Bug#1120289: trixie-pu: magit/4.3.5-1+deb13u1 Johannes Schauer Marin Rodrigues <josch@debian.org> - 2025-11-18 09:10 +0100

#1270057 — Bug#1120289: trixie-pu: magit/4.3.5-1+deb13u1

[Multipart message — attachments visible in raw view] — view raw

On Tuesday, November 11, 2025 1:46:17 AM Mountain Standard Time Johannes 
Schauer Marin Rodrigues wrote:
> Hi,
> 
> Quoting Xiyue Deng (2025-11-11 08:48:24)
> 
> > > I do not see that page recommending -s or --source. Where does it do 
that?
> > > 
> > > You really do *not* want to run sbuild with -s or --source. If you have
> > > ideas
> > > on how I could make the documentation more clear about this I'd be happy
> > > to
> > > improve it.
> > > 
> > > So many people add -s to sbuild that I am tempted to remove the option 
for
> > > good.
> > 
> > The option is named `$build_source' in the example config.  I attempted
> > to updated the comment of this part and set its value to 0[1].  Please
> > feel free to update it in a more definitive manner.
> > 
> > [1] https://wiki.debian.org/sbuild?action=diff&rev1=330&rev2=331
> 
> thank you! Since a lot of people seem to be reading the wiki page about 
sbuild
> instead of its man page I took the liberty of completely deleting the
> `$build_source` (don't give people ideas) and added an extra section at the
> end to explicitly advice against the use of -s or --source.
> 
> Soren, I put you into CC because you original added the advice of using 
sbuild
> with $build_source=1 here:
> https://wiki.debian.org/sbuild?action=diff&rev1=288&rev2=289

Thanks for making that change.  I had misunderstood what the option did.

-- 
Soren Stoutner
soren@debian.org

[toc] | [next] | [standalone]

#1270593

[Multipart message — attachments visible in raw view] — view raw

On Thursday, November 13, 2025 12:01:04 PM Mountain Standard Time Soren 
Stoutner wrote:

> > Soren, I put you into CC because you original added the advice of using
> 
> sbuild
> 
> > with $build_source=1 here:
> > https://wiki.debian.org/sbuild?action=diff&rev1=288&rev2=289
> 
> Thanks for making that change.  I had misunderstood what the option did.

I just needed to do a library transition, involving a binary upload to NEW.  
Without the $build_source entry in my .sbuildrc, it did not produce the 
necessary files.  When uploading the amd64.changes file, this is what was 
sent:

2025-11-17 18:22:22,746 - dput[80807]: uploader.invoke_dput - Uploading 
libsecp256k1 using ftp to ftp-master (host: ftp.upload.debian.org; directory: 
/pub/UploadQueue/)
2025-11-17 18:22:22,746 - dput[80807]: hook.run_hook - running allowed-
distribution: check whether a local profile permits uploads to the target 
distribution
2025-11-17 18:22:22,749 - dput[80807]: hook.run_hook - running protected-
distribution: warn before uploading to distributions where a special policy 
applies
2025-11-17 18:22:22,752 - dput[80807]: hook.run_hook - running checksum: 
verify checksums before uploading
2025-11-17 18:22:22,756 - dput[80807]: hook.run_hook - running suite-mismatch: 
check the target distribution for common errors
2025-11-17 18:22:22,758 - dput[80807]: hook.run_hook - running gpg: check 
GnuPG signatures before the upload
2025-11-17 18:22:23,268 - dput[80807]: uploader.invoke_dput - Uploading 
libsecp256k1-6-dbgsym_0.7.0-1_amd64.deb
2025-11-17 18:22:24,337 - dput[80807]: uploader.invoke_dput - Uploading 
libsecp256k1-6_0.7.0-1_amd64.deb
2025-11-17 18:22:25,385 - dput[80807]: uploader.invoke_dput - Uploading 
libsecp256k1-dev_0.7.0-1_amd64.deb
2025-11-17 18:22:26,806 - dput[80807]: uploader.invoke_dput - Uploading 
libsecp256k1_0.7.0-1_amd64.buildinfo
2025-11-17 18:22:27,317 - dput[80807]: uploader.invoke_dput - Uploading 
libsecp256k1_0.7.0-1_amd64.changes

Which was promptly rejected because it did not contain the source.

With the $build_source entry in my .sbuildrc, uploading the amd64.changes 
performed as expected:

2025-11-17 18:48:55,512 - dput[113547]: uploader.invoke_dput - Uploading 
libsecp256k1 using ftp to ftp-master (host: ftp.upload.debian.org; directory: 
/pub/UploadQueue/)
2025-11-17 18:48:55,513 - dput[113547]: hook.run_hook - running allowed-
distribution: check whether a local profile permits uploads to the target 
distribution
2025-11-17 18:48:55,515 - dput[113547]: hook.run_hook - running protected-
distribution: warn before uploading to distributions where a special policy 
applies
2025-11-17 18:48:55,518 - dput[113547]: hook.run_hook - running checksum: 
verify checksums before uploading
2025-11-17 18:48:55,523 - dput[113547]: hook.run_hook - running suite-
mismatch: check the target distribution for common errors
2025-11-17 18:48:55,525 - dput[113547]: hook.run_hook - running gpg: check 
GnuPG signatures before the upload
2025-11-17 18:48:56,101 - dput[113547]: uploader.invoke_dput - Uploading 
libsecp256k1_0.7.0-1.dsc
2025-11-17 18:48:56,631 - dput[113547]: uploader.invoke_dput - Uploading 
libsecp256k1_0.7.0.orig.tar.gz
2025-11-17 18:48:57,826 - dput[113547]: uploader.invoke_dput - Uploading 
libsecp256k1_0.7.0-1.debian.tar.xz
2025-11-17 18:48:58,365 - dput[113547]: uploader.invoke_dput - Uploading 
libsecp256k1-6-dbgsym_0.7.0-1_amd64.deb
2025-11-17 18:48:59,255 - dput[113547]: uploader.invoke_dput - Uploading 
libsecp256k1-6_0.7.0-1_amd64.deb
2025-11-17 18:49:00,338 - dput[113547]: uploader.invoke_dput - Uploading 
libsecp256k1-dev_0.7.0-1_amd64.deb
2025-11-17 18:49:01,432 - dput[113547]: uploader.invoke_dput - Uploading 
libsecp256k1_0.7.0-1_amd64.buildinfo
2025-11-17 18:49:01,953 - dput[113547]: uploader.invoke_dput - Uploading 
libsecp256k1_0.7.0-1_amd64.changes


Is this the expected behavior?  Is there something else that should be added 
to .sbuildrc instead so that binary uploads are complete?

-- 
Soren Stoutner
soren@debian.org

[toc] | [prev] | [next] | [standalone]

#1270607

On Mon, 2025-11-17 at 18:51 -0700, Soren Stoutner wrote:
> On Thursday, November 13, 2025 12:01:04 PM Mountain Standard Time
> Soren 
> Stoutner wrote:
> 
> > > Soren, I put you into CC because you original added the advice of
> > > using
> > 
> > sbuild
> > 
> > > with $build_source=1 here:
> > > https://wiki.debian.org/sbuild?action=diff&rev1=288&rev2=289
> > 
> > Thanks for making that change.  I had misunderstood what the option
> > did.
> 
> I just needed to do a library transition, involving a binary upload
> to NEW.  

Please stop copying this conversation to the (now closed) #1120289 p-u
bug.

Regards,

Adam

[toc] | [prev] | [next] | [standalone]

#1270614 — Bug#1120549: Bug#1120289: trixie-pu: magit/4.3.5-1+deb13u1

[Multipart message — attachments visible in raw view] — view raw

Hi Soren,

Quoting Soren Stoutner (2025-11-18 02:51:10)
> I just needed to do a library transition, involving a binary upload to NEW.  
> Without the $build_source entry in my .sbuildrc, it did not produce the 
> necessary files.  When uploading the amd64.changes file, this is what was 
> sent:

this is what the --source-only-changes option is for. I have it in my
~/.config/sbuild/config.pl so that I always get a *_source.changes. In cases
where I also need to upload the source, I can do:

mergechanges xxx_arm64.changes xxx_source.changes > xxx_both.changes

And then I can dput xxx_both.changes.

If you want to automate this, you might want to look into a tool which is aware
of what is getting uploaded. For example dgit is able to drive sbuild and merge
the .changes files in whatever way required for an upload.

I'm not sure whether sbuild is the right location for even more convenience
options than what --source-only-changes already provides. I think you are
looking for a --both-changes option but that would just further pollute the
list of command line arguments with a feature which I think is better put into
tools which know how to upload to the archive (like dgit).

What do you think?

Thanks!

cheers, josch

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.bugs.dist

csiph-web