Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.debian.bugs.dist > #1270660 > unrolled thread
| Started by | Martin Kepplinger-Novakovic <martink@posteo.de> |
|---|---|
| First post | 2025-11-18 13:40 +0100 |
| Last post | 2025-11-27 22:00 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.debian.bugs.dist
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Bug#1120830: RFS: tslib/1.24-1 [ITA] -- touch screen library utilities Martin Kepplinger-Novakovic <martink@posteo.de> - 2025-11-18 13:40 +0100
Bug#1120830: RFS: tslib/1.24-1 [ITA] -- touch screen library utilities Tobias Frost <tobi@debian.org> - 2025-11-19 08:30 +0100
Bug#1120830: RFS: tslib/1.24-1 [ITA] -- touch screen library utilities Tobias Frost <tobi@debian.org> - 2025-11-27 22:00 +0100
| From | Martin Kepplinger-Novakovic <martink@posteo.de> |
|---|---|
| Date | 2025-11-18 13:40 +0100 |
| Subject | Bug#1120830: RFS: tslib/1.24-1 [ITA] -- touch screen library utilities |
| Message-ID | <LSta1-dSQw-3@gated-at.bofh.it> |
hi Tobias,
Am Montag, dem 17.11.2025 um 18:41 +0100 schrieb Tobias Frost:
> Control: tags -1 moreinfo
>
> Hi Martin,
>
> a quick review, a few changes would be appreciated, e.g the changelog
> thing-
>
> On Mon, Nov 17, 2025 at 07:28:10AM +0000, Martin Kepplinger wrote:
> > Package: sponsorship-requests
> > Severity: normal
> >
> > Dear mentors,
> >
> > I am looking for a sponsor for my package "tslib":
> >
> > * Package name : tslib
> > Version : 1.24-1
> > Upstream contact : tslib@lists.infradead.org
> > * URL : http://tslib.org
> > * License : LGPL-2+, GPL-2+
> > * Vcs : https://github.com/merge/tslib-debian
> > Section : embedded
> >
> >
> > Changes since the last upload:
> >
> > tslib (1.24-1) unstable; urgency=low
> > .
> > * Update to tslib version 1.24
> > * debiann/rules: add empty dh_missing override
> > * debian: remove compat file and move to control
> > * debian/compat: update to v13
> >
> > Regards,
> >
> > --
> > Martin Kepplinger-Novakovic
>
> - d/changelog:
> - Version 1.23-1 has never been in Debian. Please merge the
> relevant
> entries to 1.24-1 OR mark 1.23-1 UNRELEASED.
> - SV-Bump to 4.7.2 has not been documented. Did you need to change
> anything?
> ( - d/changelog seems to focus on "what" has changed, not "why".
> The
> what is usually clear when looking at the diff, but not the "why".
> This
> makes reviewing harder.)
>
> - d/rules:
> - all those DEB_*_MAINT_* shouldn't be needed anymore, check if
> they
> can be removed; -O2 should never be set in d/rules, this break eg
> DEB_BUILD_OPTIONS=noopt,
> - why do you overrule_dh_missing? Guessing that you might have
> files
> not installed, they would go to d/not-installed.
exactly. Thanks for bringing this up. The scripts say "not installed"
for many library files but I couldn't reproduce that locally. lib so-
files are being installed it seems. How would you test this?
thank you for reviewing!
>
> - d/copyright
> - the year of your contributions could be updated.
>
> - d/*.install
> - instead of usr/lib/*/ you could write
> usr/lib/${DEB_HOST_MULTIARCH}/
[toc] | [next] | [standalone]
| From | Tobias Frost <tobi@debian.org> |
|---|---|
| Date | 2025-11-19 08:30 +0100 |
| Message-ID | <LSKNA-e4SS-1@gated-at.bofh.it> |
| In reply to | #1270660 |
On Tue, Nov 18, 2025 at 12:35:12PM +0000, Martin Kepplinger-Novakovic wrote:
> hi Tobias,
>
> Am Montag, dem 17.11.2025 um 18:41 +0100 schrieb Tobias Frost:
> > Control: tags -1 moreinfo
> >
> > Hi Martin,
> >
> > a quick review, a few changes would be appreciated, e.g the changelog
> > thing-
> >
> > On Mon, Nov 17, 2025 at 07:28:10AM +0000, Martin Kepplinger wrote:
> > > Package: sponsorship-requests
> > > Severity: normal
> > >
> > > Dear mentors,
> > >
> > > I am looking for a sponsor for my package "tslib":
> > >
> > > * Package name : tslib
> > > Version : 1.24-1
> > > Upstream contact : tslib@lists.infradead.org
> > > * URL : http://tslib.org
> > > * License : LGPL-2+, GPL-2+
> > > * Vcs : https://github.com/merge/tslib-debian
> > > Section : embedded
> > >
> > >
> > > Changes since the last upload:
> > >
> > > tslib (1.24-1) unstable; urgency=low
> > > .
> > > * Update to tslib version 1.24
> > > * debiann/rules: add empty dh_missing override
> > > * debian: remove compat file and move to control
> > > * debian/compat: update to v13
> > >
> > > Regards,
> > >
> > > --
> > > Martin Kepplinger-Novakovic
> >
> > - d/changelog:
> > - Version 1.23-1 has never been in Debian. Please merge the
> > relevant
> > entries to 1.24-1 OR mark 1.23-1 UNRELEASED.
> > - SV-Bump to 4.7.2 has not been documented. Did you need to change
> > anything?
> > ( - d/changelog seems to focus on "what" has changed, not "why".
> > The
> > what is usually clear when looking at the diff, but not the "why".
> > This
> > makes reviewing harder.)
> >
> > - d/rules:
> > - all those DEB_*_MAINT_* shouldn't be needed anymore, check if
> > they
> > can be removed; -O2 should never be set in d/rules, this break eg
> > DEB_BUILD_OPTIONS=noopt,
> > - why do you overrule_dh_missing? Guessing that you might have
> > files
> > not installed, they would go to d/not-installed.
>
> exactly. Thanks for bringing this up. The scripts say "not installed"
> for many library files but I couldn't reproduce that locally. lib so-
> files are being installed it seems. How would you test this?
(The policy "--list-missing" would be better than not running it, but)
I *can* reproduce it in a pbuilder environment - I've just removed the
override in d/rules
dh_missing
dh_missing: warning: etc/ts.conf exists in debian/tmp but is not installed to anywhere
dh_missing: warning: A file with an equivalent path was found but did not get installed. Note that dh_install prefers paths in ./ over paths in ./debian/tmp.
dh_missing: warning: usr/lib/x86_64-linux-gnu/libts.la exists in debian/tmp but is not installed to anywhere
dh_missing: warning: usr/lib/x86_64-linux-gnu/ts0/crop.la exists in debian/tmp but is not installed to anywhere
dh_missing: warning: usr/lib/x86_64-linux-gnu/ts0/debounce.la exists in debian/tmp but is not installed to anywhere
dh_missing: warning: usr/lib/x86_64-linux-gnu/ts0/dejitter.la exists in debian/tmp but is not installed to anywhere
dh_missing: warning: usr/lib/x86_64-linux-gnu/ts0/evthres.la exists in debian/tmp but is not installed to anywhere
dh_missing: warning: usr/lib/x86_64-linux-gnu/ts0/iir.la exists in debian/tmp but is not installed to anywhere
dh_missing: warning: usr/lib/x86_64-linux-gnu/ts0/input.la exists in debian/tmp but is not installed to anywhere
dh_missing: warning: usr/lib/x86_64-linux-gnu/ts0/invert.la exists in debian/tmp but is not installed to anywhere
dh_missing: warning: usr/lib/x86_64-linux-gnu/ts0/linear.la exists in debian/tmp but is not installed to anywhere
dh_missing: warning: usr/lib/x86_64-linux-gnu/ts0/lowpass.la exists in debian/tmp but is not installed to anywhere
dh_missing: warning: usr/lib/x86_64-linux-gnu/ts0/median.la exists in debian/tmp but is not installed to anywhere
dh_missing: warning: usr/lib/x86_64-linux-gnu/ts0/pthres.la exists in debian/tmp but is not installed to anywhere
dh_missing: warning: usr/lib/x86_64-linux-gnu/ts0/skip.la exists in debian/tmp but is not installed to anywhere
dh_missing: warning: usr/lib/x86_64-linux-gnu/ts0/touchkit.la exists in debian/tmp but is not installed to anywhere
dh_missing: warning: usr/lib/x86_64-linux-gnu/ts0/variance.la exists in debian/tmp but is not installed to anywhere
dh_missing: warning: usr/lib/x86_64-linux-gnu/ts0/waveshare.la exists in debian/tmp but is not installed to anywhere
dh_missing: warning: usr/share/man/man1/ts_calibrate.1 exists in debian/tmp but is not installed to anywhere (related file: "doc/ts_calibrate.1")
dh_missing: warning: usr/share/man/man1/ts_conf.1 exists in debian/tmp but is not installed to anywhere (related file: "doc/ts_conf.1")
dh_missing: warning: usr/share/man/man1/ts_finddev.1 exists in debian/tmp but is not installed to anywhere (related file: "doc/ts_finddev.1")
dh_missing: warning: usr/share/man/man1/ts_harvest.1 exists in debian/tmp but is not installed to anywhere (related file: "doc/ts_harvest.1")
dh_missing: warning: usr/share/man/man1/ts_print.1 exists in debian/tmp but is not installed to anywhere (related file: "doc/ts_print.1")
dh_missing: warning: usr/share/man/man1/ts_print_mt.1 exists in debian/tmp but is not installed to anywhere (related file: "doc/ts_print_mt.1")
dh_missing: warning: usr/share/man/man1/ts_print_raw.1 exists in debian/tmp but is not installed to anywhere (related file: "doc/ts_print_raw.1")
dh_missing: warning: usr/share/man/man1/ts_test.1 exists in debian/tmp but is not installed to anywhere (related file: "doc/ts_test.1")
dh_missing: warning: usr/share/man/man1/ts_test_mt.1 exists in debian/tmp but is not installed to anywhere (related file: "doc/ts_test_mt.1")
dh_missing: warning: usr/share/man/man1/ts_uinput.1 exists in debian/tmp but is not installed to anywhere (related file: "doc/ts_uinput.1")
dh_missing: warning: usr/share/man/man1/ts_verify.1 exists in debian/tmp but is not installed to anywhere (related file: "doc/ts_verify.1")
dh_missing: warning: usr/share/man/man3/ts_close.3 exists in debian/tmp but is not installed to anywhere (related file: "doc/ts_close.3")
dh_missing: warning: usr/share/man/man3/ts_close_restricted.3 exists in debian/tmp but is not installed to anywhere (related file: "doc/ts_close_restricted.3")
dh_missing: warning: usr/share/man/man3/ts_conf_get.3 exists in debian/tmp but is not installed to anywhere (related file: "doc/ts_conf_get.3")
dh_missing: warning: usr/share/man/man3/ts_conf_set.3 exists in debian/tmp but is not installed to anywhere (related file: "doc/ts_conf_set.3")
dh_missing: warning: usr/share/man/man3/ts_config.3 exists in debian/tmp but is not installed to anywhere (related file: "doc/ts_config.3")
dh_missing: warning: usr/share/man/man3/ts_error_fn.3 exists in debian/tmp but is not installed to anywhere (related file: "doc/ts_error_fn.3")
dh_missing: warning: usr/share/man/man3/ts_fd.3 exists in debian/tmp but is not installed to anywhere (related file: "doc/ts_fd.3")
dh_missing: warning: usr/share/man/man3/ts_get_eventpath.3 exists in debian/tmp but is not installed to anywhere (related file: "doc/ts_get_eventpath.3")
dh_missing: warning: usr/share/man/man3/ts_libversion.3 exists in debian/tmp but is not installed to anywhere (related file: "doc/ts_libversion.3")
dh_missing: warning: usr/share/man/man3/ts_open.3 exists in debian/tmp but is not installed to anywhere (related file: "doc/ts_open.3")
dh_missing: warning: usr/share/man/man3/ts_open_restricted.3 exists in debian/tmp but is not installed to anywhere (related file: "doc/ts_open_restricted.3")
dh_missing: warning: usr/share/man/man3/ts_print_ascii_logo.3 exists in debian/tmp but is not installed to anywhere
dh_missing: warning: usr/share/man/man3/ts_read.3 exists in debian/tmp but is not installed to anywhere (related file: "doc/ts_read.3")
dh_missing: warning: usr/share/man/man3/ts_read_mt.3 exists in debian/tmp but is not installed to anywhere (related file: "doc/ts_read_mt.3")
dh_missing: warning: usr/share/man/man3/ts_read_raw.3 exists in debian/tmp but is not installed to anywhere (related file: "doc/ts_read_raw.3")
dh_missing: warning: usr/share/man/man3/ts_read_raw_mt.3 exists in debian/tmp but is not installed to anywhere (related file: "doc/ts_read_raw_mt.3")
dh_missing: warning: usr/share/man/man3/ts_setup.3 exists in debian/tmp but is not installed to anywhere (related file: "doc/ts_setup.3")
dh_missing: warning: usr/share/man/man3/tslib_version.3 exists in debian/tmp but is not installed to anywhere
dh_missing: warning: usr/share/man/man5/ts.conf.5 exists in debian/tmp but is not installed to anywhere (related file: "doc/ts.conf.5")
dh_missing: error: missing files, aborting
While detecting missing files, dh_missing noted some files with a similar name to those
that were missing. This error /might/ be resolved by replacing references to the
missing files with the similarly named ones that dh_missing found - assuming the content
is identical.
As an example, you might want to replace:
* doc/ts_calibrate.1
with:
* usr/share/man/man1/ts_calibrate.1
in a file in debian/ or as argument to one of the dh_* tools called from debian/rules.
(Note it is possible the paths are not used verbatim but instead directories
containing or globs matching them are used instead)
Alternatively, add the missing file to debian/not-installed if it cannot and should not
be used.
The following debhelper tools have reported what they installed (with files per package)
* dh_install: libts-bin (3), libts-dev (3), libts0t64 (18)
* dh_installdocs: libts-bin (0), libts-dev (0), libts0t64 (0)
* dh_installman: libts-bin (0), libts-dev (0), libts0t64 (28)
If the missing files are installed by another tool, please file a bug against it.
When filing the report, if the tool is not part of debhelper itself, please reference the
"Logging helpers and dh_missing" section from the "PROGRAMMING" guide for debhelper (10.6.3+).
(in the debhelper package: /usr/share/doc/debhelper/PROGRAMMING.md.gz)
Be sure to test with dpkg-buildpackage -A/-B as the results may vary when only a subset is built
If the omission is intentional or no other helper can take care of this consider adding the
paths to debian/not-installed.
Remember to be careful with paths containing "x86_64-linux-gnu", where you might need to
use a wildcard or (assuming compat 13+) e.g. ${DEB_HOST_MULTIARCH} in debian/not-installed
to ensure it works on all architectures (see #961104).
make: *** [debian/rules:32: binary] Error 255
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
I: copying local configuration
> thank you for reviewing!
>
> >
> > - d/copyright
> > - the year of your contributions could be updated.
> >
> > - d/*.install
> > - instead of usr/lib/*/ you could write
> > usr/lib/${DEB_HOST_MULTIARCH}/
>
[toc] | [prev] | [next] | [standalone]
| From | Tobias Frost <tobi@debian.org> |
|---|---|
| Date | 2025-11-27 22:00 +0100 |
| Message-ID | <LVRfP-geuh-3@gated-at.bofh.it> |
| In reply to | #1270760 |
On Tue, Nov 25, 2025 at 07:05:58AM +0000, Martin Kepplinger wrote: > hi Tobias, > > thanks again, I was able to resolve the installation for all files > except for etc/ts.conf where dh_missing says: > > dh_missing: warning: etc/ts.conf exists in debian/tmp but is not > installed to anywhere (related file: "etc/ts.conf") > dh_missing: error: missing files, aborting > > While detecting missing files, dh_missing noted some files > with a similar name to those > that were missing. This error /might/ be resolved by > replacing references to the > missing files with the similarly named ones that dh_missing > found - assuming the content > is identical. > > As an example, you might want to replace: > * etc/ts.conf > with: > * etc/ts.conf > > > any thought on this? > > so for now I added this to d/not-installed as well, because it *does* > find the file, right? Still, this does not feel stable. You've got $srcdir/etc/ts.conf and you've got (the probably make install'ed) debian/tmp/etc/ts.conf. dh_install will grab ts.conf from $srcdir/etc/ts.conf and therefore dh_missing still belives debian/tmp/etc/ts.conf is still uninstalled. so you need to instruct dh_install to take it from the debian directory: "debian/tmp/etc/ts.conf" > I've change the other remarks you had as well and pushed it to > https://github.com/merge/tslib-debian (This is a quite odd debian packaging repo layout) It has extra files (README.markdown autobuild.sh) for an debian/-only-layout and for the "usual" layout where upstream-source is unpacked in the root directory + the debian-directory -- well, there's no source. This break assumptions from standard Debian tools, eg the sequence debcheckout tslib cd ts-lib uscan --force-download dpkg-source -b . will not work, as the extra files break dpkg-source: dpkg-source: info: local changes detected, the modified files are: tslib/README.markdown tslib/autobuild.sh dpkg-source: hint: make sure the version in debian/changelog matches the unpacked source tree dpkg-source: hint: you can integrate the local changes with dpkg-source --commit dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/tslib_1.24-1.diff.nrTGG0 I recommend to check DEP14 and possibly create an DEP14 compliant packaging repository, containing upstream source and debian directory. (To sidestep this, please upload a .dsc to mentors.d.n.) -- tobi
[toc] | [prev] | [standalone]
Back to top | Article view | linux.debian.bugs.dist
csiph-web