Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.debian.bugs.dist > #1269410 > unrolled thread

Bug#1120313: devscripts: [getbuildlog] silently fails if package name contains +

Started byEmanuele Rocca <ema@debian.org>
First post2025-11-07 15:00 +0100
Last post2025-11-11 13:50 +0100
Articles 5 — 3 participants

Back to article view | Back to linux.debian.bugs.dist


Contents

  Bug#1120313: devscripts: [getbuildlog] silently fails if package name contains + Emanuele Rocca <ema@debian.org> - 2025-11-07 15:00 +0100
    Bug#1120313: devscripts: [getbuildlog] silently fails if package name contains + Holger Levsen <holger@layer-acht.org> - 2025-11-07 15:20 +0100
      Bug#1120313: devscripts: [getbuildlog] silently fails if package name contains + Chris Hofstaedtler <zeha@debian.org> - 2025-11-11 05:10 +0100
        Bug#1120313: devscripts: [getbuildlog] silently fails if package name contains + Holger Levsen <holger@layer-acht.org> - 2025-11-11 09:30 +0100
          Bug#681779: Bug#1120313: devscripts: [getbuildlog] silently fails if package name contains + Emanuele Rocca <ema@debian.org> - 2025-11-11 13:50 +0100

#1269410 — Bug#1120313: devscripts: [getbuildlog] silently fails if package name contains +

FromEmanuele Rocca <ema@debian.org>
Date2025-11-07 15:00 +0100
SubjectBug#1120313: devscripts: [getbuildlog] silently fails if package name contains +
Message-ID<LOvap-bb78-7@gated-at.bofh.it>
Package: devscripts
Version: 2.25.25

If the package name passed to getbuildlog includes a + sign, the program
silently does nothing. For example:

$ getbuildlog bonnie++ last arm64
$

With package names that don't include a + sign it works fine instead:

$ getbuildlog hello last arm64
--2025-11-07 14:50:12--  https://buildd.debian.org/status/fetch.php?pkg=hello&arch=arm64&ver=2.10-5&stamp=1744800322&raw=1
Resolving buildd.debian.org (buildd.debian.org)... 2607:f8f0:614:1::1274:60, 209.87.16.60
Connecting to buildd.debian.org (buildd.debian.org)|2607:f8f0:614:1::1274:60|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [text/plain]
Saving to: ‘hello_2.10-5_arm64.log’

hello_2.10-5_arm64.log                [   <=>                                                        ] 118.81K   270KB/s    in 0.4s    

2025-11-07 14:50:13 (270 KB/s) - ‘hello_2.10-5_arm64.log’ saved [121666]

[toc] | [next] | [standalone]


#1269413

FromHolger Levsen <holger@layer-acht.org>
Date2025-11-07 15:20 +0100
Message-ID<LOvtL-bbuU-1@gated-at.bofh.it>
In reply to#1269410

[Multipart message — attachments visible in raw view] — view raw

control: tags -1 + help newcomer
thanks

On Fri, Nov 07, 2025 at 02:52:00PM +0100, Emanuele Rocca wrote:
> If the package name passed to getbuildlog includes a + sign, the program
> silently does nothing. For example:
[...]
> With package names that don't include a + sign it works fine instead:

thanks for filing this bug report! A patch fixing it would be much
appreciated. There's absolutly no need not to provide one just because
you are no newcomer! ;) Still tagging accordingly cause I suspect the
patch should be fairly simple.


-- 
cheers,
	Holger

 ⢀⣴⠾⠻⢶⣦⠀
 ⣾⠁⢠⠒⠀⣿⡁  holger@(debian|reproducible-builds|layer-acht).org
 ⢿⡄⠘⠷⠚⠋⠀  OpenPGP: B8BF54137B09D35CF026FE9D 091AB856069AAA1C
 ⠈⠳⣄

If a monkey hoarded more bananas than it could eat, while most of the other
monkeys starved, scientists would study that monkey to figure out what the
heck was wrong with it. When humans do it, we put them on the cover of Forbes.

[toc] | [prev] | [next] | [standalone]


#1269768

FromChris Hofstaedtler <zeha@debian.org>
Date2025-11-11 05:10 +0100
Message-ID<LPNRD-c4tq-1@gated-at.bofh.it>
In reply to#1269413
On Fri, Nov 07, 2025 at 02:12:16PM +0000, Holger Levsen wrote:
> control: tags -1 + help newcomer
> thanks
> 
> On Fri, Nov 07, 2025 at 02:52:00PM +0100, Emanuele Rocca wrote:
> > If the package name passed to getbuildlog includes a + sign, the program
> > silently does nothing. For example:
> [...]
> > With package names that don't include a + sign it works fine instead:
> 
> thanks for filing this bug report! A patch fixing it would be much
> appreciated. There's absolutly no need not to provide one just because
> you are no newcomer! ;) Still tagging accordingly cause I suspect the
> patch should be fairly simple.

This is basically a duplicate of #651286 and #681779.

The passed arguments are all regexs, and you need to escape special 
chars like +.

To improve on this, I asked buildd.d.o to provide an API, see 
#1116273.

Chris

[toc] | [prev] | [next] | [standalone]


#1269783

FromHolger Levsen <holger@layer-acht.org>
Date2025-11-11 09:30 +0100
Message-ID<LPRVf-c7kj-3@gated-at.bofh.it>
In reply to#1269768

[Multipart message — attachments visible in raw view] — view raw

merge 1120313 651286
thanks

On Tue, Nov 11, 2025 at 05:01:57AM +0100, Chris Hofstaedtler wrote:
> > > If the package name passed to getbuildlog includes a + sign, the program
> > > silently does nothing. For example:
> This is basically a duplicate of #651286 and #681779.

nice find, thanks! 681779 is definitly related *and* has a patch. Can someone
affected please try it?
 
> The passed arguments are all regexs, and you need to escape special 
> chars like +.

yup.

> To improve on this, I asked buildd.d.o to provide an API, see 
> #1116273.

*g* & thanks for that!


-- 
cheers,
	Holger

 ⢀⣴⠾⠻⢶⣦⠀
 ⣾⠁⢠⠒⠀⣿⡁  holger@(debian|reproducible-builds|layer-acht).org
 ⢿⡄⠘⠷⠚⠋⠀  OpenPGP: B8BF54137B09D35CF026FE9D 091AB856069AAA1C
 ⠈⠳⣄

Every time you see the word "smart" used to describe a device, replace it with
"surveillance." Surveillance watch. Surveillance streetlights. Surveillance
oven. Surveillance toilet. Surveillance car. Surveillance city. (@mollyali)

[toc] | [prev] | [next] | [standalone]


#1269807 — Bug#681779: Bug#1120313: devscripts: [getbuildlog] silently fails if package name contains +

FromEmanuele Rocca <ema@debian.org>
Date2025-11-11 13:50 +0100
SubjectBug#681779: Bug#1120313: devscripts: [getbuildlog] silently fails if package name contains +
Message-ID<LPVYR-c9SP-13@gated-at.bofh.it>
In reply to#1269783
Hello Holger and Chris,

On 2025-11-11 08:22, Holger Levsen wrote:
> nice find, thanks! 681779 is definitly related *and* has a patch. Can someone
> affected please try it?

681779 is about the exit status. It would surely be a nice improvement
but it would not address the escaping issues themselves: 1120313
(package name) and 651286 (version).

In any case the patch does not seem to work:

$ getbuildlog hello last arm64
$ echo $?
1

Without the patch:

$ getbuildlog hello last arm64 
--2025-11-11 13:36:25--  https://buildd.debian.org/status/fetch.php?pkg=hello&arch=arm64&ver=2.10-5&stamp=1744800322&raw=1
Resolving buildd.debian.org (buildd.debian.org)... 2607:f8f0:614:1::1274:60, 209.87.16.60
Connecting to buildd.debian.org (buildd.debian.org)|2607:f8f0:614:1::1274:60|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [text/plain]
Saving to: ‘hello_2.10-5_arm64.log’

hello_2.10-5_arm64.log                [   <=>                                                        ] 118.81K   264KB/s    in 0.4s    

2025-11-11 13:36:26 (264 KB/s) - ‘hello_2.10-5_arm64.log’ saved [121666]

[toc] | [prev] | [standalone]


Back to top | Article view | linux.debian.bugs.dist


csiph-web