Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.bugs.dist > #1251694 > unrolled thread

Bug#1108681: geeqie: calls exiftran in a way that causes it to segfault (see bug #1108680)

Back to article view | Back to linux.debian.bugs.dist

Contents

  Bug#1108681: geeqie: calls exiftran in a way that causes it to segfault (see bug #1108680) "Francesco Poli (wintermute)" <invernomuto@paranoici.org> - 2025-07-02 23:30 +0200
    Bug#1108681: geeqie: calls exiftran in a way that causes it to segfault (see bug #1108680) Andreas Rönnquist <andreas@ronnquist.net> - 2025-07-05 21:50 +0200
      Bug#1108681: geeqie: calls exiftran in a way that causes it to segfault (see bug #1108680) Francesco Poli <invernomuto@paranoici.org> - 2025-07-06 12:20 +0200

#1251694 — Bug#1108681: geeqie: calls exiftran in a way that causes it to segfault (see bug #1108680)

[Multipart message — attachments visible in raw view] — view raw

Package: geeqie
Version: 1:2.5-6
Severity: normal
Tags: patch
X-Debbugs-Cc: invernomuto@paranoici.org

Hello,
I have recently experienced a bug in the way geeqie invokes exiftran
(in the "Losslessly rotate JPEG image" plugins).

See bug [#1108680] for the details of the issue with exiftran.

[#1108680]: <https://bugs.debian.org/1108680>

While waiting for an actual fix in package 'exiftran', I attach
a patch that works around bug [#1108680], dropping the '-g' option
from the exiftran invocation.

Please consider applying this patch.

Thanks for your time and dedication!
Have a nice night/day/whatever (depending on your timezone and on
when you read this...).


-- System Information:
Debian Release: 13.0
  APT prefers testing-security
  APT policy: (800, 'testing-security'), (800, 'testing'), (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 6.12.33+deb13-amd64 (SMP w/4 CPU threads; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages geeqie depends on:
ii  geeqie-common            1:2.5-6
ii  libarchive13t64          3.7.4-3
ii  libc6                    2.41-9
ii  libcairo2                1.18.4-1+b1
ii  libdjvulibre21           3.5.28-2+b2
ii  libexiv2-28              0.28.5+dfsg-1
ii  libffmpegthumbnailer4v5  2.2.3-2
ii  libgcc-s1                14.2.0-19
ii  libgdk-pixbuf-2.0-0      2.42.12+dfsg-3
ii  libglib2.0-0t64          2.84.3-1
ii  libgspell-1-3            1.14.0-2+b1
ii  libgtk-3-0t64            3.24.49-3
ii  libheif1                 1.19.8-1
ii  libjpeg62-turbo          1:2.1.5-4
ii  libjxl0.11               0.11.1-4
ii  liblcms2-2               2.16-2
ii  liblua5.4-0              5.4.7-1+b2
ii  libopenjp2-7             2.5.3-2
ii  libpango-1.0-0           1.56.3-1
ii  libpangocairo-1.0-0      1.56.3-1
ii  libpoppler-glib8t64      25.03.0-4
ii  libraw23t64              0.21.4-2
ii  libstdc++6               14.2.0-19
ii  libtiff6                 4.7.0-3
ii  libwebp7                 1.5.0-0.1
ii  sensible-utils           0.0.25
ii  webp-pixbuf-loader       0.2.7-1+b1

Versions of packages geeqie recommends:
pn  cups-bsd | lpr                                   <none>
ii  exiftran                                         2.14-1
pn  exiv2                                            <none>
ii  graphicsmagick-imagemagick-compat [imagemagick]  1.4+really1.3.45+hg17696-1
ii  librsvg2-common                                  2.60.0+dfsg-1
ii  zenity                                           4.1.90-1

Versions of packages geeqie suggests:
ii  gimp                                 3.0.4-2
ii  libjpeg-turbo-progs [libjpeg-progs]  1:2.1.5-4
pn  xpaint                               <none>

-- no debconf information

-- debsums errors found:
debsums: changed file /usr/share/geeqie/applications/rotate-270.desktop (from geeqie package)
debsums: changed file /usr/share/geeqie/applications/rotate-90.desktop (from geeqie package)

[toc] | [next] | [standalone]

#1251934

On Wed, 02 Jul 2025 23:21:47 +0200 "Francesco Poli (wintermute)" <invernomuto@paranoici.org> wrote:
> Package: geeqie
> Version: 1:2.5-6
> Severity: normal
> Tags: patch
> X-Debbugs-Cc: invernomuto@paranoici.org
> 
> Hello,
> I have recently experienced a bug in the way geeqie invokes exiftran
> (in the "Losslessly rotate JPEG image" plugins).
> 
> See bug [#1108680] for the details of the issue with exiftran.
> 
> [#1108680]: <https://bugs.debian.org/1108680>
> 
> While waiting for an actual fix in package 'exiftran', I attach
> a patch that works around bug [#1108680], dropping the '-g' option
> from the exiftran invocation.
> 
> Please consider applying this patch.
> 

Thanks for your report - Will the rotated image still have it's
thumbnail correct (and that also rotated) if used without the '-g'
option?

To me it looks like exiftran is unmaintained both in Debian and
upstream, so the best course of action would probably be to migrate it
to exiftool from the libimage-exiftool-perl package.

But then, the very best idea might really be to simply drop these
debian-specific scripts (since they don't work like they are supposed to
anyway).

/Andreas Rönnquist
gusnan@debian.org

[toc] | [prev] | [next] | [standalone]

#1251970

[Multipart message — attachments visible in raw view] — view raw

On Sat, 5 Jul 2025 21:09:45 +0200 Andreas Rönnquist wrote:

> On Wed, 02 Jul 2025 23:21:47 +0200 "Francesco Poli (wintermute)" <invernomuto@paranoici.org> wrote:
> > Package: geeqie
> > Version: 1:2.5-6
> > Severity: normal
> > Tags: patch
> > X-Debbugs-Cc: invernomuto@paranoici.org
> > 
> > Hello,
> > I have recently experienced a bug in the way geeqie invokes exiftran
> > (in the "Losslessly rotate JPEG image" plugins).
> > 
> > See bug [#1108680] for the details of the issue with exiftran.
> > 
> > [#1108680]: <https://bugs.debian.org/1108680>
> > 
> > While waiting for an actual fix in package 'exiftran', I attach
> > a patch that works around bug [#1108680], dropping the '-g' option
> > from the exiftran invocation.
> > 
> > Please consider applying this patch.
> > 
> 
> Thanks for your report

You're welcome!   :-)

> - Will the rotated image still have it's
> thumbnail correct (and that also rotated) if used without the '-g'
> option?

I don't know, I am not displaying any thumbnail embedded in EXIF data
(if any is present).

How do I check?

Also, you can reproduce the exiftran bug by yourself, I even provided an
example JPEG image in bug [#1108680]...
Please help me in investigating the issue, I am not as knowledgeable
about the EXIF metadata format, as I wish to be...   :-(

> 
> To me it looks like exiftran is unmaintained both in Debian and
> upstream,

I was under this impression, too, that's why I thought I could file
this bug report against geeqie, with a patch to work around the
exiftran bug (while waiting for a proper fix in exiftran).

> so the best course of action would probably be to migrate it
> to exiftool from the libimage-exiftool-perl package.

How?

By searching the web, I found a forum [thread] that seems to state
that exiftool is *not* able to losslessly rotate JPEG images, since it
only edits EXIF metadata.

[thread]: <https://exiftool.org/forum/index.php?topic=16163.0>

I searched for other tools similar to exiftran in Debian, able to
losslessly rotate a JPEG image, but I haven't found much: jpegtran
(from package 'libjpeg-turbo-progs') seems to be able to losslessly
rotate JPEG images, but without preserving EXIF metadata.
It even suggests to use exiftran for JPEG images with EXIF data in its
own jpegtran(1) man page...

It seems that the only solution is that someone volunteers to adopt
package 'exiftran'!
Wow, yes, that was so obvious, why haven't I thought about it before?!?
Maybe... you could volunteer?!?    ;-)

> 
> But then, the very best idea might really be to simply drop these
> debian-specific scripts (since they don't work like they are supposed to
> anyway).

Well, but they are handy to quickly losslessly rotate JPEG photos from
within qeeqie, without having to start another terminal and without
having to always remember the correct options to be passed to exiftran
(or other tool).

Of course, I can write a small script with the correct options
hardcoded...
But, wait, those two "rotate-*.desktop" scripts are exactly that: small
scripts with the correct options hardcoded and they can be even called
directly from within geeqie...

So, why should we drop the wheel and then re-invent the wheel?!?



-- 
 http://www.inventati.org/frx/
 There's not a second to spare! To the laboratory!
..................................................... Francesco Poli .
 GnuPG key fpr == CA01 1147 9CD2 EFDF FB82  3925 3E1C 27E1 1F69 BFFE

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.bugs.dist

csiph-web