Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.debian.bugs.dist > #1250887 > unrolled thread

Bug#1108224: unblock: zfs-linux/2.3.3-1

Started byShengqi Chen <harry@debian.org>
First post2025-06-23 17:50 +0200
Last post2025-07-05 16:10 +0200
Articles 5 — 2 participants

Back to article view | Back to linux.debian.bugs.dist


Contents

  Bug#1108224: unblock: zfs-linux/2.3.3-1 Shengqi Chen <harry@debian.org> - 2025-06-23 17:50 +0200
    Bug#1108224: unblock: zfs-linux/2.3.3-1 Paul Gevers <elbrus@debian.org> - 2025-06-26 17:20 +0200
      Bug#1108224: unblock: zfs-linux/2.3.3-1 Shengqi Chen <harry@debian.org> - 2025-06-29 16:20 +0200
        Bug#1108224: unblock: zfs-linux/2.3.2-2 Shengqi Chen <harry@debian.org> - 2025-06-29 16:20 +0200
          Bug#1108224: unblock: zfs-linux/2.3.2-2 Paul Gevers <elbrus@debian.org> - 2025-07-05 16:10 +0200

#1250887 — Bug#1108224: unblock: zfs-linux/2.3.3-1

FromShengqi Chen <harry@debian.org>
Date2025-06-23 17:50 +0200
SubjectBug#1108224: unblock: zfs-linux/2.3.3-1
Message-ID<L0RAJ-cCoI-1@gated-at.bofh.it>
Package: release.debian.org
Severity: normal
X-Debbugs-Cc: harry@debian.org
User: release.debian.org@packages.debian.org
Usertags: unblock
Control: affects -1 src:zfs-linux

Dear release managers,

Please unblock package zfs-linux (pre-approval request).

Please see [1] for current state of the package, and [2] for diff
between 2.3.3-1 and 2.3.2-1 (current in trixie).

[ Reason ]

There are two main reasons for this unblock request:

1. zfs has released a stable release 2.3.3, which contains multiple bug
   fixes, especially the RC bug #1106035. We would like to include this
   version in trixie.
2. zfs does not run any autopkgtest on i386 due to no kernel image is
   availble on that platform (but userspace tools are still useful). So
   it will be blocked by britney even after the delay.

[ Impact ]

Since there's an RC bug, we need to cherry-pick fixes to prevent zfs
from being removed. This will however lead to another unblock request
due to reason 2.

[ Tests ]
 
* zfs has its test suites covering multiple distributions & kernels.
* I have run both autopkgtest (smoking tests) and zfs test suites
  manually on my trixie install.

[ Risks ]

The whole changes are large, but mostly upstream diff. Since the code
is a upstream stable release, and that they are heavily tested, I reckon
this part to be relatively safe.

For the debian part, I did not make non-trivial modifications.
My changes include:

* refresh of patch sets (only line offsets changed)
* tiny changes to library symbol list (there are some deletions, but
  these libraries are internally used and we use strict version
  dependency, so this is not a ABI break).
* changes to d/copyright to make lintian happy.

[ Checklist ]

  [*] all changes are documented in the d/changelog
  [*] I reviewed all changes and I approve them
  [ ] attach debdiff against the package in testing -- no, please see
      above for explanation

unblock zfs-linux/2.3.3-1

[1]: https://salsa.debian.org/zfsonlinux-team/zfs/-/commit/ea33dd4d6fe6464f9739c3dad013637984c1ddf9
[2]: https://salsa.debian.org/zfsonlinux-team/zfs/-/compare/debian%2F2.3.2-1...master?from_project_id=13840

[toc] | [next] | [standalone]


#1251132

FromPaul Gevers <elbrus@debian.org>
Date2025-06-26 17:20 +0200
Message-ID<L1Wym-dlbh-3@gated-at.bofh.it>
In reply to#1250887

[Multipart message — attachments visible in raw view] — view raw

Control: tags -1 moreinfo

Hi,

On 23-06-2025 17:43, Shengqi Chen wrote:
> 1. zfs has released a stable release 2.3.3, which contains multiple bug
>     fixes, especially the RC bug #1106035. We would like to include this
>     version in trixie.


That bug also affects bookworm, I assume you also intent do fix the 
issue there?

> * refresh of patch sets (only line offsets changed)


Please don't, it makes reviewing more noisy than needed.

> * changes to d/copyright to make lintian happy.


Please don't, it's not the time to do this.

>    [*] all changes are documented in the d/changelog
>    [*] I reviewed all changes and I approve them
>    [ ] attach debdiff against the package in testing -- no, please see
>        above for explanation


We still like to see one. And we still prefer a targeted fix. Can you 
check our FAQ [1] and answer the questions we put down there in the "I 
want to add a new upstream release, is that possible?" section?

Paul

[1] https://release.debian.org/testing/FAQ.html

[toc] | [prev] | [next] | [standalone]


#1251396

FromShengqi Chen <harry@debian.org>
Date2025-06-29 16:20 +0200
Message-ID<L312V-e1lM-3@gated-at.bofh.it>
In reply to#1251132
Control: retitle -1 unblock: zfs-linux/2.3.2-2

Hi,

After reviewing, we have decided to backport important fix only, as a targeted fix.
So here is the new pre-approval unblock request with debdiff attached.

[ Reason ]

There are two main reasons for this unblock request:

1. Backport some important fixes in upstream 2.3.3 release, especially
fix to RC bug #1106035.
2. zfs does not run any autopkgtest on i386 due to no kernel image is
availble on that platform (but userspace tools are still useful). So
it will be blocked by britney even after the delay.

[ Impact ]

RC bug would not be fixed and user suffers from potential data corruption.

[ Tests ]

* zfs has its test suites covering multiple distributions & kernels run on
every commit on GitHub CI.
* I have run both autopkgtest (smoking tests) and zfs test suites for this
backported version, manually on my trixie install.

[ Risks ]

The debdiff contains only 6 upstream patches:

0001: Fix to RC bug #1106035.
0002: Fix to an integer overflow issue.
0003,0005: Make output of “zfs destroy” more user-friendly.
0004: Remove of old code that might hurt deduplication performance.
0006: Fix to exported symbols for Lustre.

Changes are not large, and are all self-described by commit messages.

[ Checklist ]

[*] all changes are documented in the d/changelog
[*] I reviewed all changes and I approve them
[*] attach debdiff against the package in testing (please ignore the
 “UNRELEASED” part, I forgot to change it)

unblock zfs-linux/2.3.2-2

[toc] | [prev] | [next] | [standalone]


#1251398 — Bug#1108224: unblock: zfs-linux/2.3.2-2

FromShengqi Chen <harry@debian.org>
Date2025-06-29 16:20 +0200
SubjectBug#1108224: unblock: zfs-linux/2.3.2-2
Message-ID<L312V-e1lM-1@gated-at.bofh.it>
In reply to#1251396

[Multipart message — attachments visible in raw view] — view raw

Hi,

> 2025年6月29日 22:14,Shengqi Chen <harry@debian.org> 写道:
> 
> Control: retitle -1 unblock: zfs-linux/2.3.2-2
> 
> Hi,
> 
> After reviewing, we have decided to backport important fix only, as a targeted fix.
> So here is the new pre-approval unblock request with debdiff attached.

Sorry I forgot the attachment, here it is:

[toc] | [prev] | [next] | [standalone]


#1251908 — Bug#1108224: unblock: zfs-linux/2.3.2-2

FromPaul Gevers <elbrus@debian.org>
Date2025-07-05 16:10 +0200
SubjectBug#1108224: unblock: zfs-linux/2.3.2-2
Message-ID<L5bKx-fqhd-1@gated-at.bofh.it>
In reply to#1251398

[Multipart message — attachments visible in raw view] — view raw

Control: tags -1 confirmed moreinfo

Hi,

On 29-06-2025 16:17, Shengqi Chen wrote:
>> 2025年6月29日 22:14,Shengqi Chen <harry@debian.org> 写道:
>> Control: retitle -1 unblock: zfs-linux/2.3.2-2

>> After reviewing, we have decided to backport important fix only, as a targeted fix.
>> So here is the new pre-approval unblock request with debdiff attached.
> 
> Sorry I forgot the attachment, here it is:


Please go ahead and remove the moreinfo tag once the upload happened and 
the package is ready to be unblocked.

Paul

[toc] | [prev] | [standalone]


Back to top | Article view | linux.debian.bugs.dist


csiph-web