Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.bugs.dist > #1230978 > unrolled thread

Bug#1092597: RFS: findent/4.3.4-1 -- indents/converts Fortran sources

Back to article view | Back to linux.debian.bugs.dist

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Bug#1092597: RFS: findent/4.3.4-1 -- indents/converts Fortran sources Jeroen Ploemen <jcfp@debian.org> - 2025-01-30 12:40 +0100
    Bug#1092597: RFS: findent/4.3.4-1 -- indents/converts Fortran sources Willem Vermin <wvermin@gmail.com> - 2025-02-03 15:40 +0100
      Bug#1092597: RFS: findent/4.3.4-1 -- indents/converts Fortran sources Jeroen Ploemen <jcfp@debian.org> - 2025-02-04 16:10 +0100

#1230978 — Bug#1092597: RFS: findent/4.3.4-1 -- indents/converts Fortran sources

[Multipart message — attachments visible in raw view] — view raw

Control: tags -1 moreinfo

On Thu, 9 Jan 2025 16:02:34 +0100
Willem Vermin <wvermin@gmail.com> wrote:

> I am looking for a sponsor for my package findent:

hi Willem,

as noted by Phil, the package seems to build and pass the usual test
just fine. Some other stuff came up during review though:

* changelog: there are changes in d/copyright without mention in
  the Debian changelog. Please document all packaging changes.

* copyright: version mix-up in the new paragraph for the builtparser
  files: "On Debian systems, the full text of the GNU General Public
  License version 2 can be found in the file [...]/GPL-3".

* copyright: the paragraph for vim/findent.vim and vim/fortran.vim
  defines the license for these files as 'Fair'. Details of that
  license don't seem to be present anywhere in the upstream sources,
  but exist only in d/copyright:

  > Usage of the works is permitted provided that this instrument is
  > retained with the works, so that any entity that uses the works
  > is notified of this instrument.
  > DISCLAIMER: THE WORKS ARE WITHOUT WARRANTY.
  
  I realise you are both upstream developer and Debian maintainer for
  this package, but those are two separate roles. If you wish to
  license files in a certain way, you want to wear your upstream hat
  and ensure the terms are part of the upstream source release.

  The license text, as quoted above, only grants permission for
  'usage', but not modification or distribution, and requires users
  are to be 'notified of this instrument' whatever that is supposed
  to entail. Those terms likely fall short of the requirements set in
  the DFSG [1].

  Is there any benefit or purpose to having these specific files under
  a custom license versus the standard 3-clause BSD that applies to
  most of the source code?


[1]https://wiki.debian.org/DebianFreeSoftwareGuidelines

Please remove the moreinfo tag (and CC me) once you have an updated
package ready.

[toc] | [next] | [standalone]

#1231590

Hi Jeroen,

thanks for the comprehensive analysis of findent.

I think I was able to implement all of your comments,
if not, let me know, no problem at all.

I uploaded a new version of findent: findent-4.3.5 :

https://mentors.debian.net/package/findent/
  
https://mentors.debian.net/debian/pool/main/f/findent/findent_4.3.5-1.dsc

and I will remove the moreinfo tag, cc-ing you.

Regards,

Willem

On 1/30/25 12:32, Jeroen Ploemen wrote:
> Control: tags -1 moreinfo
> 
> On Thu, 9 Jan 2025 16:02:34 +0100
> Willem Vermin <wvermin@gmail.com> wrote:
> 
>> I am looking for a sponsor for my package findent:
> 
> hi Willem,
> 
> as noted by Phil, the package seems to build and pass the usual test
> just fine. Some other stuff came up during review though:
> 
> * changelog: there are changes in d/copyright without mention in
>    the Debian changelog. Please document all packaging changes.
> 
> * copyright: version mix-up in the new paragraph for the builtparser
>    files: "On Debian systems, the full text of the GNU General Public
>    License version 2 can be found in the file [...]/GPL-3".
> 
> * copyright: the paragraph for vim/findent.vim and vim/fortran.vim
>    defines the license for these files as 'Fair'. Details of that
>    license don't seem to be present anywhere in the upstream sources,
>    but exist only in d/copyright:
> 
>    > Usage of the works is permitted provided that this instrument is
>    > retained with the works, so that any entity that uses the works
>    > is notified of this instrument.
>    > DISCLAIMER: THE WORKS ARE WITHOUT WARRANTY.
>    
>    I realise you are both upstream developer and Debian maintainer for
>    this package, but those are two separate roles. If you wish to
>    license files in a certain way, you want to wear your upstream hat
>    and ensure the terms are part of the upstream source release.
> 
>    The license text, as quoted above, only grants permission for
>    'usage', but not modification or distribution, and requires users
>    are to be 'notified of this instrument' whatever that is supposed
>    to entail. Those terms likely fall short of the requirements set in
>    the DFSG [1].
> 
>    Is there any benefit or purpose to having these specific files under
>    a custom license versus the standard 3-clause BSD that applies to
>    most of the source code?
> 
> 
> [1]https://wiki.debian.org/DebianFreeSoftwareGuidelines
> 
> Please remove the moreinfo tag (and CC me) once you have an updated
> package ready.

[toc] | [prev] | [next] | [standalone]

#1231758

[Multipart message — attachments visible in raw view] — view raw

On Mon, 3 Feb 2025 15:35:41 +0100
Willem Vermin <wvermin@gmail.com> wrote:

> I think I was able to implement all of your comments,
> if not, let me know, no problem at all.
> 
> I uploaded a new version of findent: findent-4.3.5 :

Willem, thanks for update. Uploaded as-is.

Just a small note for a future package update: now that the license
for vim/{findent,fortran}.vim matches that of the remainder of your
source code, the separate paragraph for these files is redundant and
could be removed.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.bugs.dist

csiph-web