Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.bugs.dist > #1245717 > unrolled thread

Bug#1105163: zutils: -4 upload breaks piuparts

Back to article view | Back to linux.debian.bugs.dist

Contents

  Bug#1105163: zutils: -4 upload breaks piuparts Helmut Grohne <helmut@subdivi.de> - 2025-05-12 17:40 +0200
    Bug#1105163: zutils: -4 upload breaks piuparts Daniel Baumann <daniel@debian.org> - 2025-05-12 19:00 +0200

#1245717 — Bug#1105163: zutils: -4 upload breaks piuparts

[Multipart message — attachments visible in raw view] — view raw

Package: zutils
Version: 1.14-4
Severity: serious
Justification: piuparts failure breaks testing migration
Tags: patch
X-Debbugs-Cc: jspricke@debian.org
User: helmutg@debian.org
Usertags: dep17

Hi,

Jochen made me aware that zutils didn't pass piuparts. When I came up
with the previous patch, I foolishly concluded that I'd be better than
piuparts at coming up with tests and wrote tests that didn't cover the
obvious. I ran everything through my tests and didn't bother running
piuparts in the end. Now piuparts fails.

I introduced a logic inversion. When moving the diverted files on a
fresh installation, the .usr-is-merged suffix is appended whenever it
should not be and vice versa. It is the ${GZIP_PREFIX:+.usr-is-merged}
interpolation that is wrong.

For some reason beyond my comprehension, I ruled out dpkg --verify as a
tool for testing. Don't task me why. It finds this issue. Additionally,
I've also implemented manual verification of diverted files. The updated
tools now also fail with current unstable.

I'm attaching updated test cases as well as another patch. Let me know
if you prefer me to handle the upload. The patch now also handles
upgrading from the broken -4 version that never reached trixie. This
scenario is not covered by the attached tests, but I manually verified
that the wrongly moved files get corrected.

Last but not least, the attached version passes piuparts this time.

I'll also follow up with the unblock request.

I really hope that this is the last iteration for zutils.

Helmut

[toc] | [next] | [standalone]

#1245726

On 5/12/25 17:30, Helmut Grohne wrote:
> I'm attaching updated test cases as well as another patch.

thanks - much appreciated, and uploaded.

Regards,
Daniel

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.bugs.dist

csiph-web