Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.debian.bugs.dist > #1242449 > unrolled thread

Bug#1103429: dhcpcd-base: Move hooks to /usr/libexec ?

Started byLaurent Bigonville <bigon@debian.org>
First post2025-04-17 15:30 +0200
Last post2025-04-30 14:30 +0200
Articles 4 — 3 participants

Back to article view | Back to linux.debian.bugs.dist


Contents

  Bug#1103429: dhcpcd-base: Move hooks to /usr/libexec ? Laurent Bigonville <bigon@debian.org> - 2025-04-17 15:30 +0200
    Bug#1103429: dhcpcd-base: Move hooks to /usr/libexec ? Martin-Éric Racine <martin-eric.racine@iki.fi> - 2025-04-17 15:40 +0200
    Bug#1103429: dhcpcd-base: Move hooks to /usr/libexec ? Martin-Éric Racine <martin-eric.racine@iki.fi> - 2025-04-19 14:10 +0200
    Bug#1103429: dhcpcd-base: Move hooks to /usr/libexec ? Daniel Gröber <dxld@darkboxed.org> - 2025-04-30 14:30 +0200

#1242449 — Bug#1103429: dhcpcd-base: Move hooks to /usr/libexec ?

FromLaurent Bigonville <bigon@debian.org>
Date2025-04-17 15:30 +0200
SubjectBug#1103429: dhcpcd-base: Move hooks to /usr/libexec ?
Message-ID<KCxtv-ebwg-9@gated-at.bofh.it>
Package: dhcpcd-base
Version: 1:10.1.0-9
Severity: wishlist

Hello,

I see that dhcpcd installs hooks in /usr/lib/dhcpcd/ but today, debian
allows to install executable files in /usr/libexec and a lot of packages
are doing so.

Would be a good idea to move the dhcpcd-run-hooks and the dhcpcd-hooks
directory to /usr/libexec

To achieve this, just remove the --libexecdir flag in debian/rules

Kind regards,
Laurent Bigonville


-- System Information:
Debian Release: trixie/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'unstable'), (1, 'experimental-debug'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 6.13-amd64 (SMP w/12 CPU threads; PREEMPT)
Locale: LANG=fr_BE.UTF-8, LC_CTYPE=fr_BE.UTF-8 (charmap=UTF-8), LANGUAGE=fr_BE:fr
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages dhcpcd-base depends on:
ii  adduser     3.150
ii  libc6       2.41-7
ii  libssl3t64  3.5.0-1
ii  libudev1    257.5-2

dhcpcd-base recommends no packages.

Versions of packages dhcpcd-base suggests:
ii  systemd-resolved [resolvconf]  257.5-2

-- no debconf information

[toc] | [next] | [standalone]


#1242450

FromMartin-Éric Racine <martin-eric.racine@iki.fi>
Date2025-04-17 15:40 +0200
Message-ID<KCxDc-ebAi-9@gated-at.bofh.it>
In reply to#1242449
to 17.4.2025 klo 16.27 Laurent Bigonville (bigon@debian.org) kirjoitti:
>
> Package: dhcpcd-base
> Version: 1:10.1.0-9
> Severity: wishlist
>
> Hello,
>
> I see that dhcpcd installs hooks in /usr/lib/dhcpcd/ but today, debian
> allows to install executable files in /usr/libexec and a lot of packages
> are doing so.
>
> Would be a good idea to move the dhcpcd-run-hooks and the dhcpcd-hooks
> directory to /usr/libexec
>
> To achieve this, just remove the --libexecdir flag in debian/rules

The problem is that since hooks are not executable scripts per-se,
merely script fragments, Lintian responds with:

W: dhcpcd-base: executable-not-elf-or-script [usr/libexec/dhcpcd-hooks/*]

Martin-Éric

[toc] | [prev] | [next] | [standalone]


#1242703

FromMartin-Éric Racine <martin-eric.racine@iki.fi>
Date2025-04-19 14:10 +0200
Message-ID<KDfbb-eHVv-13@gated-at.bofh.it>
In reply to#1242449
On Thu, 17 Apr 2025 16:36:43 +0300
=?UTF-8?Q?Martin=2D=C3=89ric_Racine?= <martin-eric.racine@iki.fi>
wrote:
> to 17.4.2025 klo 16.27 Laurent Bigonville (bigon@debian.org) kirjoitti:
> >
> > Package: dhcpcd-base
> > Version: 1:10.1.0-9
> > Severity: wishlist
> >
> > Hello,
> >
> > I see that dhcpcd installs hooks in /usr/lib/dhcpcd/ but today, debian
> > allows to install executable files in /usr/libexec and a lot of packages
> > are doing so.
> >
> > Would be a good idea to move the dhcpcd-run-hooks and the dhcpcd-hooks
> > directory to /usr/libexec
> >
> > To achieve this, just remove the --libexecdir flag in debian/rules
>
> The problem is that since hooks are not executable scripts per-se,
> merely script fragments, Lintian responds with:
>
> W: dhcpcd-base: executable-not-elf-or-script [usr/libexec/dhcpcd-hooks/*]

I'd really like to hear Lintian maintainers' opinion on this one.

W: dhcpcd-base: executable-not-elf-or-script [usr/libexec/dhcpcd-hooks/01-test]
W: dhcpcd-base: executable-not-elf-or-script
[usr/libexec/dhcpcd-hooks/20-resolv.conf]
W: dhcpcd-base: executable-not-elf-or-script
[usr/libexec/dhcpcd-hooks/30-hostname]
W: dhcpcd-base: executable-not-elf-or-script
[usr/libexec/dhcpcd-hooks/50-timesyncd.conf]

None of the above have any shebang, because they are merely script
fragments sourced by /usr/libexec/dhcpcd-run-hooks (which has the
expected shebang). Could Lintian perhaps not report the above warning
if the files are in a subdirectory of /usr/libexec?

Martin-Éric

[toc] | [prev] | [next] | [standalone]


#1244208

FromDaniel Gröber <dxld@darkboxed.org>
Date2025-04-30 14:30 +0200
Message-ID<KHeJz-hllV-1@gated-at.bofh.it>
In reply to#1242449

[Multipart message — attachments visible in raw view] — view raw

Hi Laurent,

On Thu, Apr 17, 2025 at 03:24:33PM +0200, Laurent Bigonville wrote:
> Would be a good idea to move the dhcpcd-run-hooks and the dhcpcd-hooks
> directory

So we're talking about these:

    /usr/lib/dhcpcd/dhcpcd-hooks/01-test
    /usr/lib/dhcpcd/dhcpcd-hooks/20-resolv.conf
    /usr/lib/dhcpcd/dhcpcd-hooks/30-hostname

> [move] to /usr/libexec

To what end?

Consider that people outside of Debian could be installing their own hooks
here which might cause breakage. Why risk it with change if we're not
trying to achive anything?

In any case since these aren't executable files they should clearly live in
/usr/share. Let the FHS bikeshedding begin ;-).

Honestly though. These seem similar to systemd's /usr/lib/systemd tree
which has files with a similar purpose.

Looking more closesly at dhcpcd-base I'm actually confused. In addtion to
/usr/lib/dhcpcd/dhcpcd-hooks/ there's also eg.  /usr/share/dhcpcd/hooks/
wich has more numbered scripts:

    /usr/share/dhcpcd/hooks/10-wpa_supplicant
    /usr/share/dhcpcd/hooks/15-timezone
    /usr/share/dhcpcd/hooks/29-lookup-hostname

What's the difference?

--Daniel

[toc] | [prev] | [standalone]


Back to top | Article view | linux.debian.bugs.dist


csiph-web