Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.debian.bugs.dist > #1214003 > unrolled thread

Bug#1069862: blktrace: FTBFS on ppc64el in Ubuntu (-O3?) due to wrong code analysis

Started byDaichi Fukui <a.dog.will.talk@akane.waseda.jp>
First post2024-09-23 06:40 +0200
Last post2024-09-25 15:50 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.debian.bugs.dist

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Bug#1069862: blktrace: FTBFS on ppc64el in Ubuntu (-O3?) due to wrong code analysis Daichi Fukui <a.dog.will.talk@akane.waseda.jp> - 2024-09-23 06:40 +0200
    Bug#1069862: blktrace: FTBFS on ppc64el in Ubuntu (-O3?) due to wrong code analysis Chris Hofstaedtler <zeha@debian.org> - 2024-09-23 19:10 +0200
      Bug#1069862: blktrace: FTBFS on ppc64el in Ubuntu (-O3?) due to wrong code analysis Daichi Fukui <a.dog.will.talk@akane.waseda.jp> - 2024-09-25 15:50 +0200

#1214003 — Bug#1069862: blktrace: FTBFS on ppc64el in Ubuntu (-O3?) due to wrong code analysis

FromDaichi Fukui <a.dog.will.talk@akane.waseda.jp>
Date2024-09-23 06:40 +0200
SubjectBug#1069862: blktrace: FTBFS on ppc64el in Ubuntu (-O3?) due to wrong code analysis
Message-ID<JpJ1D-ed4k-1@gated-at.bofh.it>

[Multipart message — attachments visible in raw view] — view raw

Hello Steve,

> It's possible/likely that this build failure is caused by the use of -O3
by
> default for ppc64el builds in Ubuntu; so the attached patch, while it
fixes
> the problem in Ubuntu and should be harmless in Debian, may not be
something
> you want to apply as-is.  Perhaps you would prefer to use $(filter
-O3,...)
> instead?

Thank you for reporting this issue.

Your idea of using $(filter -O3,...) looks good to me, but I would like to
clarify one thing.

When I tried to reproduce the issue on ppc64el with Debian unstable as of
September 22, 2024, I was unable to do so.
According to the build log[0] on ppc64el, it appears that the -O2 option is
used for the build rather than -O3.

For further investigation, if the following change is applied to d/rules,
the issue is reproduced on ppc64el with Debian unstable, but that is not
what we want to do.

```
--- ../blktrace/debian/rules    2024-08-18 06:21:55.984000000 +0000
+++ debian/rules        2024-09-22 06:48:37.696000000 +0000
@@ -5,7 +5,7 @@
 include /usr/share/dpkg/architecture.mk
 include /usr/share/dpkg/pkg-info.mk

-CFLAGS += -Wall -Wextra -Wno-shadow -Werror -g
+CFLAGS += -Wall -Wextra -Wno-shadow -Werror -g -O3

 export DEB_BUILD_MAINT_OPTIONS = hardening=+all future=+all qa=+all
reproducible=+all
```

Additionally, the -O2 option is used for all CPU architectures in Ubuntu
except for ppc64el[1], which makes me wonder why -O3 is used for ppc64el in
Ubuntu.
Do you have any idea why -O3 is used only for ppc64el in Ubuntu?
I would like to know whether this issue is specific to Ubuntu.

[0]
https://buildd.debian.org/status/fetch.php?pkg=blktrace&arch=ppc64el&ver=1.2.0-5&stamp=1551092176&raw=0
[1] https://launchpad.net/ubuntu/+source/blktrace/1.2.0-5build1

Best regards,
Fukui

[toc] | [next] | [standalone]


#1214046

FromChris Hofstaedtler <zeha@debian.org>
Date2024-09-23 19:10 +0200
Message-ID<JpUJr-ek8o-3@gated-at.bofh.it>
In reply to#1214003
On Mon, Sep 23, 2024 at 01:31:51PM +0900, Daichi Fukui wrote:
> Do you have any idea why -O3 is used only for ppc64el in Ubuntu?
> I would like to know whether this issue is specific to Ubuntu.

Ubuntu sets -O3 as default in their dpkg, for ppc64el:

https://github.com/guillemj/dpkg/blob/29684731af629e9103306b7716663e44224e6cab/scripts/Dpkg/Vendor/Ubuntu.pm#L125

Chris

[toc] | [prev] | [next] | [standalone]


#1214233

FromDaichi Fukui <a.dog.will.talk@akane.waseda.jp>
Date2024-09-25 15:50 +0200
Message-ID<JqAz0-eK9v-5@gated-at.bofh.it>
In reply to#1214046

[Multipart message — attachments visible in raw view] — view raw

Hello Chris,
CC: Steve

Thank you for your response.

After reviewing the source code of dpkg, I now understand that the -O3
optimisation level is set by default for ppc64el in Ubuntu.
However, it appears that there is no code to change the optimisation level
based on CPU architecture in Debian.
Therefore, I believe this issue is specific to Ubuntu.

If there are no objections, we can close this issue.
I am happy to continue this discussion if you’d like.

Best regards,
Fukui

[toc] | [prev] | [standalone]


Back to top | Article view | linux.debian.bugs.dist


csiph-web