Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.bugs.dist > #1193745 > unrolled thread

Bug#1068789: nsis: build fails if version number has buildX or ubuntuX suffix

Back to article view | Back to linux.debian.bugs.dist

Contents

  Bug#1068789: nsis: build fails if version number has buildX or ubuntuX suffix Michael Hudson-Doyle <michael.hudson@ubuntu.com> - 2024-04-11 04:40 +0200
    Bug#1068789: nsis: build fails if version number has buildX or ubuntuX suffix Thomas Gaugler <thomas@dadie.net> - 2024-04-12 18:40 +0200

#1193745 — Bug#1068789: nsis: build fails if version number has buildX or ubuntuX suffix

[Multipart message — attachments visible in raw view] — view raw

Package: nsis
Version: build fails if version number has buildX or ubuntuX suffix
Severity: normal
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch
X-Debbugs-Cc: michael.hudson@ubuntu.com

Dear Maintainer,

In Ubuntu we don't do binNMUs, we build sourceful changes with buildX
appended to the version number. This breaks with the current code in
d/rules which passes the whole version number to scons.

The attached patch is not very clean but it does fix the build for me:

  * d/rules: strip off ubuntuX, buildX from package version before feeding it
    to scons as VERSION.

Thanks for considering it!

Cheers,
mwh

-- System Information:
Debian Release: trixie/sid
  APT prefers mantic-updates
  APT policy: (500, 'mantic-updates'), (500, 'mantic-security'), (500, 'mantic'), (100, 'mantic-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.5.0-27-generic (SMP w/16 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE=en_NZ.UTF-8:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

[toc] | [next] | [standalone]

#1193908

[Multipart message — attachments visible in raw view] — view raw

Thanks for making me aware of the issue.

I’d like to fix this issue for other Debian derivatives such as Linux Mint as well.

Would the following change work for you?

VER_REVISION=$(shell echo $(firstword $(subst +, ,$(word 3,$(VERSION_DECOMPOSED)))) | sed 's/[^0-9]//g')

Are there any other suffixes beside build and lowercase $(dpkg-vendor --query Vendor) followed by the revision number?

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.bugs.dist

csiph-web