Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.bugs.dist > #1203500 > unrolled thread

Bug#1075916: libdcmtk-dev: Removed dependencies are required for a CMake target

Back to article view | Back to linux.debian.bugs.dist

Contents

  Bug#1075916: libdcmtk-dev: Removed dependencies are required for a CMake target Adrian Bunk <bunk@debian.org> - 2024-07-07 21:50 +0200
    Bug#1075916: libdcmtk-dev: Removed dependencies are required for a CMake target Sébastien Jodogne <s.jodogne@gmail.com> - 2024-07-08 15:20 +0200

#1203500 — Bug#1075916: libdcmtk-dev: Removed dependencies are required for a CMake target

Package: libdcmtk-dev
Version: 3.6.8-5
Severity: serious
Tags: ftbfs
Control: affects -1 src:orthanc-neuro

https://buildd.debian.org/status/logs.php?pkg=orthanc-neuro&ver=1.1%2Bdfsg-1%2Bb1

...
[ 90%] Linking CXX shared library libOrthancNeuro.so
/usr/bin/cmake -E cmake_link_script CMakeFiles/OrthancNeuro.dir/link.txt --verbose=1
/usr/bin/c++ -fPIC -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -DNDEBUG -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wno-long-long -Wno-variadic-macros -Wl,-z,relro -Wl,-z,now -Wl,--no-undefined -Wl,--as-needed -Wl,--version-script=/<<PKGBUILDDIR>>/Resources/Orthanc/Plugins/VersionScriptPlugins.map -shared -Wl,-soname,libOrthancNeuro.so.1.1 -o libOrthancNeuro.so.1.1 CMakeFiles/OrthancNeuro.dir/Sources/Plugin/Plugin.cpp.o CMakeFiles/OrthancNeuro.dir/Sources/Plugin/PluginFrameDecoder.cpp.o CMakeFiles/OrthancNeuro.dir/Sources/Framework/BufferReader.cpp.o CMakeFiles/OrthancNeuro.dir/Sources/Framework/CSAHeader.cpp.o CMakeFiles/OrthancNeuro.dir/Sources/Framework/CSATag.cpp.o CMakeFiles/OrthancNeuro.dir/Sources/Framework/DicomInstancesCollection.cpp.o CMakeFiles/OrthancNeuro.dir/Sources/Framework/IDicomFrameDecoder.cpp.o CMakeFiles/OrthancNeuro.dir/Sources/Framework/InputDicomInstance.cpp.o CMakeFiles/OrthancNeuro.dir/Sources/Framework/NeuroToolbox.cpp.o CMakeFiles/OrthancNeuro.dir/Sources/Framework/NiftiWriter.cpp.o CMakeFiles/OrthancNeuro.dir/Sources/Framework/Slice.cpp.o CMakeFiles/OrthancNeuro.dir/AUTOGENERATED/EmbeddedResources.cpp.o CMakeFiles/OrthancNeuro.dir/Resources/Orthanc/Plugins/OrthancPluginCppWrapper.cpp.o  -lpthread -lrt -ldl -Wl,-Bstatic -lOrthancFramework -Wl,-Bdynamic -ldcmdata -ldcmjpls -ldcmimage -ldcmjpeg -lofstd -lboost_filesystem -lboost_iostreams -lboost_locale -lboost_regex -lboost_thread -lpugixml -luuid -ljsoncpp -lpng -ljpeg -lz -lniftiio -lznz -lrt -ldl -Wl,-Bstatic -lOrthancFramework -Wl,-Bdynamic -ldcmdata -ldcmjpls -ldcmimage -ldcmjpeg -lofstd -lboost_filesystem -lboost_iostreams -lboost_locale -lboost_regex -lboost_thread -lpugixml -luuid -ljsoncpp -lpng -ljpeg -lz -lniftiio -lznz
/usr/bin/ld: cannot find -lpng: No such file or directory
/usr/bin/ld: cannot find -ljpeg: No such file or directory
/usr/bin/ld: cannot find -lpng: No such file or directory
/usr/bin/ld: cannot find -ljpeg: No such file or directory
collect2: error: ld returned 1 exit status
make[3]: *** [CMakeFiles/OrthancNeuro.dir/build.make:300: libOrthancNeuro.so.1.1] Error 1



dcmtk (3.6.8-4) experimental; urgency=medium
...
  * d/control: Reduce number of dependencies for -dev package


That's problematic when the CMake files require them for some target:
  /usr/lib/x86_64-linux-gnu/cmake/dcmtk/DCMTKTargets.cmake:  INTERFACE_LINK_LIBRARIES "DCMTK::oflog;DCMTK::dcmdata;DCMTK::dcmimgle;/usr/lib/x86_64-linux-gnu/libtiff.so;/usr/lib/x86_64-linux-gnu/libjpeg.so;/usr/lib/x86_64-linux-gnu/libpng.so"

[toc] | [next] | [standalone]

#1203616

Hello Adrian,

> orthanc-neuro builds and links with the shared library when I remove the
> -DORTHANC_FRAMEWORK_USE_SHARED:BOOL=OFF, is there any reason why this
> would not work?

This would not work, because the libOrthancFramework.so shared library
is designed to share code between the Orthanc core and its plugin, and
has not a stable C++ ABI across versions of Orthanc. Static linking is
definitely needed here.

I think that the fix simply consists in adding "libpng-dev" and
"libjpeg-dev" to the "Depends" of "liborthancframwork-dev". These
dependencies were formerly part of "libdcmtk-dev", but have been
removed by the following changeset in the "debian/experimental"
branch, which breaks the packages that build-depend on
"liborthancframework-dev" since its reintegration into master:
https://salsa.debian.org/med-team/dcmtk/-/commit/f032735429e36f188aeac6e9002255ef00f743ab

Kind Regards,
Sébastien-

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.bugs.dist

csiph-web