Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.bugs.dist > #1197891 > unrolled thread

Bug#1071426: logcheck-database: smartd: Match nvme lines too

Back to article view | Back to linux.debian.bugs.dist

Contents

  Bug#1071426: logcheck-database: smartd: Match nvme lines too Stefanos Harhalakis <v13@v13.gr> - 2024-05-19 06:10 +0200
    Bug#1071426: logcheck-database: smartd: Match nvme lines too Stefanos Harhalakis <v13@v13.gr> - 2024-05-21 22:50 +0200

#1197891 — Bug#1071426: logcheck-database: smartd: Match nvme lines too

[Multipart message — attachments visible in raw view] — view raw

Package: logcheck-database
Severity: normal
Tags: patch

See attached patch for matching NVMe devices too in smartd logs


-- System Information:
Debian Release: trixie/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'oldstable-security'), (500, 'unstable'), (500, 'stable'), (500, 'oldstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.6.15-amd64 (SMP w/8 CPU threads; PREEMPT)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE=en_GB
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

[toc] | [next] | [standalone]

#1198209

[Multipart message — attachments visible in raw view] — view raw

Hi,

Indeed. This bugreport was queued on my system for some time. I think that
your new rules catch all of them.

These are some sample nvme lines:

    X Device: /dev/nvme0, state read from
/var/lib/smartmontools/smartd.CT1000P3SSD8-2330E8600000.nvme.state
    X Device: /dev/nvme0, state read from
/var/lib/smartmontools/smartd.SAMSUNG_MZVLB1T0HBLR_000L7-S4EMNF0MB00000.nvme.state
    X Device: /dev/nvme0, state written to
/var/lib/smartmontools/smartd.CT1000P3SSD8-2330E8600000.nvme.state
    X Device: /dev/nvme0, state written to
/var/lib/smartmontools/smartd.SAMSUNG_MZVLB1T0HBLR_000L7-S4EMNF0MB00000.nvme.state
    X Device: /dev/nvme1, state read from
/var/lib/smartmontools/smartd.SAMSUNG_MZVLB1T0HBLR_000L7-S4EMNF0MB00000.nvme.state
    X Device: /dev/nvme1, state written to
/var/lib/smartmontools/smartd.SAMSUNG_MZVLB1T0HBLR_000L7-S4EMNF0MB00000.nvme.state

Compared to sata:

    X Device: /dev/sda [SAT], state read from
/var/lib/smartmontools/smartd.CT250MX500SSD1-21132DE00000.ata.state
    X Device: /dev/sda [SAT], state read from
/var/lib/smartmontools/smartd.Samsung_SSD_750_EVO_250GB-S33SNWDH5000000.ata.state
    X Device: /dev/sda [SAT], state read from
/var/lib/smartmontools/smartd.Samsung_SSD_750_EVO_250GB-S33SNWDH5100000.ata.state
    X Device: /dev/sda [SAT], state read from
/var/lib/smartmontools/smartd.WDC_WD30EFRX_68EUZN0-WD_WMC4N2800000.ata.state
    X Device: /dev/sda [SAT], state read from
/var/lib/smartmontools/smartd.WDC_WD40EFZX_68AWUN0-WD_WX52DC100000.ata.state
    X Device: /dev/sda [SAT], state written to
/var/lib/smartmontools/smartd.CT250MX500SSD1-21132DE00000.ata.state

Also:

    X Monitoring 2 ATA/SATA, 0 SCSI/SAS and 1 NVMe devices
    X Monitoring 2 ATA/SATA, 0 SCSI/SAS and 2 NVMe devices
    X Monitoring 4 ATA/SATA, 0 SCSI/SAS and 1 NVMe devices
    X Monitoring 6 ATA/SATA, 0 SCSI/SAS and 0 NVMe devices




On Mon, 20 May 2024 at 20:04, Richard Lewis <
richard.lewis.debian@googlemail.com> wrote:

> On Sun, 19 May 2024 at 05:06, Stefanos Harhalakis <v13@v13.gr> wrote:
>
> > See attached patch for matching NVMe devices too in smartd logs
>
> Thanks - yes i'd noticed that the rules for smartd need an update and
> this is on the radar - however, the
> update to the names of the .state files i was not aware of!
>
> I think the first part of the patch is  not quite right, per the code
> i think it should be:
>
> # from
> https://sources.debian.org/src/smartmontools/7.4-2/smartd.cpp/#L5829
> ... Monitoring [[:digit:]]+ ATA/SATA, [[:digit:]]+ SCSI/SAS and
> [[:digit:]]+ NVMe devices
>
> It would be really helpful if you could:
>
> 1/ send some sample log output logs,
>
> something like:
> journalctl -t smartd | awk '{$1=$2=$3=$4="";$5="X";print}' | sort -u
>
> would be helpful
>
> I'm especially unsure about the bits of rules that start "Device:" as
> i could not work out what format is expected -- the current rules have
> Device: /dev/[^[:space:]]+( \[[_/[:alnum:][:space:]]+\])?( \[SAT\])?
> but im not sure if the optional groups are up-to-date, -- i couldnt
> find what bit of code determines those.
>
> 2/ the attached rules (untested) are what i'm wokring on for smartd -
> any testing of these would be great
> (I generalised the name of the .state file - again i dont know where
> smartd sets this bit, so hard to know what is expected!)
> (these are completely untested, so may be completely broken)
>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.bugs.dist

csiph-web