Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.bugs.dist > #1180792 > unrolled thread

Bug#1059859: glusterfs: Update gluster.bash source location in glusterfs-cli.install

Back to article view | Back to linux.debian.bugs.dist

Contents

  Bug#1059859: glusterfs: Update gluster.bash source location in glusterfs-cli.install Lena Voytek <lena@voytek.dev> - 2024-01-02 15:30 +0100
    Bug#1059859: glusterfs: Update gluster.bash source location in glusterfs-cli.install Lena Voytek <lena@voytek.dev> - 2024-01-02 15:40 +0100
      Bug#1059859: glusterfs: Update gluster.bash source location in glusterfs-cli.install Patrick Matthäi <patrick@linux-dev.org> - 2024-01-09 11:00 +0100
        Bug#1059859: glusterfs: Update gluster.bash source location in glusterfs-cli.install Lena Voytek <lena@voytek.dev> - 2024-01-09 17:00 +0100
          Bug#1059859: glusterfs: Update gluster.bash source location in glusterfs-cli.install Patrick Matthäi <patrick@linux-dev.org> - 2024-01-09 17:20 +0100
            Bug#1059859: glusterfs: Update gluster.bash source location in glusterfs-cli.install Lena Voytek <lena@voytek.dev> - 2024-01-11 15:40 +0100

#1180792 — Bug#1059859: glusterfs: Update gluster.bash source location in glusterfs-cli.install

Source: glusterfs
Version: 10.1-1
Severity: normal
Tags: patch
X-Debbugs-Cc: lena@voytek.dev

Dear Maintainer,

As noted in the upstream Changelog, in upstream commit
064328f7dd3079164030198cf34d9c43c5f90518 the install location for gluster.bash
was moved from /etc/bash_completion.d to /usr/share/bash-
completion/completions. For glusterfs-cli.install to work properly, it needs
the original location of the file to be updated accordingly. Otherwise it
receives the following error:

Failed to copy 'etc/bash_completion.d/gluster.bash': No such file or directory
at /usr/share/dh-exec/dh-exec-install-rename line 70, <> line 2.
dh_install: error: debian/glusterfs-cli.install (executable config) returned
exit code 127

I'll attach a patch that fixes the issue.

Thanks!


-- System Information:
Debian Release: bookworm/sid
  APT prefers jammy-updates
  APT policy: (500, 'jammy-updates'), (500, 'jammy-security'), (500, 'jammy'), (100, 'jammy-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.15.0-91-generic (SMP w/32 CPU threads)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

[toc] | [next] | [standalone]

#1180793

[Multipart message — attachments visible in raw view] — view raw

Source: glusterfs
Version: 11.1-3
Followup-For: Bug #1059859
X-Debbugs-Cc: lena@voytek.dev

Here is the patch


-- System Information:
Debian Release: bookworm/sid
  APT prefers jammy-updates
  APT policy: (500, 'jammy-updates'), (500, 'jammy-security'), (500, 'jammy'), (100, 'jammy-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.15.0-91-generic (SMP w/32 CPU threads)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

[toc] | [prev] | [next] | [standalone]

#1181680

[Multipart message — attachments visible in raw view] — view raw

Hi Lena,

Am 02.01.2024 um 15:29 schrieb Lena Voytek:
> Source: glusterfs
> Version: 11.1-3
> Followup-For: Bug #1059859
> X-Debbugs-Cc:lena@voytek.dev
>
> Here is the patch
>
Thanks for your patch, but building it on sid gives me this error:

find debian/tmp/usr/lib -type f -name \*.la -delete dh_install Failed to 
copy '/usr/share/bash-completion/completions/gluster.bash': No such file 
or directory at /usr/share/dh-exec/dh-exec-install-rename line 70, <> 
line 2. dh_install: error: debian/glusterfs-cli.install (executable 
config) returned exit code 127 make[1]: *** [debian/rules:34: 
override_dh_install] Error 127 make[1]: Leaving directory 
'/build/glusterfs-11.1' make: *** [debian/rules:20: binary] Error 2

[toc] | [prev] | [next] | [standalone]

#1181713

[Multipart message — attachments visible in raw view] — view raw

Hi Patrick,

Thanks for the reply. I looked into it again and realized this bug only
shows up if the bash-completion package is installed beforehand. If so,
then due to upstream commit 064328f7dd307916 the install directory changes
to /usr/share/bash-completion/completions. This actually causes an issue in
Ubuntu, but it looks like Debian's build system handles it correctly as is.
Sorry for the invalid issue!

On Tue, Jan 9, 2024 at 2:49 AM Patrick Matthäi <patrick@linux-dev.org>
wrote:

> Hi Lena,
> Am 02.01.2024 um 15:29 schrieb Lena Voytek:
>
> Source: glusterfs
> Version: 11.1-3
> Followup-For: Bug #1059859
> X-Debbugs-Cc: lena@voytek.dev
>
> Here is the patch
>
>
> Thanks for your patch, but building it on sid gives me this error:
>
> find debian/tmp/usr/lib -type f -name \*.la -delete dh_install Failed to
> copy '/usr/share/bash-completion/completions/gluster.bash': No such file or
> directory at /usr/share/dh-exec/dh-exec-install-rename line 70, <> line 2.
> dh_install: error: debian/glusterfs-cli.install (executable config)
> returned exit code 127 make[1]: *** [debian/rules:34: override_dh_install]
> Error 127 make[1]: Leaving directory '/build/glusterfs-11.1' make: ***
> [debian/rules:20: binary] Error 2
>

[toc] | [prev] | [next] | [standalone]

#1181716

[Multipart message — attachments visible in raw view] — view raw

Hey

Am 09.01.2024 um 16:53 schrieb Lena Voytek:
> Hi Patrick,
>
> Thanks for the reply. I looked into it again and realized this bug 
> only shows up if the bash-completion package is installed beforehand. 
> If so, then due to upstream commit 064328f7dd307916 the install 
> directory changes to /usr/share/bash-completion/completions. This 
> actually causes an issue in Ubuntu, but it looks like Debian's build 
> system handles it correctly as is. Sorry for the invalid issue!

Hm good point, thanks for testing. I think in this case it would be 
"build" safer also in not clean environments to b-d on bash-completion 
and let glusterfs then use the correct path.

I will test it in the next days if it builds clean in both ways


>
> On Tue, Jan 9, 2024 at 2:49 AM Patrick Matthäi <patrick@linux-dev.org> 
> wrote:
>
>     Hi Lena,
>
>     Am 02.01.2024 um 15:29 schrieb Lena Voytek:
>>     Source: glusterfs
>>     Version: 11.1-3
>>     Followup-For: Bug #1059859
>>     X-Debbugs-Cc:lena@voytek.dev
>>
>>     Here is the patch
>>
>     Thanks for your patch, but building it on sid gives me this error:
>
>     find debian/tmp/usr/lib -type f -name \*.la -delete dh_install
>     Failed to copy
>     '/usr/share/bash-completion/completions/gluster.bash': No such
>     file or directory at /usr/share/dh-exec/dh-exec-install-rename
>     line 70, <> line 2. dh_install: error:
>     debian/glusterfs-cli.install (executable config) returned exit
>     code 127 make[1]: *** [debian/rules:34: override_dh_install] Error
>     127 make[1]: Leaving directory '/build/glusterfs-11.1' make: ***
>     [debian/rules:20: binary] Error 2
>

[toc] | [prev] | [next] | [standalone]

#1181931

[Multipart message — attachments visible in raw view] — view raw

Thanks for adding this fix! The package is also building again in Ubuntu.

On Tue, Jan 9, 2024 at 9:09 AM Patrick Matthäi <patrick@linux-dev.org>
wrote:

> Hey
> Am 09.01.2024 um 16:53 schrieb Lena Voytek:
>
> Hi Patrick,
>
> Thanks for the reply. I looked into it again and realized this bug only
> shows up if the bash-completion package is installed beforehand. If so,
> then due to upstream commit 064328f7dd307916 the install directory changes
> to /usr/share/bash-completion/completions. This actually causes an issue in
> Ubuntu, but it looks like Debian's build system handles it correctly as is.
> Sorry for the invalid issue!
>
> Hm good point, thanks for testing. I think in this case it would be
> "build" safer also in not clean environments to b-d on bash-completion and
> let glusterfs then use the correct path.
>
> I will test it in the next days if it builds clean in both ways
>
>
>
> On Tue, Jan 9, 2024 at 2:49 AM Patrick Matthäi <patrick@linux-dev.org>
> wrote:
>
>> Hi Lena,
>> Am 02.01.2024 um 15:29 schrieb Lena Voytek:
>>
>> Source: glusterfs
>> Version: 11.1-3
>> Followup-For: Bug #1059859
>> X-Debbugs-Cc: lena@voytek.dev
>>
>> Here is the patch
>>
>>
>> Thanks for your patch, but building it on sid gives me this error:
>>
>> find debian/tmp/usr/lib -type f -name \*.la -delete dh_install Failed to
>> copy '/usr/share/bash-completion/completions/gluster.bash': No such file or
>> directory at /usr/share/dh-exec/dh-exec-install-rename line 70, <> line 2.
>> dh_install: error: debian/glusterfs-cli.install (executable config)
>> returned exit code 127 make[1]: *** [debian/rules:34: override_dh_install]
>> Error 127 make[1]: Leaving directory '/build/glusterfs-11.1' make: ***
>> [debian/rules:20: binary] Error 2
>>
>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.debian.bugs.dist

csiph-web